Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-23 18:36:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Misc: Fixed array out of bounds access when loading locales_achievement_reward, locales_creature_text, locales_gossip_menu_option and skip LOCALE_none when iterating over locales

Browse Source
This commit is contained in:
Shauren
2016-01-24 15:08:49 +01:00
parent d5b0ffbe9b
commit 11ad71e2fc
5 changed files with 25 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/server/game/Chat/ChatLink.cpp
View File

@@ -230,6 +230,9 @@ bool ItemChatLink::ValidateName(char* buffer, const char* context)
{
for (uint8 index = LOCALE_koKR; index < TOTAL_LOCALES; ++index)
{
if (index == LOCALE_none)
continue;
if (FormatName(index, suffixStrings) == buffer)
{
res = true;
@@ -412,8 +415,13 @@ bool AchievementChatLink::ValidateName(char* buffer, const char* context)
ChatLink::ValidateName(buffer, context);
for (uint8 locale = LOCALE_enUS; locale < TOTAL_LOCALES; ++locale)
{
if (locale == LOCALE_none)
continue;
if (strcmp(_achievement->Title->Str[locale], buffer) == 0)
return true;
}
TC_LOG_TRACE("chat.system", "ChatHandler::isValidChatMessage('%s'): linked achievement (id: %u) name wasn't found in any localization", context, _achievement->ID);
return false;