From 31b5632c0006cf74f83d5cece5e0e40579d27501 Mon Sep 17 00:00:00 2001 From: Treeston Date: Mon, 12 Aug 2019 14:19:22 +0200 Subject: [PATCH] Common/Utilities: Explicit tail recursion to keep the compilers happy. --- src/common/Utilities/advstd.h | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/common/Utilities/advstd.h b/src/common/Utilities/advstd.h index 86edcd4445d..187df3c15be 100644 --- a/src/common/Utilities/advstd.h +++ b/src/common/Utilities/advstd.h @@ -112,11 +112,13 @@ namespace advstd template constexpr std::enable_if_t && advstd::is_unsigned_v, std::common_type_t> gcd(T1 m, T2 n) { - if (m < n) - return gcd(n, m); - if (!n) - return m; - return gcd(n, m%n); + while (n) + { + std::swap(m,n); + if (m <= n) + n %= m; + } + return m; } // C++17 std::lcm