From 35b5eaed8fe1943c81e702764443ea47e3ec8b17 Mon Sep 17 00:00:00 2001 From: ariel- Date: Sun, 19 Mar 2017 19:33:30 -0300 Subject: [PATCH] Core/AchievementMgr: fix integer underflow neglecting already completed realm firsts Closes #19334 (cherry picked from commit 9cfa7c752e1d61b02acb852d2fd304a80d10b60a) --- src/server/game/Achievements/AchievementMgr.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/server/game/Achievements/AchievementMgr.cpp b/src/server/game/Achievements/AchievementMgr.cpp index 22cf99698d5..fc90cd55ea3 100644 --- a/src/server/game/Achievements/AchievementMgr.cpp +++ b/src/server/game/Achievements/AchievementMgr.cpp @@ -3332,6 +3332,9 @@ bool AchievementGlobalMgr::IsRealmCompleted(AchievementEntry const* achievement) if (itr->second == std::chrono::system_clock::time_point::min()) return false; + if (itr->second == std::chrono::system_clock::time_point::max()) + return true; + // Allow completing the realm first kill for entire minute after first person did it // it may allow more than one group to achieve it (highly unlikely) // but apparently this is how blizz handles it as well @@ -3567,7 +3570,7 @@ void AchievementGlobalMgr::LoadCompletedAchievements() continue; } else if (achievement->Flags & (ACHIEVEMENT_FLAG_REALM_FIRST_REACH | ACHIEVEMENT_FLAG_REALM_FIRST_KILL | ACHIEVEMENT_FLAG_REALM_FIRST_GUILD)) - _allCompletedAchievements[achievementId] = std::chrono::system_clock::time_point::max();; + _allCompletedAchievements[achievementId] = std::chrono::system_clock::time_point::max(); } while (result->NextRow()); TC_LOG_INFO("server.loading", ">> Loaded %lu realm first completed achievements in %u ms.", (unsigned long)_allCompletedAchievements.size(), GetMSTimeDiffToNow(oldMSTime));