Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-18 08:28:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Threat: fix a potential super edge case iterator invalidation

Browse Source
This commit is contained in:
Treeston
2018-01-09 23:42:22 +01:00
parent a23c97a0fc
commit 3dcd49ef90
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/server/game/Combat/ThreatManager.cpp
View File

@@ -333,7 +333,9 @@ void ThreatManager::AddThreat(Unit* target, float amount, SpellInfo const* spell
if (!redirInfo.empty()) if (!redirInfo.empty())
{ {
float const origAmount = amount; float const origAmount = amount;
for (auto const& pair : redirInfo) // (victim,pct) // intentional copy - there's a nested AddThreat call further down that might cause AI calls which cast spells
auto const redirects = redirInfo;
for (auto const& pair : redirects) // (victim,pct)
{ {
Unit* redirTarget = nullptr; Unit* redirTarget = nullptr;
auto it = _myThreatListEntries.find(pair.first); // try to look it up in our threat list first (faster) auto it = _myThreatListEntries.find(pair.first); // try to look it up in our threat list first (faster)