From 52a53ea2ab6b27951f0863ee85ecf5b9c316e9db Mon Sep 17 00:00:00 2001 From: jackpoz Date: Sun, 26 Nov 2017 12:30:02 +0100 Subject: [PATCH] Core/Maps: Fix memory leak in BoundaryUnionBoundary Add missing destructor in BoundaryUnionBoundary to avoid reporting a memory leak (even if it's used only in a global variable) --- src/server/game/Maps/AreaBoundary.cpp | 5 +++++ src/server/game/Maps/AreaBoundary.h | 1 + 2 files changed, 6 insertions(+) diff --git a/src/server/game/Maps/AreaBoundary.cpp b/src/server/game/Maps/AreaBoundary.cpp index 952d82668bb..6ed21ec50f6 100644 --- a/src/server/game/Maps/AreaBoundary.cpp +++ b/src/server/game/Maps/AreaBoundary.cpp @@ -103,6 +103,11 @@ BoundaryUnionBoundary::BoundaryUnionBoundary(AreaBoundary const* b1, AreaBoundar { ASSERT(b1 && b2); } +BoundaryUnionBoundary::~BoundaryUnionBoundary() +{ + delete _b1; + delete _b2; +} bool BoundaryUnionBoundary::IsWithinBoundaryArea(Position const* pos) const { return (_b1->IsWithinBoundary(pos) || _b2->IsWithinBoundary(pos)); diff --git a/src/server/game/Maps/AreaBoundary.h b/src/server/game/Maps/AreaBoundary.h index 1e8f22e9cd4..dab73e9b51b 100644 --- a/src/server/game/Maps/AreaBoundary.h +++ b/src/server/game/Maps/AreaBoundary.h @@ -157,6 +157,7 @@ class TC_GAME_API BoundaryUnionBoundary : public AreaBoundary BoundaryUnionBoundary(AreaBoundary const* b1, AreaBoundary const* b2, bool isInverted = false); protected: + virtual ~BoundaryUnionBoundary(); bool IsWithinBoundaryArea(Position const* pos) const override; private: