From 53d2ecf1239443d14432b4f82fa2047ab941a26a Mon Sep 17 00:00:00 2001 From: Ovahlord Date: Sat, 9 Nov 2019 01:11:46 +0100 Subject: [PATCH] Core/Auras: removed obsolete crit chance member --- src/server/game/Spells/Auras/SpellAuraEffects.cpp | 5 ++--- src/server/game/Spells/Auras/SpellAuraEffects.h | 3 --- src/server/scripts/Spells/spell_dk.cpp | 2 -- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/server/game/Spells/Auras/SpellAuraEffects.cpp b/src/server/game/Spells/Auras/SpellAuraEffects.cpp index 2d5c55d0106..f1a78b75c7a 100644 --- a/src/server/game/Spells/Auras/SpellAuraEffects.cpp +++ b/src/server/game/Spells/Auras/SpellAuraEffects.cpp @@ -440,9 +440,8 @@ pAuraEffectHandler AuraEffectHandler[TOTAL_AURAS]= AuraEffect::AuraEffect(Aura* base, uint8 effIndex, int32 *baseAmount, Unit* caster): m_base(base), m_spellInfo(base->GetSpellInfo()), m_baseAmount(baseAmount ? *baseAmount : m_spellInfo->Effects[effIndex].BasePoints), -m_bonusAmount(0), m_critChance(0.0f), m_donePct(1.0f), -m_spellmod(nullptr), m_periodicTimer(0), m_tickNumber(0), m_effIndex(effIndex), -m_canBeRecalculated(true), m_isPeriodic(false) +m_bonusAmount(0), m_donePct(1.0f), m_spellmod(nullptr), m_periodicTimer(0), m_tickNumber(0), +m_effIndex(effIndex), m_canBeRecalculated(true), m_isPeriodic(false) { CalculatePeriodic(caster, true, false); diff --git a/src/server/game/Spells/Auras/SpellAuraEffects.h b/src/server/game/Spells/Auras/SpellAuraEffects.h index 80359eb25c1..35da89a8d01 100644 --- a/src/server/game/Spells/Auras/SpellAuraEffects.h +++ b/src/server/game/Spells/Auras/SpellAuraEffects.h @@ -75,8 +75,6 @@ class TC_GAME_API AuraEffect void SetBonusAmount(int32 val) { m_bonusAmount = val; } int32 GetBonusAmount() const { return m_bonusAmount; } - void SetCritChance(float val) { m_critChance = val; } - float GetCritChance() const { return m_critChance; } void SetDonePct(float val) { m_donePct = val; } float GetDonePct() const { return m_donePct; } @@ -110,7 +108,6 @@ class TC_GAME_API AuraEffect int32 m_amount; int32 m_bonusAmount; - float m_critChance; float m_donePct; SpellModifier* m_spellmod; diff --git a/src/server/scripts/Spells/spell_dk.cpp b/src/server/scripts/Spells/spell_dk.cpp index 1643c5357d9..fefac013371 100644 --- a/src/server/scripts/Spells/spell_dk.cpp +++ b/src/server/scripts/Spells/spell_dk.cpp @@ -693,7 +693,6 @@ class spell_dk_pestilence : public SpellScript if (AuraEffect* aurEffOld = aurOld->GetEffect(EFFECT_0)) { float donePct = aurEffOld->GetDonePct(); - float critChance = aurEffOld->GetCritChance(); caster->CastSpell(hitUnit, SPELL_DK_BLOOD_PLAGUE, true); // Spread the disease to hitUnit. @@ -701,7 +700,6 @@ class spell_dk_pestilence : public SpellScript { if (AuraEffect* aurEffNew = aurNew->GetEffect(EFFECT_0)) { - aurEffNew->SetCritChance(critChance); // Blood Plague can crit if caster has T9. aurEffNew->SetDonePct(donePct); aurEffNew->SetBonusAmount(caster->SpellDamageBonusDone(hitUnit, aurEffNew->GetSpellInfo(), 0, DOT, aurEffNew->GetEffIndex())); }