Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-15 23:20:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/PacketIO: Read directly into output variable for numeric ByteBuffer::operator>> overloads

Browse Source
This commit is contained in:
Shauren
2024-12-19 19:45:58 +01:00
parent 736836a3f5
commit 5a1fe84978
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/server/shared/Packets/ByteBuffer.cpp
View File

@@ -41,7 +41,7 @@ ByteBufferInvalidValueException::ByteBufferInvalidValueException(char const* typ
ByteBuffer& ByteBuffer::operator>>(float& value)
{
value = read<float>();
read(&value, 1);
if (!std::isfinite(value))
throw ByteBufferInvalidValueException("float", "infinity");
return *this;
@@ -49,7 +49,7 @@ ByteBuffer& ByteBuffer::operator>>(float& value)
ByteBuffer& ByteBuffer::operator>>(double& value)
{
value = read<double>();
read(&value, 1);
if (!std::isfinite(value))
throw ByteBufferInvalidValueException("double", "infinity");
return *this;

16
src/server/shared/Packets/ByteBuffer.h
View File

@@ -320,50 +320,50 @@ class TC_SHARED_API ByteBuffer
ByteBuffer& operator>>(uint8& value)
{
value = read<uint8>();
read(&value, 1);
return *this;
}
ByteBuffer& operator>>(uint16& value)
{
value = read<uint16>();
read(&value, 1);
return *this;
}
ByteBuffer& operator>>(uint32& value)
{
value = read<uint32>();
read(&value, 1);
return *this;
}
ByteBuffer& operator>>(uint64& value)
{
value = read<uint64>();
read(&value, 1);
return *this;
}
//signed as in 2e complement
ByteBuffer& operator>>(int8& value)
{
value = read<int8>();
read(&value, 1);
return *this;
}
ByteBuffer& operator>>(int16& value)
{
value = read<int16>();
read(&value, 1);
return *this;
}
ByteBuffer& operator>>(int32& value)
{
value = read<int32>();
read(&value, 1);
return *this;
}
ByteBuffer& operator>>(int64& value)
{
value = read<int64>();
read(&value, 1);
return *this;
}