Core/Creatures: Moved autoattack handling from scripts to game

src/server/scripts/World/boss_emerald_dragons.cpp

@@ -156,8 +156,6 @@ struct emerald_dragonAI : public WorldBossAI
 
         if (Unit* target = SelectTarget(SelectTargetMethod::MaxThreat, 0, -50.0f, true))
             DoCast(target, SPELL_SUMMON_PLAYER);
-
-        DoMeleeAttackIfReady();
     }
 };
 

src/server/scripts/World/npc_guard.cpp

@@ -129,12 +129,8 @@ struct npc_guard_generic : public GuardAI
                 {
                     me->resetAttackTimer();
                     DoCastVictim(spellInfo->Id);
-                    meleeContext.Repeat();
-                    return;
                 }
             }
-            me->AttackerStateUpdate(victim);
-            me->resetAttackTimer();
             meleeContext.Repeat();
         }).Schedule(Seconds(5), [this](TaskContext spellContext)
         {
@@ -205,10 +201,7 @@ struct npc_guard_shattrath_faction : public GuardAI
         if (!UpdateVictim())
             return;
 
-        _scheduler.Update(diff, [this]
-        {
-            DoMeleeAttackIfReady();
-        });
+        _scheduler.Update(diff);
     }
 
     void ScheduleVanish()

src/server/scripts/World/npcs_special.cpp

@@ -251,8 +251,7 @@ public:
                     ResetFlagTimer -= diff;
             }
 
-            if (UpdateVictim())
-                DoMeleeAttackIfReady();
+            UpdateVictim();
         }
 
         void ReceiveEmote(Player* player, uint32 emote) override