From 62a96c8f30ee5282d17306ec0fa991189cdabdd2 Mon Sep 17 00:00:00 2001 From: Ovahlord Date: Sat, 29 Aug 2020 22:48:22 +0200 Subject: [PATCH] Core/AI: SortByDistance will now sort the referenced list instead of a copy of it. This fixes MinDistance and MaxDistance target selection --- src/server/game/AI/CoreAI/UnitAI.cpp | 2 +- src/server/game/AI/CoreAI/UnitAI.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/server/game/AI/CoreAI/UnitAI.cpp b/src/server/game/AI/CoreAI/UnitAI.cpp index 22024f612eb..b989d9d76c3 100644 --- a/src/server/game/AI/CoreAI/UnitAI.cpp +++ b/src/server/game/AI/CoreAI/UnitAI.cpp @@ -246,7 +246,7 @@ ThreatManager& UnitAI::GetThreatManager() return me->GetThreatManager(); } -void UnitAI::SortByDistance(std::list list, bool ascending) +void UnitAI::SortByDistance(std::list& list, bool ascending) { list.sort(Trinity::ObjectDistanceOrderPred(me, ascending)); } diff --git a/src/server/game/AI/CoreAI/UnitAI.h b/src/server/game/AI/CoreAI/UnitAI.h index 687403412be..39eb9cda8f9 100644 --- a/src/server/game/AI/CoreAI/UnitAI.h +++ b/src/server/game/AI/CoreAI/UnitAI.h @@ -327,7 +327,7 @@ class TC_GAME_API UnitAI UnitAI& operator=(UnitAI const& right) = delete; ThreatManager& GetThreatManager(); - void SortByDistance(std::list list, bool ascending = true); + void SortByDistance(std::list& list, bool ascending = true); }; #endif