Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-15 23:20:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/DBLayer: Optimized prepared statement query results by eliminating unneeded buffer copies

Browse Source 
* Improved error logs for using incorrect Field getters to also include table name, field name and field index.
This commit is contained in:
Shauren
2015-08-26 17:00:26 +02:00
parent 614b5832ba
commit 65dbc7082a
5 changed files with 130 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/server/database/Database/QueryResult.h
View File

@@ -73,18 +73,18 @@ class PreparedResultSet
Field* Fetch() const
{
ASSERT(m_rowPosition < m_rowCount);
return m_rows[uint32(m_rowPosition)];
return const_cast<Field*>(&m_rows[uint32(m_rowPosition) * m_fieldCount]);
}
const Field & operator [] (uint32 index) const
Field const& operator[](uint32 index) const
{
ASSERT(m_rowPosition < m_rowCount);
ASSERT(index < m_fieldCount);
return m_rows[uint32(m_rowPosition)][index];
return m_rows[uint32(m_rowPosition) * m_fieldCount + index];
}
protected:
std::vector<Field*> m_rows;
std::vector<Field> m_rows;
uint64 m_rowCount;
uint64 m_rowPosition;
uint32 m_fieldCount;
@@ -92,12 +92,11 @@ class PreparedResultSet
private:
MYSQL_BIND* m_rBind;
MYSQL_STMT* m_stmt;
MYSQL_RES* m_res;
MYSQL_RES* m_metadataResult; ///< Field metadata, returned by mysql_stmt_result_metadata
my_bool* m_isNull;
unsigned long* m_length;
void FreeBindBuffer();
void CleanUp();
bool _NextRow();