mirror of
https://github.com/TrinityCore/TrinityCore.git
synced 2026-01-21 09:44:45 +01:00
[7330] Code warnings and style cleanups. Some bugs fixes. Author: VladimirMangos
1) comparison singed and unsigned values
2) redundent includes
3) wrong constructor :-part field initilization
4) unused not-/*name*/-guarded args in template/virtual functions that not required like args.
5) explicitly list not implemented achievement types.
Also bugs fixed:
1) Drop wrong phase mask 0 check in WorldObject::InSamePhase.
2) ArenaTeamMember::ModifyPersonalRating incorrect work with move points in negative with infinity values in result.
3) ArenaTeam::SaveToDB code send uint64 value to string with arg format %u.
--HG--
branch : trunk
This commit is contained in:
@@ -3553,7 +3553,7 @@ bool ChatHandler::HandleGuildInviteCommand(const char *args)
|
||||
plGuid = objmgr.GetPlayerGUIDByName (plName);
|
||||
|
||||
if (!plGuid)
|
||||
false;
|
||||
return false;
|
||||
|
||||
// player's guild membership checked in AddMember before add
|
||||
if (!targetGuild->AddMember (plGuid,targetGuild->GetLowestRank ()))
|
||||
@@ -6985,8 +6985,6 @@ bool ChatHandler::HandleSendMoneyCommand(const char* args)
|
||||
return false;
|
||||
}
|
||||
|
||||
uint32 mailId = objmgr.GenerateMailID();
|
||||
|
||||
// from console show not existed sender
|
||||
uint32 sender_guidlo = m_session ? m_session->GetPlayer()->GetGUIDLow() : 0;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user