From 70697c6fcef8f7e0445590ad5f5dc37f09c839ad Mon Sep 17 00:00:00 2001
From: Aokromes <aokromes@gmail.com>
Date: Sun, 3 Apr 2016 08:04:26 +0200
Subject: [PATCH] Core: fixed few coverity issues and warnings

---
 src/server/bnetserver/Packets/ConnectionPackets.h           | 4 ++--
 src/server/game/Spells/SpellInfo.cpp                        | 1 +
 .../scripts/EasternKingdoms/BaradinHold/boss_alizabal.cpp   | 6 +++---
 .../EasternKingdoms/BaradinHold/boss_pit_lord_argaloth.cpp  | 2 +-
 .../BlackrockCaverns/blackrock_caverns.cpp                  | 2 +-
 .../BlackrockMountain/BlackrockCaverns/boss_corla.cpp       | 2 +-
 .../EasternKingdoms/Deadmines/instance_deadmines.cpp        | 4 ++--
 7 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/src/server/bnetserver/Packets/ConnectionPackets.h b/src/server/bnetserver/Packets/ConnectionPackets.h
index 69371f4d3d8..be71eafc851 100644
--- a/src/server/bnetserver/Packets/ConnectionPackets.h
+++ b/src/server/bnetserver/Packets/ConnectionPackets.h
@@ -134,9 +134,9 @@ namespace Battlenet
             void CallHandler(Session* session) override;
 
             PacketHeader Header;
-            ClosingReason Reason;
+            ClosingReason Reason = PACKET_CORRUPT;
             std::vector<PacketInfo> Packets;
-            time_t Now;
+            time_t Now = 0;
         };
 
         class Pong final : public ServerPacket
diff --git a/src/server/game/Spells/SpellInfo.cpp b/src/server/game/Spells/SpellInfo.cpp
index 22f5f0a1c59..cc5635b0626 100644
--- a/src/server/game/Spells/SpellInfo.cpp
+++ b/src/server/game/Spells/SpellInfo.cpp
@@ -1014,6 +1014,7 @@ SpellInfo::SpellInfo(SpellEntry const* spellEntry, SpellEffectEntry const** effe
     Targets = _target ? _target->Targets : 0;
     TargetCreatureType = _target ? _target->TargetCreatureType : 0;
     MaxAffectedTargets = _target ? _target->MaxAffectedTargets : 0;
+    MaxTargetLevel = _target ? _target->MaxTargetLevel : 0;
 
     // SpellTotemsEntry
     SpellTotemsEntry const* _totem = GetSpellTotems();
diff --git a/src/server/scripts/EasternKingdoms/BaradinHold/boss_alizabal.cpp b/src/server/scripts/EasternKingdoms/BaradinHold/boss_alizabal.cpp
index 4cccd0ca174..bd866dcc07d 100644
--- a/src/server/scripts/EasternKingdoms/BaradinHold/boss_alizabal.cpp
+++ b/src/server/scripts/EasternKingdoms/BaradinHold/boss_alizabal.cpp
@@ -251,9 +251,9 @@ class boss_alizabal : public CreatureScript
             }
 
         private:
-            bool _intro;
-            bool _hate;
-            bool _skewer;
+            bool _intro =false;
+            bool _hate =false;
+            bool _skewer =false;
 
         };
 
diff --git a/src/server/scripts/EasternKingdoms/BaradinHold/boss_pit_lord_argaloth.cpp b/src/server/scripts/EasternKingdoms/BaradinHold/boss_pit_lord_argaloth.cpp
index 667d981a20e..5b2d8b895ec 100644
--- a/src/server/scripts/EasternKingdoms/BaradinHold/boss_pit_lord_argaloth.cpp
+++ b/src/server/scripts/EasternKingdoms/BaradinHold/boss_pit_lord_argaloth.cpp
@@ -183,7 +183,7 @@ class spell_argaloth_meteor_slash : public SpellScriptLoader
             }
 
         private:
-            uint32 _targetCount;
+            uint32 _targetCount =0;
         };
 
         SpellScript* GetSpellScript() const override
diff --git a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/blackrock_caverns.cpp b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/blackrock_caverns.cpp
index 450e8f9db97..96cac465a3f 100644
--- a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/blackrock_caverns.cpp
+++ b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/blackrock_caverns.cpp
@@ -213,7 +213,7 @@ public: npc_twilight_flame_caller() : CreatureScript("npc_twilight_flame_caller"
             ObjectGuid      _flamecaller1GUID;
             ObjectGuid      _flamecaller2GUID;
             SummonList      _summons;
-            bool            _combatPhase;
+            bool _combatPhase =false;
         };
 
         CreatureAI* GetAI(Creature* creature) const override
diff --git a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/boss_corla.cpp b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/boss_corla.cpp
index e3ac4ae054b..12a8c92efb8 100644
--- a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/boss_corla.cpp
+++ b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/boss_corla.cpp
@@ -114,7 +114,7 @@ class boss_corla : public CreatureScript
             }
 
         private:
-            bool combatPhase;
+            bool combatPhase =false;
         };
 
         CreatureAI* GetAI(Creature* creature) const override
diff --git a/src/server/scripts/EasternKingdoms/Deadmines/instance_deadmines.cpp b/src/server/scripts/EasternKingdoms/Deadmines/instance_deadmines.cpp
index 7599cf38f08..83a73cbd2b2 100644
--- a/src/server/scripts/EasternKingdoms/Deadmines/instance_deadmines.cpp
+++ b/src/server/scripts/EasternKingdoms/Deadmines/instance_deadmines.cpp
@@ -72,8 +72,8 @@ class instance_deadmines : public InstanceMapScript
             ObjectGuid MrSmiteGUID;
 
             uint32 State;
-            uint32 CannonBlast_Timer;
-            uint32 PiratesDelay_Timer;
+            uint32 CannonBlast_Timer =0;
+            uint32 PiratesDelay_Timer =0;
             uint32 SmiteAlarmDelay_Timer;
             ObjectGuid uiSmiteChestGUID;