From 7802e88ace7d19831fb68747445e51887809bbad Mon Sep 17 00:00:00 2001 From: ariel- Date: Wed, 15 Mar 2017 13:44:24 -0300 Subject: [PATCH] Core/Auras: use vectors and remove HasEffect check - Already checked in GetApplicationList --- .../game/Spells/Auras/SpellAuraEffects.cpp | 20 +++++++++---------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/src/server/game/Spells/Auras/SpellAuraEffects.cpp b/src/server/game/Spells/Auras/SpellAuraEffects.cpp index eda557b9387..697e146206f 100644 --- a/src/server/game/Spells/Auras/SpellAuraEffects.cpp +++ b/src/server/game/Spells/Auras/SpellAuraEffects.cpp @@ -705,12 +705,11 @@ void AuraEffect::ChangeAmount(int32 newAmount, bool mark, bool onStackOrReapply) if (!handleMask) return; - std::list effectApplications; + std::vector effectApplications; GetApplicationList(effectApplications); - for (std::list::const_iterator apptItr = effectApplications.begin(); apptItr != effectApplications.end(); ++apptItr) - if ((*apptItr)->HasEffect(GetEffIndex())) - HandleEffect(*apptItr, handleMask, false); + for (AuraApplication* aurApp : effectApplications) + HandleEffect(aurApp, handleMask, false); if (handleMask & AURA_EFFECT_HANDLE_CHANGE_AMOUNT) { @@ -721,9 +720,8 @@ void AuraEffect::ChangeAmount(int32 newAmount, bool mark, bool onStackOrReapply) CalculateSpellMod(); } - for (std::list::const_iterator apptItr = effectApplications.begin(); apptItr != effectApplications.end(); ++apptItr) - if ((*apptItr)->HasEffect(GetEffIndex())) - HandleEffect(*apptItr, handleMask, true); + for (AuraApplication* aurApp : effectApplications) + HandleEffect(aurApp, handleMask, true); } void AuraEffect::HandleEffect(AuraApplication * aurApp, uint8 mode, bool apply) @@ -850,12 +848,12 @@ void AuraEffect::Update(uint32 diff, Unit* caster) m_periodicTimer += m_amplitude - diff; UpdatePeriodic(caster); - std::list effectApplications; + std::vector effectApplications; GetApplicationList(effectApplications); + // tick on targets of effects - for (std::list::const_iterator apptItr = effectApplications.begin(); apptItr != effectApplications.end(); ++apptItr) - if ((*apptItr)->HasEffect(GetEffIndex())) - PeriodicTick(*apptItr, caster); + for (AuraApplication* aurApp : effectApplications) + PeriodicTick(aurApp, caster); } } }