From 786bb561ca8b92033b962321d998fa2266f6e529 Mon Sep 17 00:00:00 2001 From: ariel- Date: Sun, 19 Mar 2017 19:33:30 -0300 Subject: [PATCH] Core/AchievementMgr: fix integer underflow neglecting already completed realm firsts Closes #19334 (cherry picked from commit 9cfa7c752e1d61b02acb852d2fd304a80d10b60a) --- src/server/game/Achievements/AchievementMgr.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/server/game/Achievements/AchievementMgr.cpp b/src/server/game/Achievements/AchievementMgr.cpp index 77ed2075a33..12e33cf9ee3 100644 --- a/src/server/game/Achievements/AchievementMgr.cpp +++ b/src/server/game/Achievements/AchievementMgr.cpp @@ -1016,6 +1016,9 @@ bool AchievementGlobalMgr::IsRealmCompleted(AchievementEntry const* achievement) if (itr->second == std::chrono::system_clock::time_point::min()) return false; + if (itr->second == std::chrono::system_clock::time_point::max()) + return true; + // Allow completing the realm first kill for entire minute after first person did it // it may allow more than one group to achieve it (highly unlikely) // but apparently this is how blizz handles it as well