Core/Group: Fix possible crash (#29400)

This commit is contained in:
Jeremy
2023-10-30 00:03:37 +01:00
committed by GitHub
parent d8f59dcc40
commit 79e69f3634

View File

@@ -315,7 +315,6 @@ void WorldSession::HandleSetRoleOpcode(WorldPackets::Party::SetRole& packet)
if (oldRole == packet.Role)
return;
roleChangedInform.PartyIndex = group->GetGroupCategory();
roleChangedInform.From = GetPlayer()->GetGUID();
roleChangedInform.ChangedUnit = packet.TargetGUID;
roleChangedInform.OldRole = oldRole;
@@ -323,6 +322,7 @@ void WorldSession::HandleSetRoleOpcode(WorldPackets::Party::SetRole& packet)
if (group)
{
roleChangedInform.PartyIndex = group->GetGroupCategory();
group->BroadcastPacket(roleChangedInform.Write(), false);
group->SetLfgRoles(packet.TargetGUID, packet.Role);
}