Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-15 23:20:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Logging: Minor internal refactor

Browse Source 
* Avoid formatting to output with fprintf
* Use vector instead of unordered_map to store appenders in Logger
This commit is contained in:
Shauren
2024-07-16 16:31:40 +02:00
parent 14f7c0984f
commit 81bec6954f
13 changed files with 82 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/common/Logging/AppenderFile.cpp
View File

@@ -21,8 +21,8 @@
#include "StringConvert.h"
#include <algorithm>
AppenderFile::AppenderFile(uint8 id, std::string const& name, LogLevel level, AppenderFlags flags, std::vector<std::string_view> const& args) :
Appender(id, name, level, flags),
AppenderFile::AppenderFile(uint8 id, std::string name, LogLevel level, AppenderFlags flags, std::vector<std::string_view> const& args) :
Appender(id, std::move(name), level, flags),
logfile(nullptr),
_logDir(sLog->GetLogsDir()),
_maxFileSize(0),
@@ -78,7 +78,9 @@ void AppenderFile::_write(LogMessage const* message)
FILE* file = OpenFile(namebuf, "a", _backup || exceedMaxSize);
if (!file)
return;
fprintf(file, "%s%s\n", message->prefix.c_str(), message->text.c_str());
fwrite(message->prefix.c_str(), 1, message->prefix.length(), file);
fwrite(message->text.c_str(), 1, message->text.length(), file);
fwrite("\n", 1, 1, file);
fflush(file);
_fileSize += uint64(message->Size());
fclose(file);
@@ -90,7 +92,9 @@ void AppenderFile::_write(LogMessage const* message)
if (!logfile)
return;
fprintf(logfile, "%s%s\n", message->prefix.c_str(), message->text.c_str());
fwrite(message->prefix.c_str(), 1, message->prefix.length(), logfile);
fwrite(message->text.c_str(), 1, message->text.length(), logfile);
fwrite("\n", 1, 1, logfile);
fflush(logfile);
_fileSize += uint64(message->Size());
}