From 852ffcc139873643da335155fddde10704aaec4b Mon Sep 17 00:00:00 2001 From: Spp Date: Wed, 28 Sep 2011 10:21:15 +0200 Subject: [PATCH] Core/Scripting: Remove unnecesary reference in param function OnMemberRemove --- src/server/game/Chat/Channels/Channel.cpp | 1 - src/server/game/Conditions/ConditionMgr.h | 8 ++++---- src/server/game/DataStores/DBCStructure.h | 2 +- src/server/game/DungeonFinding/LFGScripts.cpp | 2 +- src/server/game/DungeonFinding/LFGScripts.h | 2 +- src/server/game/Scripting/ScriptMgr.h | 2 +- 6 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/server/game/Chat/Channels/Channel.cpp b/src/server/game/Chat/Channels/Channel.cpp index 9cf8ee29b08..413070ca1de 100755 --- a/src/server/game/Chat/Channels/Channel.cpp +++ b/src/server/game/Chat/Channels/Channel.cpp @@ -1068,4 +1068,3 @@ void Channel::LeaveNotify(uint64 guid) else SendToAll(&data); } - diff --git a/src/server/game/Conditions/ConditionMgr.h b/src/server/game/Conditions/ConditionMgr.h index 406ae5d88b2..2aec58db48c 100755 --- a/src/server/game/Conditions/ConditionMgr.h +++ b/src/server/game/Conditions/ConditionMgr.h @@ -133,11 +133,11 @@ struct Condition }; typedef std::list ConditionList; -typedef std::map ConditionTypeMap; -typedef std::map ConditionMap; -typedef std::map VehicleSpellConditionMap; +typedef std::map ConditionTypeMap; +typedef std::map ConditionMap; +typedef std::map VehicleSpellConditionMap; -typedef std::map ConditionReferenceMap;//only used for references +typedef std::map ConditionReferenceMap;//only used for references class ConditionMgr { diff --git a/src/server/game/DataStores/DBCStructure.h b/src/server/game/DataStores/DBCStructure.h index 431e803fa87..2c7bfb3eb1d 100755 --- a/src/server/game/DataStores/DBCStructure.h +++ b/src/server/game/DataStores/DBCStructure.h @@ -874,7 +874,7 @@ struct FactionEntry // helpers bool CanHaveReputation() const { - return reputationListID >=0; + return reputationListID >= 0; } }; diff --git a/src/server/game/DungeonFinding/LFGScripts.cpp b/src/server/game/DungeonFinding/LFGScripts.cpp index c3c6cd86548..23eb10a98ae 100644 --- a/src/server/game/DungeonFinding/LFGScripts.cpp +++ b/src/server/game/DungeonFinding/LFGScripts.cpp @@ -55,7 +55,7 @@ void LFGScripts::OnAddMember(Group* group, uint64 guid) sLFGMgr->Leave(plr); } -void LFGScripts::OnRemoveMember(Group* group, uint64 guid, RemoveMethod& method, uint64 kicker, const char* reason) +void LFGScripts::OnRemoveMember(Group* group, uint64 guid, RemoveMethod method, uint64 kicker, const char* reason) { uint64 gguid = group->GetGUID(); if (!gguid || method == GROUP_REMOVEMETHOD_DEFAULT) diff --git a/src/server/game/DungeonFinding/LFGScripts.h b/src/server/game/DungeonFinding/LFGScripts.h index 0547a3fad34..9a2d358188f 100644 --- a/src/server/game/DungeonFinding/LFGScripts.h +++ b/src/server/game/DungeonFinding/LFGScripts.h @@ -33,7 +33,7 @@ class LFGScripts: public GroupScript, public PlayerScript // Group Hooks void OnAddMember(Group* group, uint64 guid); - void OnRemoveMember(Group* group, uint64 guid, RemoveMethod& method, uint64 kicker, const char* reason); + void OnRemoveMember(Group* group, uint64 guid, RemoveMethod method, uint64 kicker, const char* reason); void OnDisband(Group* group); void OnChangeLeader(Group* group, uint64 newLeaderGuid, uint64 oldLeaderGuid); void OnInviteMember(Group* group, uint64 guid); diff --git a/src/server/game/Scripting/ScriptMgr.h b/src/server/game/Scripting/ScriptMgr.h index 61d24c949e6..5925992a3c2 100755 --- a/src/server/game/Scripting/ScriptMgr.h +++ b/src/server/game/Scripting/ScriptMgr.h @@ -785,7 +785,7 @@ class GroupScript : public ScriptObject virtual void OnInviteMember(Group* /*group*/, uint64 /*guid*/) { } // Called when a member is removed from a group. - virtual void OnRemoveMember(Group* /*group*/, uint64 /*guid*/, RemoveMethod& /*method*/, uint64 /*kicker*/, const char* /*reason*/) { } + virtual void OnRemoveMember(Group* /*group*/, uint64 /*guid*/, RemoveMethod /*method*/, uint64 /*kicker*/, const char* /*reason*/) { } // Called when the leader of a group is changed. virtual void OnChangeLeader(Group* /*group*/, uint64 /*newLeaderGuid*/, uint64 /*oldLeaderGuid*/) { }