From a8f0ec3e92d6591788919dff82e7bc3934ca6c84 Mon Sep 17 00:00:00 2001 From: Shauren Date: Sat, 27 Mar 2021 09:49:53 +0100 Subject: [PATCH] Core/Auras: Corrected logic used to determine if a spellmod should affect another spell, empty family name or class mask should not apply to any spell --- src/server/game/Spells/SpellInfo.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/server/game/Spells/SpellInfo.cpp b/src/server/game/Spells/SpellInfo.cpp index ab7c323431f..8b32fece4fd 100644 --- a/src/server/game/Spells/SpellInfo.cpp +++ b/src/server/game/Spells/SpellInfo.cpp @@ -1539,6 +1539,9 @@ bool SpellInfo::IsAffectedBySpellMod(SpellModifier const* mod) const return false; return IsAffected(affectSpell->SpellFamilyName, mod->mask); + // TEMP: dont use IsAffected - !familyName and !familyFlags are not valid options for spell mods + // TODO: investigate if the !familyName and !familyFlags conditions are even valid for all other (nonmod) uses of SpellInfo::IsAffected + return affectSpell->SpellFamilyName == SpellFamilyName && mod->mask & SpellFamilyFlags; } bool SpellInfo::CanPierceImmuneAura(SpellInfo const* auraSpellInfo) const