Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-15 23:20:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Groups: Use iterators instead of raw LinkedListElement to interact with group members

Browse Source
This commit is contained in:
Shauren
2025-07-11 17:40:34 +02:00
parent ae197a62b7
commit cbb532e4be
31 changed files with 251 additions and 321 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/server/game/Handlers/BattleGroundHandler.cpp
View File

@@ -224,12 +224,9 @@ void WorldSession::HandleBattlemasterJoinOpcode(WorldPackets::Battleground::Batt
avgTime = bgQueue.GetAverageQueueWaitTime(ginfo, bracketEntry->GetBracketId());
}
for (GroupReference const* itr = grp->GetFirstMember(); itr != nullptr; itr = itr->next())
for (GroupReference const& itr : grp->GetMembers())
{
Player* member = itr->GetSource();
if (!member)
continue; // this should never happen
Player* member = itr.GetSource();
if (err)
{
WorldPackets::Battleground::BattlefieldStatusFailed battlefieldStatus;
@@ -578,12 +575,9 @@ void WorldSession::HandleBattlemasterJoinArena(WorldPackets::Battleground::Battl
avgTime = bgQueue.GetAverageQueueWaitTime(ginfo, bracketEntry->GetBracketId());
}
for (GroupReference* itr = grp->GetFirstMember(); itr != nullptr; itr = itr->next())
for (GroupReference const& itr : grp->GetMembers())
{
Player* member = itr->GetSource();
if (!member)
continue;
Player* member = itr.GetSource();
if (err)
{
WorldPackets::Battleground::BattlefieldStatusFailed battlefieldStatus;