Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-23 02:25:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Addons: Improve WorldSession::ReadAddonsInfo

Browse Source 
* Only allow built-in addons to be marked as secure
* Better protect against malformed packets
This commit is contained in:
Shauren
2019-07-15 17:47:35 +02:00
parent 37f69825c4
commit cd3d317ebf
6 changed files with 150 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/server/game/Addons/AddonMgr.cpp
View File

@@ -66,7 +66,7 @@ void LoadFromDB()
TC_LOG_INFO("server.loading", ">> Loaded 0 known addons. DB table `addons` is empty!");
oldMSTime = getMSTime();
result = CharacterDatabase.Query("SELECT id, name, version, UNIX_TIMESTAMP(timestamp) FROM banned_addons");
result = CharacterDatabase.Query("SELECT id, name, version, UNIX_TIMESTAMP(timestamp) FROM banned_addons ORDER BY timestamp");
if (result)
{
uint32 count = 0;
@@ -96,18 +96,16 @@ void LoadFromDB()
}
}
void SaveAddon(AddonInfo const& addon)
void SaveAddon(std::string const& name, uint32 publicKeyCrc)
{
std::string name = addon.Name;
PreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_INS_ADDON);
stmt->setString(0, name);
stmt->setUInt32(1, addon.CRC);
stmt->setUInt32(1, publicKeyCrc);
CharacterDatabase.Execute(stmt);
m_knownAddons.push_back(SavedAddon(addon.Name, addon.CRC));
m_knownAddons.emplace_back(name, publicKeyCrc);
}
SavedAddon const* GetAddonInfo(const std::string& name)