From f8cf934775dd71d9e67bc0ab86f5001158528bb3 Mon Sep 17 00:00:00 2001 From: Trazom62 Date: Tue, 20 Apr 2010 21:55:47 +0200 Subject: [PATCH] Fix crash in AchievementCriteriaData::Meets. Fixes issue #1555. --HG-- branch : trunk --- src/game/AchievementMgr.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/game/AchievementMgr.cpp b/src/game/AchievementMgr.cpp index 7abdc06affb..60396c299a9 100644 --- a/src/game/AchievementMgr.cpp +++ b/src/game/AchievementMgr.cpp @@ -333,9 +333,9 @@ bool AchievementCriteriaData::Meets(uint32 criteria_id, Player const* source, Un if (!source->IsInWorld()) return false; Map* map = source->GetMap(); - if (!map->Instanceable()) + if (!map->IsDungeon()) { - sLog.outErrorDb("Achievement system call ACHIEVEMENT_CRITERIA_DATA_INSTANCE_SCRIPT (%u) for achievement criteria %u for non-instance map %u", + sLog.outErrorDb("Achievement system call ACHIEVEMENT_CRITERIA_DATA_INSTANCE_SCRIPT (%u) for achievement criteria %u for non-dungeon/non-raid map %u", ACHIEVEMENT_CRITERIA_DATA_INSTANCE_SCRIPT, criteria_id, map->GetId()); return false; }