7915 Commits

Author SHA1 Message Date
Shauren
9a806e63c1 Fixed compile
--HG--
branch : trunk
2010-12-14 16:31:01 +01:00
Shauren
314376e32c Scripts: Fixed uninitialized variables, unreferenced parameters and virtual overrides
--HG--
branch : trunk
2010-12-14 16:24:59 +01:00
Shauren
0c04b178db Scripts/Icecrown Citadel: Minor adjustments and compile warning fixes
--HG--
branch : trunk
2010-12-14 15:46:54 +01:00
click
2642894342 Core: Add new system for parallelizing client packet processing. Handle WorldSession updates in Map::Update() where we are safe to proceed. Patch by Ambal.
(And clean up tabs and whitespace while rummaging around in there)
Closes issue 5084.

--HG--
branch : trunk
2010-12-13 22:37:56 +01:00
Shauren
dd2602d3ec Fixed line endings in 10623_world_spell_bonus_data
Scripts/Naxxramas: Fixed a possible crash in instance script

--HG--
branch : trunk
2010-12-12 17:32:26 +01:00
azazel
d2d62eab50 Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
NOTE: Initially I just wanted to fix some warnings, but noticed that there is no common method for percentage calculation and various formulas are used many time in the code making it difficult to read and understand what the code actually does. So, I introduced several template methods for calculating percent values and adding those values to the original base. I replaced all the raw calculations throughout the code where found, but I could have missed something or could have made a mistake. So, please report any strange behaviour after this commit.
If you ask me why I did it: for the sake of consistency and exact understanding what code means. If you see CalculatePct method, you clearly understand, that it find the value of x percent of y. And you can easily express, for example, spell behviour "reduces smth by x%" by the means of a method instead of recalling school maths.

--HG--
branch : trunk
2010-12-11 20:37:38 +06:00
azazel
08f205722a Scripts/Quest: implement dummy effects for spells 43882, 50133 and aura 43874 for quests 11396/11399 Bring Down Those Shields (based on code by NoFantasy)
--HG--
branch : trunk
2010-12-10 12:01:57 +06:00
Shauren
e4e048ed57 Core/Scripts: Fixed possible crashes in instance scripts (Icecrown Citadel and Naxxramas)
Scripts/Sunwell Plateau: Fixed crash in Kil'jaeden
Scripts/Icecrown Citadel: Fixed crash in Blood-Queen Lana'thel

Closes issue #5051.
Closes issue #5050.
Closes issue #5035.

--HG--
branch : trunk
2010-12-08 17:24:31 +01:00
Shauren
703835ee94 Core/Quests: Fixed Unholy Infusion (24749), Blood Infusion (24756) and added partial support for Frost Infusion (24757)
--HG--
branch : trunk
2010-12-06 22:54:19 +01:00
Spp
408fce1de6 Core: Some optimizations
- Declare some functions const
- Fix some mem leak
- Fix some resource leak
- Remove unused variables and functions
- Remove duplicate functions
- Reduce the scope of some variables
- Remove unused file

--HG--
branch : trunk
2010-12-06 02:07:53 +01:00
QAston
59c1a238f5 Scripts/AuraScript: Make AuraApplication in OnEffectPeriodic never be NULL.
Scripts: remove some unnecessary NULL checks from scripts.

--HG--
branch : trunk
2010-12-05 21:38:52 +01:00
leak
6fe19b5a86 Core/Scripts: Split OnCreatureCreate() and OnGameObjectCreate() into two virtual functions each.
Note to scripters: be aware that you will need to hook into the Remove functions if you want to do stuff at GO/creature removal.
Closes issue 5011.

--HG--
branch : trunk
2010-12-05 18:04:10 +01:00
Spp
e621f5fe98 Core/Dungeon Finder: Code cleanup and minor optimizations
- Extend LfgState to keep control of the state of group and players using LFG
- Move scripts to its own class and initialize only if Dungeon finder is enabled
- Updated comments to doxygen format
- Use constructor initialization list
- All variables are declared in the inner most scope
- Fix some mem leaks
- Remove no longer needed code (Cleaner)
- Normalize handler function names

--HG--
branch : trunk
2010-12-05 17:50:26 +01:00
Shauren
04b4364908 Scripts/Icecrown Citadel: Fixed crash in Blood-Queen Lana'thel script
Closes issue #5017.

--HG--
branch : trunk
2010-12-04 12:53:01 +01:00
Liberate
526c15336d Scripts/Pit of Saron: Fix a crash at Scourgelord Tyrannus.
Closes issue #4601

--HG--
branch : trunk
2010-12-04 02:20:32 +01:00
_manuel_
51a66dc427 Core/Scripts: Implemented core script for quest "Stunning Defeat at the Ring" (11300), original code from ScriptDev2 thanks to kiper for porting, also for a full functionality for this quest you need the DB scripts made by him.
--HG--
branch : trunk
2010-12-03 17:36:07 -03:00
Shauren
e0c992a8ba Scripts/Icecrown Citadel: Added script for Blood Queen Lana'Thel
Scripts/Icecrown Citadel: Fixed Invocation of Blood announcement emote for Blood Prince Council
Scripts/Icecrown Citadel: Fixed intro for Lady Deathwhisper
Scripts/Icecrown Citadel: Fixed Bone Spike for Lord Marrowgar

--HG--
branch : trunk
2010-12-03 17:47:33 +01:00
Shauren
892f56c37d Fixed compile, missed these changes
--HG--
branch : trunk
2010-12-03 14:14:08 +01:00
Shauren
96ab1a102f Scripts/Trial of the Crusader: Fixed crashes in Gormok the Impaler
Closes issue #4515.

--HG--
branch : trunk
2010-12-03 14:02:41 +01:00
Shauren
3badf69b63 Core/Spells: Fixed bad Z coordinate for Spell::EffectBind with location stored in database
Core/Scripts: Corrected few mistakes in misc scripts

--HG--
branch : trunk
2010-12-03 13:54:00 +01:00
_manuel_
651ff8565a Core/Scripts: Implemented script for quest The hunt is on (11794).
--HG--
branch : trunk
2010-12-01 15:29:35 -03:00
Spp
25ac835507 Core/Groups: Move all function definition from .h to .cpp
Core/Groups: Remove Group.h dependency from any .h file

--HG--
branch : trunk
2010-11-29 07:50:31 +01:00
Shauren
eb0a5467c2 Scripts/Icecrown Citadel: Fixed possible exploits in Deathbringer Saurfang's script
--HG--
branch : trunk
2010-11-26 22:46:09 +01:00
Spp
fa97598594 Core/Dungeon Finder: Move vote kick initialization from Group code to Scripts
--HG--
branch : trunk
2010-11-23 20:49:57 +01:00
Spp
d3c9478153 Core/Groups: Add kicker and kick reason to RemoveMember
--HG--
branch : trunk
2010-11-23 20:49:36 +01:00
click
d1ade6f6b8 Revert r5dcfc475b8 (we're still investigating why it does what it does though)
--HG--
branch : trunk
2010-11-22 16:07:32 +01:00
Spp
6b5ff1ca25 Core: Fix some warnings
--HG--
branch : trunk
2010-11-22 10:10:46 +01:00
click
ea9e88a48c Core/Scripts: Add support for questID 25444 (Da Perfect Spies)
--HG--
branch : trunk
2010-11-21 23:43:44 +01:00
click
634ddae566 Core/Commands: Fix issues with crashes related to .gobject near command usage (thanks to Josh for finding the bug and culprit)
--HG--
branch : trunk
2010-11-21 23:00:03 +01:00
Shauren
632a976b05 Scripts/Icecrown Citadel: More code style cleanup
--HG--
branch : trunk
2010-11-20 23:50:09 +01:00
Shauren
2a039e726a Scripts/Icecrown Citadel: Added basic threat support for Blood Prince council in no-damage mode
--HG--
branch : trunk
2010-11-20 23:10:32 +01:00
Shauren
6d244e8f13 Scripts/Forge of Souls: Cleaned up code style
Scripts/Forge of Souls: Fixed a possible crash

Closes issue #4660.

--HG--
branch : trunk
2010-11-20 21:27:10 +01:00
Shauren
417b29af24 Scripts/Forge of Souls: Fixed typo in instance script, thx Ramus for spotting it
--HG--
branch : trunk
2010-11-20 21:06:00 +01:00
click
3e27be7501 Core/Scripts: Tidy up commandscripts to adhere to scripting-standards and fix some minor typos (fix by Paradox)
Closes issue #4859.

--HG--
branch : trunk
2010-11-19 14:04:21 +01:00
Shauren
418cf49a72 Scripts/Icecrown Citadel: Changed spell timers for Lord Marrowgar, taken from sniffs
Scripts/Icecrown Citadel: Converted texts to new TextMgr
Scripts/Icecrown Citadel: General cleanup & coding style consistency
Scripts/Icecrown Citadel: Added missing spell script names

--HG--
branch : trunk
2010-11-18 15:57:23 +01:00
azazel
87d723405e Core/Scripts: return const modifier to Player methods back (should restore compilation for those with custom scripts).
NOTE: The main idea of original change is to allow scripts change content of message so that calling method sends modified message to client.
For example, moderating script which cuts illegal words from message.

--HG--
branch : trunk
2010-11-18 10:26:34 +06:00
azazel
4fb572015a Core/Scripts: pass message parameter by reference in OnChat methods to make it possible to be modified inside the script.
--HG--
branch : trunk
2010-11-17 18:14:35 +06:00
click
8806a3efdb Core/Script: Add spellscript for Earthbind totem spell (patch by Socolin)
--HG--
branch : trunk
2010-11-17 00:05:20 +01:00
click
95e956a0b5 Core/Scripts: Convert more commands over to CommandScripts (moves gobject, honor, quest, reload, titles and wp commands to scripts) - Patch by Paradox
(Also fixes a minor visual error on GM-listings (gm ingame/gm list) when the respective user had an R in his/her name).
Closes issue 4792.

--HG--
branch : trunk
2010-11-16 21:27:25 +01:00
Rat
f5edd6ef2a Core/AI: implemented Talk() for the 'new' textMgr
--HG--
branch : trunk
2010-11-16 19:21:48 +01:00
Spp
addd762c4d Core: Fix warnings
--HG--
branch : trunk
2010-11-16 14:08:12 +01:00
Spp
3e2c1a4169 Scripts: Fix quests "...Or Maybe We Don't" and "Smoke 'Em Out"
Author: Lopin
Closes issue 4741

--HG--
branch : trunk
2010-11-16 11:52:31 +01:00
linencloth
8fae0c176d Core/Units: Rename and change Get/SetVisibility to use a bool value instead of an unnecessary enum
Also replace some SetVisibility hacks to directly call UpdateObjectVisibility

--HG--
branch : trunk
2010-11-16 01:13:04 +01:00
Shocker
43588a272d Core/Commands: Fix npc add commands and add check for npc add item to ensure a creature is selected. Patch by Paradox (thanks to rothmans92 for reporting the problem)
--HG--
branch : trunk
2010-11-15 02:45:48 +02:00
Shocker
48d90fab32 Misc: Some engrish fixes, thanks to ZxBiohazardZx, closes issue 4740
--HG--
branch : trunk
2010-11-14 23:46:34 +02:00
Supabad
343478b0e6 Scripts/dustwallow marsh:
- Traitors Among Us
- Discrediting the Deserters
by lopin

--HG--
branch : trunk
2010-11-14 14:40:03 +01:00
Shauren
9ba52c474b Scripts/Icecrown Citadel: Fixed Festergut's Pungent Blight getting interrupted
Scripts/Icecrown Citadel: Changed handling of Deathbringer Saurfang's Blood Power aura (its now always active, starts with 0 value)
Scripts/Icecrown Citadel: Fixed Deathbringer Saurfang's achievement (I've Made a Mess)
Scripts/Icecrown Citadel: Fixed Mark of the Fallen Champion aura removal (Deathbringer Saurfang)

--HG--
branch : trunk
2010-11-14 00:21:57 +01:00
click
61f07610fd Core/Scripts: Fix some includes in debugcommands-script (now works properly on non-PCH compiles)
--HG--
branch : trunk
2010-11-14 00:13:51 +01:00
click
c374f3245a Scripts/Commands: Add tele and event commands to commandscripts system and streamlining the command selection process to ensure the correct command is run when using abbreviations
Patch by Paradox (some cleanups was needed)

--HG--
branch : trunk
2010-11-13 22:29:46 +01:00
linencloth
a312e7b337 Scripts/Misc: Cleanup and fix victim handling of the snakes of Snake Trap
--HG--
branch : trunk
2010-11-13 20:24:20 +01:00