Commit Graph

22638 Commits

Author SHA1 Message Date
jackpoz
c04f53b886 Core/Warden: Fix Warden reporting false positive checks
Issue introduced in 210176fd91
2020-08-08 17:24:18 +02:00
Keader
9b87a7e03b Game/ActionHouse: Fixed some clothes chests not showing in AH (#25150) 2020-08-08 10:31:35 -03:00
Jinnaix
de56ed8736 Scripts/BlackwingLair: Suppression Device Room (PR #25199)
Co-authored-by: offl <11556157+offl@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Treeston <treeston.mmoc@gmail.com>
2020-08-08 00:27:16 +02:00
Shauren
dd34651f4d Core/CrashHandler: Skip logging stack trace of the thread writing the crash log, it was launched by windows with same context as crashing thread 2020-08-07 17:58:46 +02:00
Shauren
c5e1b49e8c Core/CrashHandler: Remove logging function variation depending on crash reason and print directly to file, not to temporary buffer 2020-08-07 17:57:44 +02:00
Shauren
68fdfcaa50 Core/CrashHandler: NULL -> nullptr 2020-08-07 17:19:18 +02:00
Shauren
39c5e03b74 Core/CrashHandler: #ifdef cleanup to make VS not choke when parsing, fixed file being all red in editor 2020-08-07 17:19:18 +02:00
Shauren
83ed35fe62 Core/CrashHandler: Attempt to extract C++ exception object in uncaught exception hander 2020-08-07 17:19:16 +02:00
Ovah
764f22fc91 Core/Units: add new functionality for units to block or enable combat interactions (#25168)
* Core/Units: add new functionality for units to block or enable combat entirely via helper to reflect what CREATURE_DIFFICULTYFLAGS_IGNORE_COMBAT and client AI functions imply

* yeah...

* Nuke Creature::IsCombatDisallowed helper as its unused by now

* no combat extra flag may now be changed on transforms if the transformed entry does not have the flag
2020-08-07 14:51:40 +02:00
Carbenium
98b1b20d6b Core/Updater: Fix detection of the mysql binary when a directory is given as path
This ensures that we never pass a directory path StartProcess which results in a crash.

Closes #25216
2020-08-07 11:23:10 +02:00
Shauren
e240e5936a Core/PacketIO: Name previously unknown fields in lfg packets 2020-08-06 22:08:21 +02:00
jackpoz
3c28573d02 Core/Misc: Code cleanup 2020-08-06 22:04:46 +02:00
Ovahlord
86107584c0 Core/Packets: updated CMSG_LFG_JOIN and CMSG_LFG_LEAVE to new packet handling
(cherry picked from commit 6abeb36584)

# Conflicts:
#	src/server/game/Handlers/LFGHandler.cpp
#	src/server/game/Server/Packets/AllPackets.h
#	src/server/game/Server/WorldSession.h
#	src/server/game/Server/WorldSocket.cpp
2020-08-06 21:48:51 +02:00
Jinnaix
db9072a183 Core/Unit: Creatures' minions now engage in combat if their controller is attacked (PR #25219)
Closes #24340
2020-08-06 20:03:09 +02:00
Treeston
629908172f Core/Object: Deduplicate some checks 2020-08-06 19:46:33 +02:00
jackpoz
02a018ea13 Core/Battlegrounds: Fix error messages in Isle of Conquest
Fixes #24032
2020-08-06 18:27:32 +02:00
jackpoz
2910d0fb24 Core/SAI: Fix creatures casting spells while moving with flag SMARTCAST_COMBAT_MOVE
Fixes #24019
2020-08-06 17:59:36 +02:00
Giacomo Pozzoni
bd5e832a64 Scripts/Comamnds: Improve ".debug objectcount" command (#25208)
* Scripts/Comamnds: Improve ".debug objectcount" command

Include the top 5 most common creatures in the map

* Use C++ features to copy data

* Fix build warnings

* Update src/server/scripts/Commands/cs_debug.cpp

Co-authored-by: Shauren <shauren.trinity@gmail.com>

* Update src/server/scripts/Commands/cs_debug.cpp

Co-authored-by: Shauren <shauren.trinity@gmail.com>

* Update src/server/scripts/Commands/cs_debug.cpp

Co-authored-by: Shauren <shauren.trinity@gmail.com>

* Move CreatureCountWorker out of function and use template for unhandled cases

* Code cleanup

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2020-08-06 14:58:39 +02:00
Treeston
44a3aad0af Core/Authserver: Deprecation of sha_pass_hash (PR #25138)
see also #25157
2020-08-06 00:20:23 +02:00
jackpoz
6ad6d9e670 Scripts/Kologarn: Apply CREATURE_FLAG_EXTRA_NO_COMBAT on NPC_ARM_SWEEP_STALKER and NPC_RUBBLE_STALKER 2020-08-05 18:46:02 +02:00
Gildor
174ac95800 Scripts/Naxxramas: Frogger event improvements (#25202)
* Scripts/Naxxramas: Frogger event improvements
* Prevent Living Poison accumulation
* Now Living Poison cast Explode

* check for a nearby player

* move event to the frogger trigger's AI

* Initialize and removing unnecessary things

* applying suggestions

* remove unnecessary header

* Rename 9999_99_99_99_world.sql to 2020_08_05_00_world.sql
2020-08-05 14:16:19 +02:00
Ovahlord
9bf57958e3 Scripts/World: updated Training Dummy script to modern model and removed pointless GameTime shenanigans 2020-08-05 01:19:56 +02:00
Carbenium
0dd4b685df Scripts/AzjolNerub: Fix potential error in pound spell script
Cast damage spell in AfterEffectApply instead OnEffectHitTarget. This avoids the scenario where we try to apply an aura to a potential dead target.

Ref #21856
2020-08-04 17:22:18 +02:00
Treeston
7b8b999516 Core/Common: Move old-style pointer+size HexStr methods to Trinity::Impl where they can't hurt anyone 2020-08-04 17:03:26 +02:00
Shauren
b3db50a3b4 Core/Misc: Fix compile errors found with msvc /permissive- 2020-08-04 15:42:08 +02:00
jackpoz
8ad6bd8a9b Core/Metric: Require WITH_DETAILED_METRICS CMake flag for MMaps metric 2020-08-04 14:10:33 +02:00
Giacomo Pozzoni
07fd84b679 Core/Misc: Fix static analysis issues (#25194) 2020-08-04 11:36:47 +02:00
Trond B. Krokli
7f2874a7ac Scripts/Outland: Convert 'Captain Tyralius' to SAI (#25188)
Closes #24676
2020-08-03 21:06:20 +03:00
Shauren
d056f24c52 Core/Crypto: Initialize class member variables after crypto refactor 2020-08-03 18:57:16 +02:00
Treeston
38de6d3307 Core/DB: Split accounts.session_key into session_key_auth (3.3.5) and session_key_bnet (master), so the branches will no longer break each other's realm switching. 2020-08-03 18:53:00 +02:00
Shauren
65e3b3cf0d Core/Authserver: Validate length of session key field after bfb041246f 2020-08-03 15:14:40 +02:00
Treeston
3164b58c7d Core/Authserver: Re-organize the accounts table (PR #25135)
- no longer use sha_pass_hash for anything else core-side (.account, SOAP, RA)
- salt/verifier/session_key are now binary
- old s/v/sha_pass_hash fields kept around for backwards compatibility
- sha_pass_hash is still updated (for now), s/v are not
- sha_pass_hash is only read if s/v have been manually changed
- SRP6 b now uses the full 32 bytes of randomness (instead of randomly only using 19)
2020-08-02 22:52:21 +02:00
Peter Keresztes Schmidt
dab8768c18 Scripts/AzjolNerub: Update Anub'Arak encounter to current coding standards (#25192)
* Scripts/AzjolNerub: Update Anub'Arak to current coding standards

* no functional changes

* Scripts/AzjolNerub: Update Anub'Arak Darter to current coding standards

* no functional changes

* Scripts/AzjolNerub: Update Anub'Arak Assassin to current coding standards

* no functional changes

* Scripts/AzjolNerub: Update Anub'Arak Guardian to current coding standards

* no functional changes

* Scripts/AzjolNerub: Update Anub'Arak Venomancer to current coding standards

* no functional changes

* Scripts/AzjolNerub: Update Anub'Arak Impale Target to current coding standards

* Scripts/AzjolNerub: Update Anub'Arak Pound spell to current coding standards

* Scripts/AzjolNerub: Update Anub'Arak carrion beetles aura script to current coding standards
2020-08-01 23:32:10 +02:00
Peter Keresztes Schmidt
7abe9d66d0 Scripts/Gundrak: Update Slad'ran encounter to current coding standards (#25180)
* Scripts/Gundrak: Update Slad'Ran's script to use TaskScheduler

* No functional changes

* Scripts/Gundrak: Update Slad'Ran's adds to use TaskScheduler

* No functional changes
2020-08-01 23:15:25 +02:00
Peter Keresztes Schmidt
dd8666f38d Scripts/Gundrak: Update Drakkari Colossus encounter to current coding standards (#25182)
* Scripts/Gundrak: Update Drakkari Colossus to current coding standards

* no functional changes

* Scripts/Gundrak: Update Drakkari Elemental to current coding standards

* no functional changes

* Scripts/Gundrak: Update Living Mojo to current coding standards

* no functional changes
2020-08-01 23:14:26 +02:00
Peter Keresztes Schmidt
c88234727b Scripts/MoltenCore: Update Golemagg encounter to current coding standards (#25183)
* Scripts/MoltenCore: Update Golemagg to current coding standards

* no functional changes

* Scripts/MoltenCore: Update Core Ranger to current coding standards

* no functional changes
2020-08-01 23:12:54 +02:00
Carbenium
90543fd41d Scripts/AhnKahet: Update Herald Volazj to current coding standards
* convert to BossAI
* no functional changes
2020-08-01 23:11:08 +02:00
Carbenium
799d5376d8 Scripts/AV: Update Vanndar's script to use TaskScheduler
* No functional changes
2020-08-01 21:13:30 +02:00
Carbenium
228696bf80 Core/Common: Merge TimeTrackerSmall with TimeTracker 2020-08-01 12:43:55 +02:00
Carbenium
e55516348d Core/Common: Add a std::chrono interface to TimeTrackerSmall
New methods:
TimeTrackerSmall(Milliseconds expiry);
void Update(Milliseconds diff);
void Reset(Milliseconds expiry)
Milliseconds GetExpiry() const

Removed methods:
int32 GetExpiry() const

Also add basic unit tests.

Core/Scripts: Use std::chrono interface of TimeTrackerSmall
2020-08-01 12:43:55 +02:00
Shauren
9b806c6b5d Core/DBLayer: Add nicer api for SQLQueryHolders 2020-07-31 23:27:26 +02:00
Giacomo Pozzoni
7cf122fc2a Core/Misc: Fix static analysis issues (#25178) 2020-07-31 22:53:13 +02:00
Shauren
06f59caf3d Core/DataStores: Rename TalentTabEntry::CategoryEnumID back to PetTalentMask 2020-07-31 20:02:08 +02:00
Treeston
5ad064976e Core/Common: Allow config settings to be loaded as optional (PR #25137)
If the config setting is not present, returns the default without issuing a warning.
2020-07-31 17:12:09 +02:00
Jinnaix
e3aa87641f Scripts/BlackrockSpire: Fix encage event of Pyroguard encounter (#25177) 2020-07-31 13:58:26 +02:00
Giacomo Pozzoni
deceb11b5f Log sync db queries in World::Update() loop (#25174)
* Core/Misc: Log sync queries on critical path

* Fix build

* Rename

* Fix warning

* Fix no-pch

* Change WarnAboutSyncQueries() to be header-only
2020-07-30 21:42:27 +02:00
Shauren
0fc7b50c04 Core/Commands: Initialize commands on startup instead of first use 2020-07-30 20:52:46 +02:00
Shauren
57eaab80d9 Core/Mail: Load mails at login instead of on demand when queried by packets (logging in always sends one of the packets that cause mail loading anyway) 2020-07-30 20:38:04 +02:00
Shauren
e94350fcc3 Core/Mail: Refactor mail loading to execute 2 database queries instead of 1+mails.size() 2020-07-30 19:50:24 +02:00
Shauren
2f0893d279 Core/Misc: Replace database query in WorldSession::HandleAddFriendOpcode with async version 2020-07-30 17:41:20 +02:00