ariel-
b6b59f6c23
Core/Scripts: remove OnDummyEffect hook/sOnDummyEffect ai hook
...
- Duplicated logic never used, sometimes only ScriptMgr version was called, sometimes only AI
- They only encourage bad scripting practices
- You can still use OnSpellHit or a SpellScript
2017-04-28 18:59:14 -03:00
ariel-
4c4dca6d69
Core/Misc: camelize GetFaction/SetFaction properly
2017-04-28 18:37:38 -03:00
ccrs
5a2f0ce29e
Core/Unit: revert 3ea46e57af
...
After discussion we realized, ariel and me, that Creature and Unit IsMovementPreventedByCasting() have not the same checks (order matters)
2017-04-27 19:40:23 +02:00
ariel-
3ea46e57af
Core/Unit: 229444b74a follow-up
...
- IsFocusing is made virtual again, so there's no need to keep a duplicated function
This reverts commit 5043639c56 .
2017-04-27 11:00:01 -03:00
ccrs
229444b74a
Core/Misc: cleanup SetInFront uses
...
Set in front modifies only the serverside orientation, use with care.
Also check for current focus to prevent things like incorrect damage on casting creatures (ie dragon breath direction change in your face because of some taunt missclick)
2017-04-27 15:34:01 +02:00
ccrs
c7a57e2a09
Core/Unit: 2170541a51 followup
...
use true as default value since pretty much all the script calls will expect that
2017-04-27 14:55:06 +02:00
Keader
4431a1149d
Core/Scripts: Re-hack Boss Loken. Followup 3a0cb90ea9
...
Loken still need ClearUnitState Hack to DoMeleeAttackifReady work
2017-04-27 09:41:07 -03:00
ccrs
df96e053a5
Core/Spell: move creature focus
...
bellow the possible interruptions
2017-04-27 14:16:40 +02:00
ccrs
5fc366d03b
Core/CreatureAI: b6b0353bff followup
2017-04-27 14:00:57 +02:00
ccrs
5043639c56
Core/Misc: 522f537048 followup
2017-04-27 13:53:18 +02:00
ccrs
aa86dfddca
Core/Petition: add missing increment on RemovePetitionsByOwnerAndType iteration
2017-04-27 13:29:51 +02:00
xinef1
e30e11d4c7
Core/Spells: Corrected aura SPELL_AURA_MOD_CASTING_SPEED_NOT_STACK handling for auras with very high values ( #19054 )
2017-04-27 03:34:43 -03:00
xinef1
a4aa95a5a3
Core/Misc: implemented petition manager ( #19010 )
...
- Implemented manager for petitions to perform all petition related tasks and synchronize data with database.
- This kills ugly synchronous querys on packet handlers
2017-04-27 02:02:33 -03:00
ariel-
a82a12b5ef
Core/Player: don't check quest requirements against RewardNextQuest
...
- This field is only used to propose a new quest to player after completion, shouldn't be used to condition current quest
Closes #19515
2017-04-27 00:23:32 -03:00
ariel-
6892404b27
Core/AI: some tweaks on boundary functionality:
...
- Moved SetBoundary to public scope to allow for greater flexibility (ie set from external script)
- Extended to allow checking inverted boundaries
2017-04-26 04:20:38 -03:00
ariel-
3a2ecaa05f
Core/AI: added a function to allow 0 damage attacks (sparring) depending on target
2017-04-26 04:16:32 -03:00
jackpoz
486b032343
Core/Misc: Fix static analysis issues
2017-04-25 17:33:53 +02:00
Keader
3194d089cb
Core/Scripts: Added a missing break in Illidan Stormrage script
...
Thanks Jackpoz
2017-04-25 11:46:38 -03:00
jackpoz
65aeeafad3
Core/Misc: Fix static analysis issues
2017-04-25 14:27:53 +02:00
ariel-
85076dd799
Core/Scripts: fix gaseous bloat proc (again)
...
- UNIT_STATE_CASTING removal not needed for movement now, but it's needed for melee attacking
2017-04-25 02:57:58 -03:00
ariel-
157e9311c4
Core/Quests: implemented MSG_QUEST_PUSH_RESULT notifications
...
- Allow to share already completed (but not rewarded) quests, restriction was unblizzlike
thanks Cannix for the heads up
2017-04-24 16:34:50 -03:00
Keader
136f1e75aa
Core/Scripts: Fix a typo in Blood Prince Council
...
Thanks ariel-
2017-04-24 08:48:34 -03:00
xinef1
cbbb745246
Various quest system fixes (seasonal quests, timed quests and more) ( #18940 )
...
- Unify quest status checking function, use dedicated function instead of direct map checks
- Fixed seasonal quest chains and ability to complete the same quests rewarded in past
- Update area dependent auras on quest status change (they often requires specific quest status)
- Send all not stored quest rewards by mail
- When casting quest reward spell, check if it is not self casted, if so - use player to cast this spell
- Perform full db save on quest reward to prevent data desynchronization
- Don't allow to fail completed timed quests, except for quests which are completed right from the start
- Don't allow to share pooled quests, if they are not available in the current pool (eg sharing easy dalaran weeklies, stored at alt character)
- Remove seasonal quest if rewarded quest is removed
- Don't complete whole quest on AreaExplore event, check if there are no more requirements that should be fulfilled
- Quests with flag QUEST_SPECIAL_FLAGS_PLAYER_KILL can be only credited in quest zone
Closes #18913
Closes #11187
Closes #15279
2017-04-24 00:46:06 -03:00
ariel-
522f537048
Core/Movement: allow focused spells to not break movement if it's movement allowed spell
...
- Core/Unit: made IsFocusing virtual
Thanks to ccrs for suggestion
2017-04-23 21:48:07 -03:00
ariel-
1f4439ece4
Core/Spell: don't make creature change orientation to 0 if channeling self
2017-04-23 21:48:06 -03:00
ariel-
3a0cb90ea9
Core/Spell: define channels without movement interrupt flags as allowed move
...
- Remove script hacks no longer needed
2017-04-23 21:48:06 -03:00
ariel-
b6b0353bff
Core/AI: prevent launching a new MoveChase if victim didn't change
...
Thanks ccrs for feedback :P
2017-04-23 21:48:05 -03:00
ariel-
7c87ef5088
Core/Globals: check localeName on loading
2017-04-23 21:36:57 -03:00
ariel-
41d8cc85f9
Core/Misc: fix typo
2017-04-23 21:36:42 -03:00
Chazy Chaz
460e2c5dc5
Core/Misc: Update locales_item and locales_item_set_names to simple system
2017-04-24 01:54:21 +02:00
Chazy Chaz
3739d8444b
Core/Misc: Update locales_quest to simple system
2017-04-24 01:52:58 +02:00
Chazy Chaz
9a3b28894d
Core/Misc: Update locales_broadcast_text to simple system
2017-04-24 01:50:19 +02:00
Xyventh
f0bf1fc77a
[3.3.5] Core/Quest: always send the specified RewardNextQuest regardless of eventual scripts ( #19498 )
...
- Fixes certain situations in which the quest window would get stuck after completing a quest
2017-04-23 18:55:07 -03:00
tkrokli
6cc267d909
Core/Scripts: Willix the Importer - $n in aggro text
...
* In the existing core script, Willix the Importer in Razorfen Kraul says
"Help! Get this $n off of me!" (showing the $n part in his SAY text)
instead of naming the attacker when using his 'SAY_AGGRO1' creature_text.
* With this commit change, unit target is no longer missing for Talk,
making Willix name the attacking unit when he shouts for help.
2017-04-23 01:15:00 +02:00
ariel-
25a449a90e
Core/Spell: implement pvp trinket immunity against Judgement of Justice
...
By Riztazz, closes #19484
2017-04-22 06:45:03 -03:00
ariel-
7ffe056366
Core/Player: don't randomly change temporary spell status
...
- They shouldn't be saved in db
- Prevented temporary spell removal after a save
Closes #14373
2017-04-22 06:33:05 -03:00
ariel-
88c12b45d0
Core/Spell: fix creature focus with channeled spells
...
- Remove one not needed ReleaseFocus, this is done at finish already
2017-04-22 04:00:49 -03:00
ariel-
c296d255e2
Revert "Core/Spell: don't set scaleAura for some special spells"
...
This reverts commit 1ca8434b36 .
Closes #19472
2017-04-21 01:37:07 -03:00
Shauren
34b63019ae
Core/Spells: Refactor setting spell info corrections to report errors about spells that no longer exist
...
cherry-picked from commit be1a7d36f3
2017-04-21 00:55:33 -03:00
ariel-
66ac1509ae
Core/Unit: fix SPELL_AURA_MOD_DAMAGE_DONE damage calculation on non-melee schools
...
for Keader :P
2017-04-20 02:12:15 -03:00
Chazy Chaz
fbbe247114
Core/Misc: Sync database schema with master
2017-04-18 13:06:09 +02:00
Krudor
374ef5b557
Update boss state load logic
...
Reset boss state to NOT_STARTED if state loads as FAIL
2017-04-17 12:51:01 +02:00
ariel-
8b52cf902b
Core/Spell: register spell mod owner properly on spell cast
...
- This fixes pets and totems getting mods from owner
2017-04-15 15:58:56 -03:00
ariel-
1fa641d7b6
Core/Scripts: fix dereferencing invalid iterator
...
Closes #19464
2017-04-15 15:00:15 -03:00
Gacko
e90757f763
Fix non-PCH build.
...
Even on 3.3.5. What's PCH for?
2017-04-15 12:43:19 +02:00
ariel-
2a04599ed8
Core/Unit: implement miss chance reduction for low level mobs
...
Source: http://wow.gamepedia.com/index.php?title=Miss&oldid=1980141
> Level is not a factor except when attacking a mob level 9 or lower.
Miss chance against a low-level mob is a percentage of normal equal to the mob’s level divided by 10.
2017-04-14 23:38:54 -03:00
ariel-
9414f50f5c
Core/Auras: don't skip stack rule check whenever spells have same ID
...
- The auras might not have the same amounts due to spellmods
Closes #1626
2017-04-14 19:07:11 -03:00
Shauren
4a40b8ed43
Core/Spells: Name a spell attribute
...
(cherry picked from commit e88a5e4d6d )
2017-04-14 16:53:59 -03:00
ariel-
d44a44abac
Core/Spell: fix broken Unit::GetHighestExclusiveSameEffectSpellGroupValue
...
- Affects 3 aura effects currently, should be rewritten with GetTotalAuraModifier maybe?
2017-04-14 16:52:28 -03:00
ariel-
841bbd47d7
Core/Entities: fix integer undeflow when calculating skill value difference
...
Closes #19455
2017-04-14 16:46:24 -03:00