Commit Graph

14570 Commits

Author SHA1 Message Date
NoName
22aaf32a79 Scripts/IcecrownCitadel: Adding IsAlive check to avoid possible crash in Event (#24514) 2020-04-29 21:14:27 +02:00
Shauren
411033ddf8 Core/PacketIO: Send item flags in auction items for the lulz, its bugged in the client anyway 2020-04-28 22:53:40 +02:00
Shauren
79edf74768 Core/AuctionHouse: Fixed auction mail subjects for items with random properties 2020-04-28 20:01:48 +02:00
Shauren
e795eed96b Warning fix 2020-04-28 19:44:41 +02:00
Shauren
3ebcf3f1a9 Core/AuctionHouse: Fixed auction mail bodies 2020-04-28 19:24:24 +02:00
Shauren
50576fa1f5 Core/Auras: Prevent getting negative scale with auras
Closes #24040
2020-04-28 18:03:51 +02:00
Shauren
43d9ffd1bc Core/Spells Fixed scroll stacking check when not targeting self
* Reuse code that removes non-stackable auras at apply to check before casting the spell to keep reagents/cast item
2020-04-28 11:02:27 +02:00
FAQ
8d87c834e7 Core/Spells: Scrolls should not be consumed, when they fail to apply. 2020-04-28 11:02:27 +02:00
Gildor
2e42156f8d Remove tabs (ee5eace3c6) (#24510) 2020-04-28 10:58:31 +02:00
Killyana
ee5eace3c6 DB/Pet: Lil' K.T
Ref #1364
2020-04-28 02:04:53 +02:00
Ovahlord
1610337e67 Core/Vehicles: update the power display of vehicles before being added to world to avoid building unnecessary update_object packets right after spawning them 2020-04-27 19:29:01 +02:00
HelloKitty
f1ad04b31b Core/DataStores: Use ResSicknessSpellID from ChrRaces instead of hardcoding it (#24504) 2020-04-27 17:55:25 +02:00
Shauren
b4584ee323 Core/PacketIO: Fixed crash in TogglePvP::Read 2020-04-27 10:51:13 +02:00
Keader
94aff38187 Scripts/Spells: Fixed Mages 2P T10 proc delay (#24496) 2020-04-26 22:33:40 -03:00
Killyana
3f5e0927c3 DB/Pet: Toxic Wasteling
Closes #12773
2020-04-27 00:57:21 +02:00
ForesterDev
332b2f1f53 Core/PacketIO: updated CMSG_TOGGLE_PVP opcode (#24476)
* Core/PacketIO: updated CMSG_TOGGLE_PVP opcode

* Use Optional<T>.
Restore ApplyModFlag() code.

* Fix no-pch build

Co-authored-by: jackpoz <giacomopoz@gmail.com>
2020-04-26 22:10:07 +02:00
NoName
45993428f5 Core/Spells: Crystallize should not use DIMINISHING (#24502)
and also correcting spelling in script

by Rushor and wotlk-enthusiast
2020-04-26 21:40:57 +02:00
Rushor
2d948d3366 Game/AI: Implement new targettype SMART_TARGET_CLOSEST_UNSPAWNED_GAMEOBJECT (#24494)
* Game/AI: Implement new targettype SMART_TARGET_CLOSEST_UNSPAWNED_GAMEOBJECT which allows to search for closest unspawned gameobjects

* updates: https://github.com/TrinityCore/TrinityCore/issues/24067

* Game/AI: Implement new targettype SMART_TARGET_CLOSEST_UNSPAWNED_GAMEOBJECT which allows to search for closest unspawned gameobjects
2020-04-26 21:32:24 +02:00
Rushor
a41bb4f77b Game/AI: Enable check for SMART_TARGET_GAMEOBJECT_RANGE (#24493)
* Thanks to joshwhedon
* Updates: https://github.com/TrinityCore/TrinityCore/issues/24439
2020-04-26 21:30:03 +02:00
Eridium
7e9bc9599b Core/GameObject: Remove linked traps when the main GameObject is remo… (#24480)
* Core/GameObject: Remove linked traps when the main GameObject is removed from from the world

* Indentation
2020-04-26 21:25:54 +02:00
Gildor
e4476fab6e Scripts/OnyxiasLair: Fix Onyxia Eruption spell (#24472) 2020-04-26 21:24:00 +02:00
Ovah
f1e4ee21f8 Core/AI: Implemented OnSpellCastInterrupt and OnSuccessfulSpellCast hooks
Ported from: 020825902c and 1aa42e97a8
2020-04-25 16:07:18 -03:00
Keader
ee218a5642 Making travis happy 2020-04-24 13:58:26 -03:00
Keader
d8e726de58 Scripts/Black Temple: Fixed Reliquary of Souls after combat rewrite changes.
Closes #23879
* Fixed combat start/evade issue
* Fixed visual issue in Soul Release spell
* Fixed some timers issue
* Fixed some codestyle issues

PS: Please, stop break my black temple babys.
2020-04-24 13:52:28 -03:00
ForesterDev
48c700347c Core/Database: fix wrong password logging (#24487) 2020-04-23 10:54:45 +02:00
jackpoz
7b8b02c32e Scripts/BWL: Fix crash in Razorgore encounter 2020-04-22 22:09:10 +02:00
Rushor
4f52f7d7c9 Game/SmartScripts: Reset counter in SAI only on Initialize. (#24489)
* Game/SmartScripts: Reset counter in SAI only on Initialize.

* Game/SmartScripts: Reset counter in SAI only on Initialize.
2020-04-22 19:49:41 +02:00
jackpoz
740afc7135 Core/Spells: Fix assertion triggered 2020-04-21 22:22:31 +02:00
Shauren
9407f9bdfa Core/Misc: Improve assert message with more detail 2020-04-21 10:50:42 +02:00
ForesterDev
c79b5f58e5 Core/PacketIO: updated SMSG_CROSSED_INEBRIATION_THRESHOLD (#24475)
(cherry picked from commit 9f4e4b9546)

# Conflicts:
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Server/Packets/MiscPackets.cpp
#	src/server/game/Server/Packets/MiscPackets.h
#	src/server/game/Server/Protocol/Opcodes.cpp

Co-authored-by: MitchesD <majklprofik@seznam.cz>
2020-04-20 09:26:19 +02:00
Killyana
9e58573272 Spell: Move "Dark Conclave Ritualist Channel" outside Ulduar spells 2020-04-19 19:19:23 +02:00
Killyana
64878e19fb Spell: Fix "Dark Conclave Ritualist Channel" range and cast 2020-04-19 19:00:19 +02:00
skipperheartbeat
8ac8374429 Boss/Script: Vazruden_Fix (#24197)
* Add files via upload

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: offl <suffle.o@gmail.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

Co-authored-by: Aokromes <Aokromes@users.noreply.github.com>
Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: offl <suffle.o@gmail.com>
2020-04-19 11:01:31 +02:00
Gildor
247151b470 Core/Spells: Improve check for non damage/heal spells in Spell::TargetInfo::DoDamageAndTriggers (#24467)
* this prevent cases like full absorb damage that override proper hitMask
2020-04-18 18:04:45 +02:00
Keader
c41ae89069 Core/Spells: Fixed Ice Block / Divine Shield cast in Cyclone (#24465) 2020-04-18 17:53:06 +02:00
Gildor
5e15406278 Core/Unit: Improve HitInfo absorb and resist flags logic in Unit::CalculateMeleeDamage (#24460) 2020-04-18 15:21:15 +02:00
ForesterDev
c0f516caee Core/Packets: updated MSG_RANDOM_ROLL (#24457)
(cherry picked from commit 5dddfbdb7b)

# Conflicts:
#	src/server/game/Handlers/ChatHandler.cpp
#	src/server/game/Handlers/GroupHandler.cpp
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/Protocol/Opcodes.h
#	src/server/game/Server/WorldSession.h

Co-authored-by: DJScias <djscias@gmail.com>
2020-04-18 14:28:07 +02:00
zartech22
56f20d69a6 Add realm ID for actions based ip logging (#24453)
* Update SQL queries to insert realm id

* Insert the realm id when logging actions based on IP

* Adding the SQL update file

* Update 9999_99_99_99_auth.sql

* Update auth structure

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-04-18 14:26:05 +02:00
Gildor
6c7c2c6cd2 Scripts/Naxxramas: Fix Heigan Eruption spell (#24470) 2020-04-17 22:54:36 +02:00
Ovah
cfd63c350f Core/Movement: various improvements for creature knockbacks
* creature knockbacks will no longer generate a full path but instead only use a destination point to reflect sniff data
* calculate the destination by using a mmap raycast instead of using a mmap path which had the chance of creating weird movements when GetNearPosition failed to get a proper collision point (knocking arround a tree for example or just somewhere it should not go at all)
2020-04-17 21:13:18 +02:00
Alan Deutscher
e11a13c755 Core/Players: Improve trade exchange calculations (#24435)
* Add some comments to Player::CanStoreItems to help me wrap my head around how the method works.

* Experimental fix for incoming trade-stack problem.

* Only add to stacks that aren't already full.

* Use remaining_count instead of static 1.

* Remove debug logging from exploration.

* More uses of remaining_count for consistency.

* Correct space count check

* Correct overflow problem.

* Remove redundant check, handled in existing for statement.

* Store Item pointers in order to be able to merge in multiple incoming stacks.

* Build fix - was continually working locally, but failing in CI.

* Break build in order to keep PR focused on Player.cpp changes.

* Adjust phrasing of how arrays are initialized.

* Fix phrasing of comments to avoid sounding like a ToDo item

* In the spirit of b649273d5f, rephrase an old comment to be a statement rather than a question.
2020-04-16 20:21:01 +02:00
Keader
77dd751499 Scripts/Ulduar: Little improvements in Auriaya
* Removed DespawnAtEvade
* Fix Feral Defender Damage
2020-04-15 11:28:46 -03:00
Keader
78dff46bf2 Scripts/Trial of Crusader: Fixed issue with Snobold Vassal and some achiev criteria resets
* Fixed snobold behavior when gormok dies
* Fixed UPPER_BACK_PAIN Archiev reset
* Fixed THREE_SIXTY_PAIN_SPIKE Archiev reset
2020-04-15 09:53:46 -03:00
Gildor
8a5b02be0a Scripts/Quest: The Exorcism of Colonel Jules (#24459)
* Remove Anchorite Barada gossip when event start
2020-04-15 13:12:28 +02:00
ForesterDev
b712222a08 Core/Packets: (#24441)
* SMSG_START_MIRROR_TIMER
* SMSG_STOP_MIRROR_TIMER
* SMSG_PAUSE_MIRROR_TIMER -- not used

(cherry picked from commit 79bbca0bbf)

# Conflicts:
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Server/Protocol/Opcodes.cpp

Co-authored-by: Golrag <golrag.jeremy@gmail.com>
2020-04-14 14:15:20 +02:00
ForesterDev
c973c0260f Core/Packets: updated SMSG_LEVELUP_INFO (#24440)
* Core/Packets: updated & enabled SMSG_LEVELUP_INFO

(cherry picked from commit bf9024c34180b1e35afb3cc9ef4cf1f3133dedfd#gitext://gotocommit/bf9024c34180b1e35afb3cc9ef4cf1f3133dedfd)

# Conflicts:
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Entities/Player/Player.h
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/Protocol/Opcodes.h

* Remove empty line

* Remove whitespace

Co-authored-by: MitchesD <majklprofik@seznam.cz>
2020-04-14 14:06:16 +02:00
ForesterDev
e1a8ebc064 Core/PacketIO: updated SMSG_DURABILITY_DAMAGE_DEATH (#24442)
- use RATE_DURABILITY_LOSS_ON_DEATH for death from falling
- add note, that RATE_DURABILITY_LOSS_ON_DEATH doesn't change log message

(cherry picked from commit a1831e0c1e)

# Conflicts:
#	src/server/game/Entities/GameObject/GameObject.cpp
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Server/Packets/GameObjectPackets.h
#	src/server/game/Server/Protocol/Opcodes.cpp

Co-authored-by: MitchesD <majklprofik@seznam.cz>
2020-04-14 14:00:53 +02:00
ForesterDev
37ff15489b Core/PacketIO: updated SMSG_ENVIRONMENTAL_DAMAGE_LOG (#24443)
(cherry picked from commit 7b446a28cc)

# Conflicts:
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Server/Packets/CombatLogPackets.cpp
#	src/server/game/Server/Packets/CombatLogPackets.h
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/Protocol/Opcodes.h

Co-authored-by: MitchesD <majklprofik@seznam.cz>
2020-04-14 13:58:11 +02:00
Gildor
862097a633 Core/Gameobjects: Improve stealth detection (#24417)
* Core/Gameobjects: Improve stealth detection

* fix warning: private field 'i_funit' is not used

* Code cleanup

* add comment

Co-authored-by: jackpoz <giacomopoz@gmail.com>
2020-04-12 15:28:01 +02:00
Sven
c3037c3563 Improvements to Pyroguard Emberseer (UBRS) script (#24405)
* UBRS: Improve Pyroguard Emberseer script

* Remove whitespaces

* More whitespaces removed

* Addressing change requests
Removed cast from constructor
Removing unused member field

* That should be the last white spaces

* Forgot to remove the declaration

* Update boss_pyroguard_emberseer.cpp

* Add break to For loop

* War on white spaces

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-04-12 10:00:15 +02:00