Commit Graph

39720 Commits

Author SHA1 Message Date
Killyana
57b1d76ad5 DB/Creature: Add some missing spawns to Naxxanar area
(cherry picked from commit 5a3a9381e4)
2020-04-28 22:46:56 +02:00
ccrs
a46286a803 Core/Unit: revert 3ea46e57af
After discussion we realized, ariel and me, that Creature and Unit IsMovementPreventedByCasting() have not the same checks (order matters)

(cherry picked from commit 5a2f0ce29e)
2020-04-28 22:42:17 +02:00
Killyana
acdbc681cc DB: Some Pathing on Coldarra area
(cherry picked from commit 01d9df27d5)
2020-04-28 21:49:49 +02:00
ariel-
6a96addadd Core/Unit: 229444b74a follow-up
- IsFocusing is made virtual again, so there's no need to keep a duplicated function

This reverts commit 5043639c56.

(cherry picked from commit 3ea46e57af)
2020-04-28 17:51:57 +02:00
ccrs
104e745edf Core/Misc: cleanup SetInFront uses
Set in front modifies only the serverside orientation, use with care.
Also check for current focus to prevent things like incorrect damage on casting creatures (ie dragon breath direction change in your face because of some taunt missclick)

(cherry picked from commit 229444b74a)
2020-04-28 17:51:25 +02:00
ccrs
2d4549023a Core/Unit: 2170541a51 followup
use true as default value since pretty much all the script calls will expect that

(cherry picked from commit c7a57e2a09)
2020-04-28 17:42:26 +02:00
Keader
d1bdb8bdd3 Core/Scripts: Re-hack Boss Loken. Followup 3a0cb90ea9
Loken still need ClearUnitState Hack to DoMeleeAttackifReady work

(cherry picked from commit 4431a1149d)
2020-04-28 14:59:41 +02:00
ccrs
8c12f36915 Core/Spell: move creature focus
bellow the possible interruptions

(cherry picked from commit df96e053a5)
2020-04-28 14:59:05 +02:00
ccrs
5d411e0b21 Core/CreatureAI: b6b0353bff followup
(cherry picked from commit 5fc366d03b)
2020-04-28 14:55:44 +02:00
ccrs
9a57e95f10 Core/Misc: 522f537048 followup
(cherry picked from commit 5043639c56)
2020-04-28 14:54:44 +02:00
xinef1
9842ca3f4a Core/Spells: Corrected aura SPELL_AURA_MOD_CASTING_SPEED_NOT_STACK handling for auras with very high values (#19054)
(cherry picked from commit e30e11d4c7)
2020-04-28 14:49:14 +02:00
ariel-
3c2882c29d Core/Player: don't check quest requirements against RewardNextQuest
- This field is only used to propose a new quest to player after completion, shouldn't be used to condition current quest

Closes #19515

(cherry picked from commit a82a12b5ef)
2020-04-28 14:14:42 +02:00
ariel-
f3a49059ac Core/AI: some tweaks on boundary functionality:
- Moved SetBoundary to public scope to allow for greater flexibility (ie set from external script)
- Extended to allow checking inverted boundaries

(cherry picked from commit 6892404b27)
2020-04-28 14:07:43 +02:00
ariel-
bb3f2a11cf Core/AI: added a function to allow 0 damage attacks (sparring) depending on target
(cherry picked from commit 3a2ecaa05f)
2020-04-28 14:05:16 +02:00
jackpoz
49f25f6e33 Core/Misc: Fix static analysis issues
(cherry picked from commit 486b032343)
2020-04-28 13:47:58 +02:00
Keader
cc148ebc40 Core/Scripts: Added a missing break in Illidan Stormrage script
Thanks Jackpoz

(cherry picked from commit 3194d089cb)
2020-04-28 13:44:02 +02:00
jackpoz
6611211d31 Core/Misc: Fix static analysis issues
(cherry picked from commit 65aeeafad3)
2020-04-28 13:43:40 +02:00
ariel-
dea7159745 Core/Scripts: fix gaseous bloat proc (again)
- UNIT_STATE_CASTING removal not needed for movement now, but it's needed for melee attacking

(cherry picked from commit 85076dd799)
2020-04-28 13:40:56 +02:00
ariel-
3eee76b1c6 Core/Quests: implemented MSG_QUEST_PUSH_RESULT notifications
- Allow to share already completed (but not rewarded) quests, restriction was unblizzlike

thanks Cannix for the heads up

(cherry picked from commit 157e9311c4)
2020-04-28 13:32:46 +02:00
Keader
292c03ec04 Core/Scripts: Fix a typo in Blood Prince Council
Thanks ariel-

(cherry picked from commit 136f1e75aa)
2020-04-28 13:13:49 +02:00
Killyana
664d002f65 DB/Creature: Caer darrow area
Closes #19256
By Rushor, cala

(cherry picked from commit 4c09b8a02f)
2020-04-28 12:56:09 +02:00
Killyana
2c60638883 DB/Gossip: Maddix and Alieshor
Updates #19432

(cherry picked from commit 2885dc92d0)
2020-04-28 12:56:09 +02:00
Xyventh
ec508fbdba DB/Gossip: Apprentice Shatharia and Magister Quallestis
Closes #19509

(cherry picked from commit c423b37143)
2020-04-28 12:56:09 +02:00
Xyventh
ca8a2cd2ce DB/Creature: Hargin Mundar
Closes #19508

(cherry picked from commit beceb0a83f)
2020-04-28 12:56:08 +02:00
Xyventh
d762d39d7c DB/Creature: R-3D0
Closes #19506

(cherry picked from commit caed8b43c8)
2020-04-28 12:56:08 +02:00
Xyventh
9620869bb7 DB: RP event for Dame Auriferous, High Executor Mavren, Advisor Valwyn and Deathstalker Maltendis
Closes #19503

(cherry picked from commit 7559d837b9)
2020-04-28 12:56:08 +02:00
Xyventh
2bf9b0655e DB/Gossip: Add Missing gossip texts for some NPCs in Sunstrider Isle
Closes #19501

(cherry picked from commit 95ef739012)
2020-04-28 12:56:07 +02:00
xinef1
16cf95654f Various quest system fixes (seasonal quests, timed quests and more) (#18940)
- Unify quest status checking function, use dedicated function instead of direct map checks
- Fixed seasonal quest chains and ability to complete the same quests rewarded in past
- Update area dependent auras on quest status change (they often requires specific quest status)
- Send all not stored quest rewards by mail
- When casting quest reward spell, check if it is not self casted, if so - use player to cast this spell
- Perform full db save on quest reward to prevent data desynchronization
- Don't allow to fail completed timed quests, except for quests which are completed right from the start
- Don't allow to share pooled quests, if they are not available in the current pool (eg sharing easy dalaran weeklies, stored at alt character)
- Remove seasonal quest if rewarded quest is removed
- Don't complete whole quest on AreaExplore event, check if there are no more requirements that should be fulfilled
- Quests with flag QUEST_SPECIAL_FLAGS_PLAYER_KILL can be only credited in quest zone

Closes #18913
Closes #11187
Closes #15279

(cherry picked from commit cbbb745246)
2020-04-28 12:56:03 +02:00
ariel-
9ef39fa5d2 Core/Movement: allow focused spells to not break movement if it's movement allowed spell
- Core/Unit: made IsFocusing virtual

Thanks to ccrs for suggestion

(cherry picked from commit 522f537048)
2020-04-28 12:35:23 +02:00
ariel-
52ab270768 Core/Spell: don't make creature change orientation to 0 if channeling self
(cherry picked from commit 1f4439ece4)
2020-04-28 12:35:22 +02:00
ariel-
5e32e96278 Core/Spell: define channels without movement interrupt flags as allowed move
- Remove script hacks no longer needed

(cherry picked from commit 3a0cb90ea9)
2020-04-28 12:35:16 +02:00
Traesh
98b1c02a1c Core/Packets Fix SMSG_START_TIMER struct & update to new packet system (#22614) 2020-04-27 21:31:27 +02:00
ariel-
9c53ee0fe8 Core/AI: prevent launching a new MoveChase if victim didn't change
Thanks ccrs for feedback :P

(cherry picked from commit b6b0353bff)
2020-04-27 18:29:39 +02:00
Xyventh
2bd7c9aa40 [3.3.5] Core/Quest: always send the specified RewardNextQuest regardless of eventual scripts (#19498)
- Fixes certain situations in which the quest window would get stuck after completing a quest

(cherry picked from commit f0bf1fc77a)
2020-04-27 18:23:07 +02:00
tkrokli
cf3c5dc948 Core/Scripts: Willix the Importer - $n in aggro text
* In the existing core script, Willix the Importer in Razorfen Kraul says
"Help! Get this $n off of me!" (showing the $n part in his SAY text)
instead of naming the attacker when using his 'SAY_AGGRO1' creature_text.

* With this commit change, unit target is no longer missing for Talk,
making Willix name the attacking unit when he shouts for help.

(cherry picked from commit 6cc267d909)
2020-04-27 17:29:27 +02:00
ariel-
cfdde556cd Core/Player: don't randomly change temporary spell status
- They shouldn't be saved in db
- Prevented temporary spell removal after a save

Closes #14373

(cherry picked from commit 7ffe056366)
2020-04-27 15:50:27 +02:00
ariel-
e3eca0c264 Core/Spell: fix creature focus with channeled spells
- Remove one not needed ReleaseFocus, this is done at finish already

(cherry picked from commit 88c12b45d0)
2020-04-27 15:34:38 +02:00
ariel-
92719d1dc9 Revert "Core/Spell: don't set scaleAura for some special spells"
This reverts commit 1ca8434b36.

Closes #19472

(cherry picked from commit c296d255e2)
2020-04-27 15:20:00 +02:00
Killyana
64ae382d41 DB/Creature: Add missing Spirit Healers
All graveyards are checked

(cherry picked from commit 3028be4929)
2020-04-27 15:08:38 +02:00
ariel-
8889b6f54c Core/Unit: fix SPELL_AURA_MOD_DAMAGE_DONE damage calculation on non-melee schools
for Keader :P

(cherry picked from commit 66ac1509ae)
2020-04-27 14:58:52 +02:00
ariel-
71c2fda113 Core/Spell: register spell mod owner properly on spell cast
- This fixes pets and totems getting mods from owner

(cherry picked from commit 8b52cf902b)
2020-04-27 14:51:36 +02:00
ariel-
677df56d2d Core/Auras: don't skip stack rule check whenever spells have same ID
- The auras might not have the same amounts due to spellmods

Closes #1626

(cherry picked from commit 9414f50f5c)
2020-04-27 14:31:29 +02:00
ariel-
1edfd0d064 Core/Spell: fix broken Unit::GetHighestExclusiveSameEffectSpellGroupValue
- Affects 3 aura effects currently, should be rewritten with GetTotalAuraModifier maybe?

(cherry picked from commit d44a44abac)
2020-04-27 14:31:29 +02:00
ariel-
60824d8c7a Core/Spell: fix nopch build x2
(cherry picked from commit abaa9d635a)
2020-04-27 14:31:29 +02:00
ariel-
3675d2b494 Core/Spell: fix nopch build
(cherry picked from commit f0a93140e8)
2020-04-27 14:31:28 +02:00
ariel-
4523c5619b Core/Spell: build fix
(cherry picked from commit 9a05157003)
2020-04-27 14:31:28 +02:00
ariel-
52e00746cf Core/Spell: fixed SPELL_GROUP_STACK_RULE_EXCLUSIVE_SAME_EFFECT to actually check effects
- This commit enables stack rule 3 to be properly used to fix auras that should be active but only one providing effects, even if the spell has multiple auras

Closes #19454

(cherry picked from commit 9900899dd9)
2020-04-27 14:31:21 +02:00
tkrokli
50008f692a Rename last 2 SQL files with correct date
(cherry picked from commit 912351febd)
2020-04-27 12:25:52 +02:00
Killyana
95830889df DB: Fix some DB errors
(cherry picked from commit 10d7ae488e)
2020-04-27 12:25:52 +02:00
Killyana
abf425b281 DB/Creature: Add some Winterfin Tadpole missing spawns
(cherry picked from commit 5563b14d7a)
2020-04-27 12:25:52 +02:00