Commit Graph

39720 Commits

Author SHA1 Message Date
ariel-
b742c87222 Core: add some missing Player Name normalization on input data
(cherrypicked from 6f9e8b6c91)
2019-07-21 21:06:54 +02:00
xinef1
b485f3e673 Few small optimizations here and there (#18684)
Changes list:
- Added CharacterGuidByNameContainer which contains name -> guid unordered map (updated along CharacterInfo)
- Extended CharacterInfo structure with GuildId
- Extended CharacterInfo structure with ArenaTeamId[3], for all possible teams (2v2, 3v3, 5v5)
- Removed CHAR_SEL_GUID_BY_NAME and CHAR_SEL_CHAR_GUID_BY_NAME synchronous queries, name -> guid can be now retrieved in World::GetCharacterGuidByName
- Removed CHAR_SEL_GUID_RACE_ACC_BY_NAME synchronous query, guid can be retrieved by name and rest of the data can be retrieved by guid
- Removed CHAR_SEL_CHAR_LEVEL synchronous query, level can be retrieved by guid
- Changed CHAR_SEL_CHARACTER_ACTIONS_SPEC to asynchronous query, action bars are now loaded asynchronously
- Removed CHAR_SEL_CHARACTER_NAME_CLASS synchronous query, guid can be retrieved by name and rest of the data can be retrieved by guid
- Removed CHAR_SEL_PLAYER_ARENA_TEAMS and CHAR_SEL_ARENA_TEAM_ID_BY_PLAYER_GUID synchronous queries, arena teams are now stored in CharacterInfo
- Replaced synchronous db calls with CharacterInfo lookups
- Removed ObjectMgr::GetPlayerGUIDByName, as it used db query
- Replaced some unnecessary UpdateObjectVisibility() calls because they were either duplicated (called few lines above in other function) or it is enough to call DestroyForNearbyPlayers because object is being removed or should be invisible and DestroyForNearbyPlayers is faster
- Corrected typo in Player::DestroyForPlayer, only items in slots 0 to EQUIPMENT_SLOT_END are sent to other players
- Renamed Player::GetGuildIdFromDB to Player::GetGuildIdFromCharacterInfo and changed the function to use CharacterInfo structure
- Renamed Player::GetArenaTeamIdFromDB to Player::GetArenaTeamIdFromCharacterInfo and changed the function to use CharacterInfo structure
- Renamed Player::GetLevelFromDB to Player::GetLevelFromCharacterInfo and changed the function to use CharacterInfo structure
- Removed GameEventMgr::_questToEventLinks and associated functions, eventId is now stored in Quest class under _eventIdForQuest variable
- Changed some functions checking quest status to use other functions for quest status check instead of duplicating code
- Removed callback from add friend, because we can get the guid from appropriate storage, no need to make db query
- Removed callback from add ignore, because we can get the guid from appropriate storage, no need to make db query
- Added callback to unwrap wrapped items asynchronously
- Removed synchronous select in tutorials to check if we have any entries in db, if any entry exists in db, m_TutorialsChanged variable will have TUTORIALS_FLAG_LOADED_FROM_DB flag added and it is no longer necessary to query database

(cherrypicked from b955456008)
2019-07-21 21:06:54 +02:00
Rushor
e6885d50c6 DB/Creature: Stormforged Taskmaster
Closes #18976

(cherrypicked from 6de46d30c9)
2019-07-21 21:06:54 +02:00
Rushor
4aa4aed780 DB/Creature: Iron Sentinel <Servant of Loken>
Closes #18974

(cherrypicked from d5ab68250c)
2019-07-21 21:06:54 +02:00
Rushor
5ee6fd6131 DB/Creature: Wild Elekks
Closes #18970

(cherrypicked from 5d626c8e55)
2019-07-21 21:06:54 +02:00
Rushor
5b74a25947 DB/Creature: Romping Rhino
Closes #18967

(cherrypicked from bb46b09fe8)
2019-07-21 21:06:54 +02:00
Rushor
3f5e9ba575 DB/Creature: Stormforged Iron Giant
Closes #18965

(cherrypicked from 535b727b94)
2019-07-21 21:06:54 +02:00
Rushor
8b23a6a3a4 DB/Quest: The Last of Her Kind
Closes #18962

(cherrypicked from cca6bfee7b)
2019-07-21 21:06:54 +02:00
Rushor
5d5a296b54 DB/Creature: Son of Hodir
Closes #18961

(cherrypicked from 35675ceef1)
2019-07-21 21:06:54 +02:00
Rushor
7bbedad532 DB/Creature: Plains Mammoth
Closes #18960

(cherrypicked from cb466b7543)
2019-07-21 21:06:54 +02:00
Rushor
e170e809ed DB/Creature: Brittle Revenant
Closes #18959

(cherrypicked from 6485a4afd8)
2019-07-21 21:06:54 +02:00
Rushor
3886c2b43b DB/Creature: Stormpeak Wyrm and Stormpeak Hatchling
Closes #18958

(cherrypicked from 57beed2f70)
2019-07-21 21:06:54 +02:00
Rushor
4ff4469f2b DB/Creature: Ice Steppe Bull, Ice Steppe Rhino
Closes #18953

(cherrypicked from fd1e484baa)
2019-07-21 21:06:54 +02:00
Rushor
4fc8797199 DB/Creature: Stormforged Tracker
Closes #18949

(cherrypicked from 3c4c3a26bd)
2019-07-21 21:06:54 +02:00
Rushor
7ce7938cc0 DB/Creature: Hyldnir Overseer and Overseer Syra
Closes #18947

(cherrypicked from 3ad455f87a)
2019-07-21 21:06:54 +02:00
ariel-
f95caecca1 DB/Spell: added conditions for Argent Squire/Gruntling Pennant spells
- Should only target the pet, according to sniffs

(cherrypicked from 77b59c07ad)
2019-07-21 21:06:54 +02:00
Rushor
e2e7961a6f DB/Creature: Heldgarr Steelbeard
Closes #18937

(cherrypicked from f43a940b54)
2019-07-21 21:06:54 +02:00
Rushor
9f2c844a23 DB/Creature: Civilian Recruit
Closes #18936

(cherrypicked from 533749bfa2)
2019-07-21 21:06:54 +02:00
Rushor
cf8f31f739 DB/Creature: Sifreldar Runekeeper and Storm Maiden
Closes #18931

(cherrypicked from d3a8605470)
2019-07-21 21:06:54 +02:00
Rushor
222d4349e0 DB/Creature: Thrallmar Grunt
Closes #18930

(cherrypicked from e6e7354396)
2019-07-21 21:06:54 +02:00
Rushor
50a651b17b DB/Creature: Icetip Crawler
Closes #18929

(cherrypicked from 31d77d2773)
2019-07-21 21:06:54 +02:00
Rushor
5a999c994a DB/Creature: Jimmy the Stable Boy
Closes #18928

(cherrypicked from e2400c6d78)
2019-07-21 21:06:54 +02:00
Rushor
46c78134b1 DB/Creature: Snowblind Devotee
Closes #18920

(cherrypicked from d1d2fbd3e3)
2019-07-21 21:06:54 +02:00
Rushor
3b1b7a49de DB/Creature: Ironwool Mammoth, Part 2
Closes #18896

(cherrypicked from ffbaab8187)
2019-07-21 21:06:54 +02:00
Rushor
cb3631c41d DB/Creature: Ironwool Mammoth, Part 1
Closes #18895

(cherrypicked from 41530b5ac9)
2019-07-21 21:06:54 +02:00
Rushor
12b230d52a DB/Creature: Initiate Park
Closes #18866

(cherrypicked from e55f674abc)
2019-07-21 21:06:54 +02:00
ariel-
17703e8924 Core/Spell: remove duplicated SPELL_AURA_MOD_DEBUFF_RESISTANCE handling.
Each spell had two rolls in which it could be resisted, effectively adding to the resist chance.

Closes #7406

(cherrypicked from 23f76b563f)
2019-07-21 21:06:54 +02:00
Rushor
a09f572d24 DB/Creature: Moarg Peon - Increase spawndistance and update to Randommovement
Closes #18818

(cherrypicked from 91201f11f8)
2019-07-21 21:06:54 +02:00
Killyana
09311a2f44 DB/Creature: Add missing spawn to Gimorak's Den
(cherrypicked from fa4347e788)
2019-07-21 21:06:54 +02:00
Rushor
c753b229ae DB/Creature: Padaar
Closes #18804

(cherrypicked from 7d4ca0b6c4)
2019-07-21 21:06:54 +02:00
Rushor
6a0658abb0 DB/Creature: Dekin
Closes #18803

(cherrypicked from d16547352b)
2019-07-21 21:06:54 +02:00
Rushor
3dae0e0e0f DB/Creature: Netherologist Coppernickels <B.O.O.M.> - Pathing + Emote + textscript
Closes #18802

(cherrypicked from be70e5a0b1)
2019-07-21 21:06:54 +02:00
Rushor
f147d0bdf1 DB/Quest: Welcoming the Wolf Spirit
Closes #18793

(cherrypicked from 1e596d4ec5)
2019-07-21 21:06:54 +02:00
Rushor
54e1e9ccaf DB/Creature: Nekthar - Pathing + Emote + Textscript
Closes #18795

(cherrypicked from 151a0670b4)
2019-07-21 21:06:54 +02:00
Rushor
c958579210 DB/Creature: Consortium Overseer - Pathing + Text
Closes #18794

(cherrypicked from b50e233a19)
2019-07-21 21:06:54 +02:00
Rushor
f3f1cbfd75 DB/Creature: Durkot Wolfbrother - Add pathing and emote event
Closes #18792

(cherrypicked from f6b4a58d8e)
2019-07-21 21:06:54 +02:00
Rushor
393effb807 DB/GameObject: Implement Herb Spawn Pool System for Isle of Quel'Danas
Closes #18791

(cherrypicked from e483b41835)
2019-07-21 21:06:54 +02:00
Killyana
d18bdca773 DB/GameObject: Fel Reaver Control Console
Closes #18657
By Rushor

(cherrypicked from b42369389b)
2019-07-21 21:06:54 +02:00
Killyana
e2bcf0ae1f DB/Creature: Taleris Dawngazer - Emote event
Closes #18783
By Rushor

(cherrypicked from 1e1cfe50a3)
2019-07-21 21:06:54 +02:00
sirikfoll
529ab71f0f DB/Creature: Fixed Valkyr Shadowguard immunities
(cherrypicked from d61daf23cc)
2019-07-21 21:06:54 +02:00
Killyana
12015d39a7 DB: Pathing for several creatures on Hellfire Peninsula
Closes #18769
By Rushor

(cherrypicked from 21dac301a2)
2019-07-21 21:06:54 +02:00
Killyana
1a951497e2 DB: Shadowmoon Valley - The Fel Pits - Rework Spawns and Pathing
By Rushor
Closes #18767

(cherrypicked from 2e2396b29f)
2019-07-21 21:06:54 +02:00
Killyana
c45375982c DB: Fix 2 DB errors
(cherrypicked from b4fc92a423)
2019-07-21 21:06:54 +02:00
Killyana
912a1ace83 DB/Quest: Take No Chances
Closes #17887

(cherrypicked from fe999bcf78)
2019-07-21 21:06:54 +02:00
Killyana
3d27ed92f7 DB/Quest: Battle Before The Citadel - Phasing
Closes #18761
By Rushor
f3462659f0 (commitcomment-20396734)

(cherrypicked from 763beb694f)
2019-07-21 21:06:54 +02:00
Killyana
e51550b1eb DB: At The Enemy's Gates - Phasing
Closes #18751
Closes #15540
By Rushor

(cherrypicked from f3462659f0)
2019-07-21 21:06:54 +02:00
Keader
80545b1a84 Update sql file
(cherrypicked from b1fa8ff028)
2019-07-21 21:06:54 +02:00
Keader
9bd8ca0e5f Core/Scripts: Palehoof rewritten & Utgarde Pinnacle updated (#18712)
Closes #15405

(cherrypicked from ba1df45d36)
2019-07-21 21:06:54 +02:00
Shauren
ff334ae707 Core/Conditions: Reimplemented CONDITION_OBJECT_ENTRY_GUID and CONDITION_TYPE_MASK under new values to allow easier porting conditions between branches. Old data is dynamically converted during startup 2019-07-21 17:12:34 +02:00
Shauren
3058d8c5ab Core/bnetserver: Fixed crash happening when sending packets larger than 4096 bytes 2019-07-21 16:32:49 +02:00