Commit Graph

39720 Commits

Author SHA1 Message Date
Killyana
92ab79bd9a DB/Creature: Add some missing spawns
(cherry picked from commit b69c5560dc)
2022-01-01 19:15:28 +01:00
Killyana
8ee91389bf DB/Spawn: Spawn phase 4 in "The Bombardment" area
(cherry picked from commit 7b48580296)
2022-01-01 17:56:39 +01:00
Alan Deutscher
68e1dc8adb Core/Players: Improve trade exchange calculations (#24435)
* Add some comments to Player::CanStoreItems to help me wrap my head around how the method works.

* Experimental fix for incoming trade-stack problem.

* Only add to stacks that aren't already full.

* Use remaining_count instead of static 1.

* Remove debug logging from exploration.

* More uses of remaining_count for consistency.

* Correct space count check

* Correct overflow problem.

* Remove redundant check, handled in existing for statement.

* Store Item pointers in order to be able to merge in multiple incoming stacks.

* Build fix - was continually working locally, but failing in CI.

* Break build in order to keep PR focused on Player.cpp changes.

* Adjust phrasing of how arrays are initialized.

* Fix phrasing of comments to avoid sounding like a ToDo item

* In the spirit of b649273d5f, rephrase an old comment to be a statement rather than a question.

(cherry picked from commit e11a13c755)
2022-01-01 16:29:06 +01:00
dr-j
d6931f392e DB: Remove wrong spawns related to "Kickin’ Nass and taking manes"
Closes #24464

(cherry picked from commit 4bf5bec509)
2022-01-01 16:21:20 +01:00
Killyana
9f25add1c7 DB/Quest: Investigate the Blue Recluse & Investigate the Alchemist Shop
Closes #24024

(cherry picked from commit 1a1489d73e)
2022-01-01 16:20:37 +01:00
Keader
6957dd9bd6 Scripts/Ulduar: Little improvements in Auriaya
* Removed DespawnAtEvade
* Fix Feral Defender Damage

(cherry picked from commit 77dd751499)
2022-01-01 15:54:52 +01:00
Rushor
4665a2bc40 DB/SAI: Servant of the Throne & Ancient Skeletal Soldier
Closes #24401

(cherry picked from commit d2d2965741)
2022-01-01 15:54:04 +01:00
Rushor
14a4fb99fe DB/Creature: Val'kyr Protector & Val'kyr Guardian
Closes #24398

(cherry picked from commit 13a429ab26)
2022-01-01 15:53:36 +01:00
Killyana
8a26afd548 DB/Spell: Lok'lira's Bargain
ref #24408

(cherry picked from commit 36ba94c007)
2022-01-01 15:53:10 +01:00
dr-j
3704243f9b DB/Quest: Vereth the Cunning quest chaining
Closes #24452

(cherry picked from commit 80803039c2)
2022-01-01 15:52:18 +01:00
Keader
0484c0a337 Scripts/Trial of Crusader: Fixed issue with Snobold Vassal and some achiev criteria resets
* Fixed snobold behavior when gormok dies
* Fixed UPPER_BACK_PAIN Archiev reset
* Fixed THREE_SIXTY_PAIN_SPIKE Archiev reset

(cherry picked from commit 78dff46bf2)
2022-01-01 15:51:21 +01:00
Gildor
a477e85ae3 Scripts/Quest: The Exorcism of Colonel Jules (#24459)
* Remove Anchorite Barada gossip when event start

(cherry picked from commit 8a5b02be0a)
2022-01-01 15:51:07 +01:00
dr-j
68d2263863 DB/GameObject: Brazier of Madness
Closes #24427

(cherry picked from commit c1c1929e06)
2022-01-01 15:30:37 +01:00
ForesterDev
e73735fa61 Core/PacketIO: updated SMSG_DURABILITY_DAMAGE_DEATH (#24442)
- use RATE_DURABILITY_LOSS_ON_DEATH for death from falling
- add note, that RATE_DURABILITY_LOSS_ON_DEATH doesn't change log message

(cherry picked from commit a1831e0c1e)

Co-authored-by: MitchesD <majklprofik@seznam.cz>
(cherry picked from commit e1a8ebc064)
2022-01-01 15:25:11 +01:00
Killyana
aeb250d597 DB/Creature: Arcanist Torseldori & Bloodmage
Closes #24449

(cherry picked from commit 400e291317)
2022-01-01 15:14:08 +01:00
Killyana
f01d07c315 DB/Quest: Mystery of the Infinite & Mystery of the Infinite, Redux
Closes #16988

(cherry picked from commit 3621b1fd34)
2022-01-01 15:13:30 +01:00
Killyana
da46ffd94c DB/Gameobject: Remove wrong script from Tirisfal Pumpkin
(cherry picked from commit f9d1177379)
2022-01-01 15:11:46 +01:00
Killyana
dcea677b01 DB/Creature: Sartharion Twilight Egg
(cherry picked from commit daecf90ac4)
2022-01-01 15:10:40 +01:00
Killyana
aeb949f589 DB/Quest: Battle at Valhalas: Fallen Heroes
Spawn positions fix and linked aggro

(cherry picked from commit 608d23fb1e)
2022-01-01 15:09:08 +01:00
Killyana
1c8e81c9f8 DB/Quest: Battle at Valhalas: The Return of Sigrid Iceborn
Closes #22578

(cherry picked from commit 83c222826b)
2022-01-01 15:08:37 +01:00
Killyana
3f6820a6ac DB/Quest: Improve Devout Bodyguard behavior related to the quest A Fall From Grace
(cherry picked from commit d57b42f2c8)
2022-01-01 15:08:06 +01:00
Killyana
4dae63d16a DB/Creature: Fel Orc Neophyte
Add immune to pc/npc for cosmetic spawns to avoid accident aggro

(cherry picked from commit 2aa32d3beb)
2022-01-01 15:05:39 +01:00
Gildor
60e66621da Core/Gameobjects: Improve stealth detection (#24417)
* Core/Gameobjects: Improve stealth detection

* fix warning: private field 'i_funit' is not used

* Code cleanup

* add comment

Co-authored-by: jackpoz <giacomopoz@gmail.com>
(cherry picked from commit 862097a633)
2022-01-01 15:05:01 +01:00
Sven
2aa5f4e1b2 Improvements to Pyroguard Emberseer (UBRS) script (#24405)
* UBRS: Improve Pyroguard Emberseer script

* Remove whitespaces

* More whitespaces removed

* Addressing change requests
Removed cast from constructor
Removing unused member field

* That should be the last white spaces

* Forgot to remove the declaration

* Update boss_pyroguard_emberseer.cpp

* Add break to For loop

* War on white spaces

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit c3037c3563)
2022-01-01 14:52:43 +01:00
Killyana
baa848c992 DB/Quest: Danger! Explosives!
Closes #22490

(cherry picked from commit 5ec303724e)
2022-01-01 14:47:26 +01:00
ForesterDev
931ca1e546 Core/PacketIO: updated SMSG_FEATURE_SYSTEM_STATUS (#24403)
* Core/Packets: updated SMSG_FEATURE_SYSTEM_STATUS

(cherry picked from commit 231207970b)

* Define complaint status values and replace magic numbers

* Add missing header

Co-authored-by: joschiwald <joschiwald.trinity@gmail.com>
(cherry picked from commit bfd73e7f47)
2022-01-01 14:43:20 +01:00
Sorikoff
26ae6df032 Scripts/Pets: Mojo (#24431)
* Mojo

* Update

* Rename 9999_99_99_99_world.sql to 2020_04_11_01_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 194691f7c3)
2022-01-01 14:38:52 +01:00
jackpoz
7eff81f9db Core/Pools: Fix crash on startup
(cherry picked from commit 9cde3ffd14)
2022-01-01 14:34:20 +01:00
Killyana
e4bcb65fcf DB/SAI: Replace the action 70 by 41 to despawn gobs
Years ago the action 70 was used to despawn/respawn gobs but it's no longer the case , it must only be used to respawn gobs with negative respawntime

(cherry picked from commit 428528774e)
2022-01-01 14:30:56 +01:00
Giacomo Pozzoni
97c1d01cbb Core/Pooling: Remove respawn times from the database when despawning a pool (#24422)
* Core/Pooling: Remove respawn times from the database when despawning a pool

Remove respawn times from the database when despawning a pool. This is needed when a Game Event ends but there are still some respawn times saved in the database.

* Remove respawn time of active pool objects even if they are not spawned

(cherry picked from commit 4f33fd3932)
2022-01-01 14:02:00 +01:00
Killyana
281e695c56 Creature: Gorkun Ironskull & Martin Victus in The Pit of Saron
Still some events are missing in this instance

(cherry picked from commit d0f9ace679)
2022-01-01 13:48:05 +01:00
Aokromes
9d70595957 Misc: Deprecate mysql 5.6
(cherry picked from commit 0fa366cbda)
2022-01-01 13:29:04 +01:00
Shauren
2f17038373 Scripts/Eye of Eternity: Fixed The Focusing Iris not respawning on wipe
Closes #22948

(cherry picked from commit f57b1e27d0)
2022-01-01 13:28:41 +01:00
Shauren
ba69c91f4b Core/Spells: Fixed checking free inventory space for some spells that have bad dbc data
Closes #24423

(cherry picked from commit 18b36734f6)
2022-01-01 13:28:04 +01:00
Killyana
a020c4ad7c DB/SAI: Har'koa
(cherry picked from commit 81a09eb03e)
2022-01-01 13:09:55 +01:00
Killyana
dbcac4f282 DB/Creature: Ahn'kahar Watcher
(cherry picked from commit 2d72439b06)
2022-01-01 13:09:25 +01:00
Killyana
22697db18b DB/Quest: Add a missing text for the quest Rescuing Evanor and fix a gob flag
Reduce 25724 respawntime to 1min

(cherry picked from commit 8fe2e66f2f)
2022-01-01 13:08:08 +01:00
dr-j
dcb868e44f DB/SAI: Improvements for Writhing Mound event
(cherry picked from commit aafe303fc4)
2022-01-01 13:07:22 +01:00
Giacomo Pozzoni
a947ee1912 Core/SAI: Allow SMART_TARGET_ACTION_INVOKER to target GameObjects (#24416)
* Core/SAI: Allow SMART_TARGET_ACTION_INVOKER to target GameObjects

* Include new Coalesce(..) template by @Shauren

(cherry picked from commit 90b00288c2)
2022-01-01 13:06:27 +01:00
dr-j
c0c867e6e5 DB/Quest: Hard to Swallow
Closes #23915

(cherry picked from commit 6424630667)
2022-01-01 12:59:09 +01:00
jackpoz
68d947d42f Core/Log: Log all character kicks to "network.kick" category
(cherry picked from commit 31018c3652)
2022-01-01 12:56:24 +01:00
jackpoz
dbb0f399fa Core/NetworkIO: Adjust more packet throttling values
Thanks @Nefertumm at f5e38a7f57 for the heads-up

(cherry picked from commit 68fcd592f8)
2022-01-01 12:44:07 +01:00
jackpoz
33e495983b Core/Movement: Add safety check to avoid C++ undefined behaviour
(cherry picked from commit 67f28adaf7)
2022-01-01 12:42:31 +01:00
Ovah
d18d2b84f2 Core/Objects: cache current liquid status of objects when updating position data and use it to replace unnecessary vmap lookups (#24399)
* dropped unneeded IsUnderwater override for players since the default position data update considers collision height already so we don't have to rely on that tempfix anymore. This actually fixes breathing bars showing up depending on your characters size (gnomes get their breathing bar earlier, taurens later etc)

(cherry picked from commit bea850fb73)
2022-01-01 12:42:17 +01:00
Aokromes
fa1eb9f36f Misc: Update (C) year
happy new year
2022-01-01 09:08:49 +01:00
Shauren
9f76071108 Core/Misc: Remove whitespace at the end of lines 2022-01-01 01:25:04 +01:00
kvolk2git
285e3a1ed2 Core/DBUpdater: Fixed db auto updater for mysql 8 when ssl connections are enabled (#27298)
(cherry picked from commit 57617e215b)
2022-01-01 01:11:58 +01:00
Shauren
3b4a2a0a94 Core/DBLayer: Fix compilation with mysql 8
(cherry picked from commit 579d41acc5)
2022-01-01 01:10:25 +01:00
Shadow
321bc3ccfa Missing rbac permissions (#24253)
* Added missing RBAC permissions to auth database

* Rename 9999_99_99_99_auth.sql to 2020_04_07_00_auth.sql

* Update 2020_04_07_00_auth.sql

* Update auth_database.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit d962624d61)
2022-01-01 01:09:52 +01:00
myuzhobcplidtkieno
de5f7edede Added the ability to use TLS when connecting to a database. (#24348)
* Added the ability to use TLS when connecting to a database.

* Trying to kickstart CI checks

* Revert the kickstart change

Co-authored-by: myuzhobcplidtkieno <myuzhobcplidtkieno@github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit ae553f8966)
2022-01-01 01:07:52 +01:00