Peter Keresztes Schmidt
4286e7aa02
Core/ChatCommands: Check whether a passed numeric enum value is valid ( #25285 )
2020-08-20 00:46:52 +02:00
Peter Keresztes Schmidt
86dc58974a
Scripts/Commands: Use enum type arg for HandleDebugAnimCommand (PR #25256 )
...
* Core/Shared: Make Emote enum smart
* Scripts/Commands: Use enum type arg for HandleDebugAnimCommand
2020-08-16 16:26:47 +02:00
Peter Keresztes Schmidt
6c7837f947
Core/Unit: Make HandleEmoteCommand typesafe ( #25249 )
...
* Scripts/ScarletMonastery: Fix wrong emote during Headless Horseman encounter
* Scripts/HoR: Fix wrong emote during escape event
* Core/Unit: Make improve type safety of HandleEmoteCommand
Change argument type to the expected enum type Emote
* Scripts/CoS: Use SetUInt32Value to set UNIT_NPC_EMOTESTATE
UNIT_NPC_EMOTESTATE is no flag field
2020-08-15 15:29:43 +02:00
Shauren
06f59caf3d
Core/DataStores: Rename TalentTabEntry::CategoryEnumID back to PetTalentMask
2020-07-31 20:02:08 +02:00
Shauren
3ad05386c8
Core/Networking: Fixed authserver socket read handlers being called on incorrect thread
2020-07-28 19:44:38 +02:00
Treeston
4f570e5d08
Core/Authserver: Auth cleanup phase 1b, the "I didn't hit Stage All" commit. Sorry. ( 5e36bf7 follow-up)
2020-07-26 05:20:41 +02:00
Treeston
210176fd91
Core/Authserver: Authserver cleanup (PR#25093)
...
- Fix a handful of 1/256 bugs with most significant byte zero in BigNumber
- Get rid of (most of) the C-style arrays in authserver
- CryptoRandom as a unified source for cryptographic randomness
- Bring our other crypto APIs into 2020
- BigNumber usability improvements
- Authserver is now actually readable as a result of all of the above
2020-07-26 01:53:34 +02:00
Peter Keresztes Schmidt
e6e5775be8
Build: Enable -Wimplicit-fallthrough on clang ( #25056 )
...
* Misc: Use [[fallthrough]] attribute instead of comment to mark intentional fallthroughs
Related: #25006
* Misc: Add some missing breaks (no-ops) to satisfy clang
Related: #25006
Closes #25055
* Build: Enable -Wimplicit-fallthrough on clang
Closes #25006
2020-07-18 20:43:16 +02:00
Giacomo Pozzoni
203573db83
Core/Spells: Implement SPELL_EFFECT_ACTIVATE_OBJECT. ( #23 ) ( #24997 )
...
* Core/Spells: Implement SPELL_EFFECT_ACTIVATE_OBJECT. (#23 )
Original research by @xvwyh.
# Conflicts:
# src/server/game/DataStores/DBCStores.cpp
# src/server/game/DataStores/DBCStructure.h
# src/server/game/DataStores/DBCfmt.h
# src/server/game/Entities/GameObject/GameObject.h
# src/server/game/Entities/GameObject/GameObjectData.h
# src/server/scripts/EasternKingdoms/ZulAman/zulaman.cpp
# src/server/scripts/Kalimdor/HallsOfOrigination/boss_temple_guardian_anhuur.cpp
* Add missing sql update
* Fix some build errors
* Remove unused enum values
* Change artkits from 0-4 to 0-3
* Remove unused code
* Code review feedback
* Fix sql
* Remove artkit4 special case handling
* Default initialize artKits
* Code review feedback
* Split sql into structure and data files
Co-authored-by: Warpten <vertozor@gmail.com >
2020-07-14 09:34:03 +02:00
Peter Keresztes Schmidt
c92950b3e1
Core/DataStores: Update DBC field names to generated ones ( #24999 )
2020-07-12 15:36:55 +02:00
Max Drosdo.www
3529442668
Core/Player: Introduce separate level caps for each expansion ( #24989 )
2020-07-11 11:10:04 +02:00
Shauren
0468c70dfe
Core/Maps: Implemented getting area id from gameobject spawns
...
Yes, you can now spawn LK platform anywhere and it will treat you as inside Icecrown Citadel
(cherry picked from commit 42f9deb21e )
2020-06-27 20:23:30 +02:00
jackpoz
54c701cf0d
Core/Common: Replace ASSERT(false, "...") with ABORT_MSG("...")
2020-06-26 23:37:52 +02:00
Carbenium
22c12e7123
Core/Misc: Move WorldState enum to SharedDefines
...
Move WG battlefield world states to the global enum
2020-06-24 15:09:57 +02:00
Carbenium
6a8c12587e
Core/Misc: Create new enum for AreaIds
...
Move Wintergrasp BF related values there
2020-06-24 15:09:57 +02:00
ipriver
a46d047f94
fixed indentation for cmake files
2020-06-24 14:42:02 +02:00
Peter Keresztes Schmidt
b210bb3713
Core/Misc: Replace Trinity::make_unique with std ( #24869 )
...
(cherry picked from commit bab5fd87a3 )
2020-06-23 18:03:16 +02:00
Giacomo Pozzoni
8c09b6e58b
Cherry-pick some cmake commits ( #24720 )
...
* Build system: Support new in cmake 3.17 Ninja Multi-Config generator
(cherry picked from commit 369b618d4f )
* Build system: Fixed PCH with MSVC & Ninja generator
(cherry picked from commit d669f46b6d )
* Core: Fix clang 10 warnings
(cherry picked from commit 7272508cb4 )
# Conflicts:
# src/common/Utilities/Util.h
# src/server/bnetserver/REST/LoginRESTService.cpp
# src/server/game/Entities/Object/Position.h
# src/server/game/Entities/Player/Player.cpp
# src/server/game/Guilds/GuildFinderMgr.h
# src/server/game/Movement/Spline/MoveSplineFlag.h
# src/server/shared/Dynamic/LinkedList.h
* Build system: Set -Wno-deprecated-copy only for clang 10
(cherry picked from commit 7fdeb259ba )
* Core/Misc: GCC build and warning fixes
(cherry picked from commit 4d69cc1c56 )
# Conflicts:
# src/common/Utilities/Util.cpp
# src/server/database/Database/MySQLConnection.cpp
# src/server/game/Battlefield/Zones/BattlefieldTB.cpp
# src/server/game/DataStores/M2Stores.cpp
# src/server/game/DungeonFinding/LFGMgr.cpp
# src/server/game/DungeonFinding/LFGPlayerData.cpp
# src/server/game/Entities/GameObject/GameObject.cpp
# src/server/game/Entities/Item/Item.cpp
# src/server/game/Entities/Object/Updates/UpdateFields.h
# src/server/game/Entities/Player/Player.cpp
# src/server/game/Entities/Player/RestMgr.cpp
# src/server/game/Entities/Unit/Unit.cpp
# src/server/game/Handlers/PetHandler.cpp
# src/server/game/Server/Packets/GuildPackets.h
# src/server/game/Spells/Auras/SpellAuraEffects.cpp
# src/server/game/Spells/Auras/SpellAuras.cpp
# src/server/game/Spells/Spell.cpp
# src/server/game/Spells/SpellInfo.cpp
# src/server/game/Spells/SpellMgr.cpp
# src/server/scripts/Argus/AntorusTheBurningThrone/boss_garothi_worldbreaker.cpp
# src/server/scripts/Kalimdor/HallsOfOrigination/instance_halls_of_origination.cpp
# src/server/scripts/Northrend/IcecrownCitadel/instance_icecrown_citadel.cpp
# src/server/scripts/Northrend/Ulduar/Ulduar/boss_mimiron.cpp
# src/server/scripts/Northrend/zone_sholazar_basin.cpp
# src/server/scripts/Outland/BlackTemple/instance_black_temple.cpp
# src/server/scripts/Outland/GruulsLair/instance_gruuls_lair.cpp
# src/server/scripts/Outland/HellfireCitadel/BloodFurnace/instance_blood_furnace.cpp
# src/server/scripts/Outland/HellfireCitadel/ShatteredHalls/shattered_halls.cpp
# src/tools/vmap4_extractor/gameobject_extract.cpp
# src/tools/vmap4_extractor/model.cpp
# src/tools/vmap4_extractor/vec3d.h
* Build system: Print found git version when warning about it being too old
(cherry picked from commit 1ae72db201 )
* Build system: Removed hard requirement on BOOST_ROOT being set as environment variable, it can now be also passed as command line argument to cmake and fix compile warning with boost 1.73
(cherry picked from commit 161944b764 )
# Conflicts:
# dep/boost/CMakeLists.txt
* Remove some code that was already removed from 335 and then cherry-picked into master
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2020-05-31 14:17:26 +02:00
HelloKitty
43b595111d
Further improve ChrRace DBC handling ( #24508 )
...
* Core/DBC: Added ChrRacesAllianceType for ChrRaces.dbc
* Core/Character: Check ChrRace DBC playable in HandleCharCreateOpcode
* Core/DBC: Implement ChrRacesFlags removing literals
Cannot take credit for this enum, derived from documentation in
https://wowdev.wiki/DB/ChrRaces
* Core/Character: Check CHRRACES_FLAGS_NOT_PLAYABLE on creation
* Core/DBC: Fix formatting of ChrRaces enums
* Core/DBC: Use ChrRaces CreatureType instead of hardcoded humanoid assumption
* Address enum style code changes
2020-05-15 20:41:16 +02:00
NoName
26439c8951
Core/ByteBuffer: Fixed output truncation in ByteBuffer::hexlike ( #24595 )
...
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2020-05-11 22:21:31 +02:00
HelloKitty
772f506a3b
Improve Creature DBC Handling ( #24509 )
...
* Core/DBC: Add CreatureModelDataFlags to remove hardcoded literals
* Core/DBC: Use CreatureType flags in Creature::CanGiveExperience calculation
* Core/DBC: Fixed CreatureType Flags Misinterpretation
Meaning of this was wrong, wowdev wiki was incorrect. Partially reverts
0d61e653f4
* Address enum codestyle
* Update DBCStructure.h
* Update DBCfmt.h
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
2020-05-10 14:30:25 +02:00
NoName
c38a9d757d
Core/Spells: implement SMSG_MOUNT_RESULT and use it for transformed mounting cases ( #24507 )
...
cherry-pick from fb0d2ed2b9
Co-authored-by: Ovah <dreadkiller@gmx.de >
2020-04-29 22:37:35 +02:00
HelloKitty
f1ad04b31b
Core/DataStores: Use ResSicknessSpellID from ChrRaces instead of hardcoding it ( #24504 )
2020-04-27 17:55:25 +02:00
ForesterDev
bfd73e7f47
Core/PacketIO: updated SMSG_FEATURE_SYSTEM_STATUS ( #24403 )
...
* Core/Packets: updated SMSG_FEATURE_SYSTEM_STATUS
(cherry picked from commit 231207970b )
# Conflicts:
# src/server/game/Battlegrounds/ArenaTeam.cpp
# src/server/game/Entities/Player/Player.cpp
# src/server/game/Entities/Player/Player.h
# src/server/game/Handlers/CharacterHandler.cpp
# src/server/game/Handlers/GroupHandler.cpp
# src/server/game/Handlers/SpellHandler.cpp
# src/server/game/Server/Packets/SpellPackets.cpp
# src/server/game/Server/Packets/SpellPackets.h
# src/server/game/Server/Packets/SystemPackets.cpp
# src/server/game/Server/Packets/SystemPackets.h
# src/server/game/Server/Protocol/Opcodes.cpp
# src/server/game/Server/Protocol/Opcodes.h
# src/server/game/Server/WorldSession.h
* Define complaint status values and replace magic numbers
* Add missing header
Co-authored-by: joschiwald <joschiwald.trinity@gmail.com >
2020-04-11 19:49:36 +02:00
jackpoz
caae3886d2
Core/Misc: Remove whitespace at the end of lines
2020-04-05 19:11:00 +02:00
Shauren
635b8d52d5
Core/DBLayer: Prevent committing transactions started on a different database
...
(cherry picked from commit f6e2b8cdc1 )
# Conflicts:
# src/server/bnetserver/REST/LoginRESTService.cpp
# src/server/database/Database/DatabaseWorkerPool.cpp
# src/server/database/Database/DatabaseWorkerPool.h
# src/server/database/Database/Implementation/HotfixDatabase.h
# src/server/database/Database/MySQLConnection.h
# src/server/database/Database/Transaction.cpp
# src/server/database/Database/Transaction.h
# src/server/game/Achievements/AchievementMgr.cpp
# src/server/game/Achievements/AchievementMgr.h
# src/server/game/AuctionHouse/AuctionHouseMgr.cpp
# src/server/game/AuctionHouse/AuctionHouseMgr.h
# src/server/game/BattlePets/BattlePetMgr.cpp
# src/server/game/BattlePets/BattlePetMgr.h
# src/server/game/BlackMarket/BlackMarketMgr.cpp
# src/server/game/BlackMarket/BlackMarketMgr.h
# src/server/game/Entities/Creature/Creature.cpp
# src/server/game/Entities/Item/Item.cpp
# src/server/game/Entities/Item/Item.h
# src/server/game/Entities/Player/CollectionMgr.cpp
# src/server/game/Entities/Player/CollectionMgr.h
# src/server/game/Entities/Player/Player.cpp
# src/server/game/Entities/Player/Player.h
# src/server/game/Garrison/Garrison.cpp
# src/server/game/Garrison/Garrison.h
# src/server/game/Groups/Group.cpp
# src/server/game/Guilds/Guild.cpp
# src/server/game/Guilds/Guild.h
# src/server/game/Guilds/GuildFinderMgr.cpp
# src/server/game/Handlers/BlackMarketHandler.cpp
# src/server/game/Handlers/CalendarHandler.cpp
# src/server/game/Handlers/CharacterHandler.cpp
# src/server/game/Handlers/MailHandler.cpp
# src/server/game/Handlers/PetHandler.cpp
# src/server/game/Handlers/PetitionsHandler.cpp
# src/server/game/Mails/Mail.cpp
# src/server/game/Pools/PoolMgr.cpp
# src/server/game/Quests/QuestObjectiveCriteriaMgr.cpp
# src/server/game/Quests/QuestObjectiveCriteriaMgr.h
# src/server/game/Scenarios/InstanceScenario.cpp
# src/server/game/Server/WorldSession.cpp
# src/server/game/Server/WorldSession.h
# src/server/game/Spells/SpellHistory.cpp
# src/server/game/Support/SupportMgr.cpp
# src/server/game/Tools/PlayerDump.cpp
# src/server/scripts/Commands/cs_misc.cpp
2020-03-31 13:42:01 +00:00
Shauren
fe1003bdbd
Core/DBLayer: Prevent using prepared statements on wrong database
...
(cherry picked from commit e8e89f58fb )
# Conflicts:
# src/server/bnetserver/REST/LoginRESTService.cpp
# src/server/bnetserver/Server/Session.cpp
# src/server/database/Database/DatabaseWorkerPool.cpp
# src/server/database/Database/Implementation/HotfixDatabase.h
# src/server/database/Database/MySQLConnection.cpp
# src/server/database/Database/MySQLConnection.h
# src/server/database/Database/PreparedStatement.cpp
# src/server/database/Database/PreparedStatement.h
# src/server/database/Database/QueryHolder.cpp
# src/server/database/Database/SQLOperation.h
# src/server/database/Database/Transaction.h
# src/server/game/Accounts/BattlenetAccountMgr.cpp
# src/server/game/Achievements/AchievementMgr.cpp
# src/server/game/AuctionHouse/AuctionHouseMgr.cpp
# src/server/game/AuctionHouseBot/AuctionHouseBot.cpp
# src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
# src/server/game/BattlePets/BattlePetMgr.cpp
# src/server/game/Battlegrounds/ArenaTeam.cpp
# src/server/game/BlackMarket/BlackMarketMgr.cpp
# src/server/game/Chat/Channels/Channel.cpp
# src/server/game/Entities/Corpse/Corpse.cpp
# src/server/game/Entities/Creature/Creature.cpp
# src/server/game/Entities/GameObject/GameObject.cpp
# src/server/game/Entities/Item/Item.cpp
# src/server/game/Entities/Pet/Pet.cpp
# src/server/game/Entities/Player/CollectionMgr.cpp
# src/server/game/Entities/Player/Player.cpp
# src/server/game/Garrison/Garrison.cpp
# src/server/game/Globals/ObjectMgr.cpp
# src/server/game/Groups/Group.cpp
# src/server/game/Guilds/Guild.cpp
# src/server/game/Guilds/GuildFinderMgr.cpp
# src/server/game/Guilds/GuildMgr.cpp
# src/server/game/Handlers/AuctionHouseHandler.cpp
# src/server/game/Handlers/CharacterHandler.cpp
# src/server/game/Handlers/ItemHandler.cpp
# src/server/game/Handlers/MailHandler.cpp
# src/server/game/Handlers/MiscHandler.cpp
# src/server/game/Handlers/PetitionsHandler.cpp
# src/server/game/Handlers/SpellHandler.cpp
# src/server/game/Handlers/TicketHandler.cpp
# src/server/game/Loot/Loot.cpp
# src/server/game/Mails/Mail.cpp
# src/server/game/Maps/Map.cpp
# src/server/game/Movement/Waypoints/WaypointManager.cpp
# src/server/game/OutdoorPvP/OutdoorPvP.cpp
# src/server/game/Pools/PoolMgr.cpp
# src/server/game/Quests/QuestObjectiveCriteriaMgr.cpp
# src/server/game/Reputation/ReputationMgr.cpp
# src/server/game/Scenarios/InstanceScenario.cpp
# src/server/game/Server/WorldSession.cpp
# src/server/game/Server/WorldSocket.cpp
# src/server/game/Spells/SpellHistory.cpp
# src/server/game/Support/SupportMgr.cpp
# src/server/game/Tools/PlayerDump.cpp
# src/server/game/World/World.cpp
# src/server/scripts/Commands/cs_account.cpp
# src/server/scripts/Commands/cs_ban.cpp
# src/server/scripts/Commands/cs_battlenet_account.cpp
# src/server/scripts/Commands/cs_group.cpp
# src/server/scripts/Commands/cs_lfg.cpp
# src/server/scripts/Commands/cs_list.cpp
# src/server/scripts/Commands/cs_message.cpp
# src/server/scripts/Commands/cs_misc.cpp
# src/server/scripts/Commands/cs_npc.cpp
# src/server/scripts/Commands/cs_tele.cpp
# src/server/scripts/Commands/cs_wp.cpp
# src/server/shared/DataStores/DB2DatabaseLoader.cpp
# src/server/shared/Realm/RealmList.cpp
2020-03-31 13:42:01 +00:00
Shauren
f2f47f774f
Core/PacketIO: Add a validating string helper class for use in packet classes
2020-03-18 23:20:11 +01:00
Shauren
1227e96bd3
Core/ByteBuffer: Fix string format
2020-03-15 16:10:22 +01:00
Shauren
0a2a96efaa
Core/PacketIO: Validate utf8 in every client packet
2020-03-15 14:28:29 +01:00
NoName
50d9d9196d
Core/Gameobject: Rename GO_STATE_ACTIVE_ALTERNATIVE to GO_STATE_DESTROYED ( #24062 )
...
* Step 1: Rename GO_STATE_ACTIVE_ALTERNATIVE to GO_STATE_DESTROYED
* Update src/server/shared/SharedDefines.h
Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com >
Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com >
2020-01-19 17:51:30 +01:00
Aokromes
ed93932537
New year
...
Say bye bye to every year changing dates
2020-01-02 06:25:50 +01:00
Shauren
b990a79fd8
Core/Realms: Move build info (and auth seeds) to database
...
(cherry picked from commit 61f2eed353 )
2019-12-07 13:14:16 +01:00
ccrs
06c6b30ed4
Scripts/ScarletMonastery: instance script cleanup ( #23889 )
...
Adapt InstanceScript into newer structure and style
Adapt existing boss scripts into newer structure and style
Improve existing boss related definitions
Should make each boss more functionally reliable, but nothing new has been added
2019-10-26 23:33:30 +02:00
Treeston
4211645834
[3.3.5] Core/Authserver: TOTP rewrite: (PR #23633 )
...
- Proper management commands (.account 2fa)
- Secrets can now be encrypted (set TOTPTokenSecret in .conf)
- Secret now stored in binary
- Argon2 and AES primitives
- Base32/64 support
2019-08-10 21:34:51 +02:00
Giacomo Pozzoni
a0f8ce14e9
3.3.5 Don't allow to summon dead hunter pets ( #23271 )
...
* Core/Player: Add support to SMSG_PET_TAME_FAILURE
* Core/Pet: Don't summon dead pets when using "Call pet"
2019-08-02 16:09:02 +02:00
Treeston
b2b7ae8898
Contrib/Misc: There, build fix. 19d71fb follow-up.
2019-07-30 12:04:26 +02:00
Treeston
19d71fb206
Contrib/Misc: Allow enumutils_describe.py to better deal with commented-out enum lines
2019-07-30 11:42:08 +02:00
Treeston
e813200e5e
Core/Misc: Kick a Totem error log upstairs one stack frame to give it access to various debug info and make Aokromes happy.
2019-07-29 21:37:15 +02:00
ForesterDev
0c317498a5
Scripts/Defines: cleanup some magic numbers in factions ( #23631 )
2019-07-25 12:54:49 +02:00
ForesterDev
915f8a9d2c
Core/Totems: update select display for shaman totems ( #23583 )
...
(cherry picked from commit 8ca6a20e73 )
# Conflicts:
# src/server/game/Entities/Totem/Totem.cpp
# src/server/game/Entities/Unit/Unit.cpp
# src/server/game/Entities/Unit/Unit.h
# src/server/game/Spells/SpellMgr.cpp
# src/server/game/Spells/SpellMgr.h
# src/server/game/World/World.cpp
2019-07-24 23:53:31 +02:00
ccrs
3785a35511
Server/Packets: implement SMSG_RESYNC_RUNES packet structure
2019-07-13 18:58:04 +02:00
Ovahlord
980047763a
Core/Creature: Reworked creature aggro radius calculation ( #20615 )
...
* Core/Creatures: rewrote creature aggro radius calculation
* Formulas are taken from WoW Wiki
2019-07-05 18:21:00 +02:00
Jozef Dúc
78070163dc
Core/Object: Range check vol. 2 ( #23226 )
...
* Core/Object: Fix all missing parts for #23062
* Update GameObject.cpp
2019-05-02 21:53:12 +02:00
Shauren
d56c671064
Core/Dep: Boost 1.70 compatibility
...
(cherry picked from commit bcda8dd742 )
2019-04-14 01:04:02 +02:00
jackpoz
cc0f20f73d
Core/Misc: Fix no-pch build
2019-02-16 18:28:25 +01:00
jackpoz
46f2595f51
Core/Networking: Set SO_REUSEADDR on *nix platforms
2019-01-18 20:31:47 +01:00
Giacomo Pozzoni
57d7b19452
Core/Networking: Fix memory leak ( #22923 )
...
Fix memory leak reported by ASan happening when ports fail to bind in Authserver
2019-01-10 20:02:09 +01:00
Treeston
fcfcb0eb6f
Happy New Year, folks. It's 2019!
2019-01-01 15:45:25 +01:00
Shauren
3b5014fdae
Core/Spells: Fixed ErrorCube spell missiles
2018-12-31 21:41:25 +01:00