Commit Graph

429 Commits

Author SHA1 Message Date
thenecromancer
4b0d412e42 Some more casting requirements
*Not allow cast on invisible/stealth target if not detected
*Not allow banish/cyclone tapped unit
*Not allow pickpocket players and units that can never be pickpocketed
*Not allow disarm unarmed units

--HG--
branch : trunk
2010-01-13 11:45:54 +01:00
_manuel_
a7c23494c3 Fixed spell 44401 (Missile Barrage). Thanks to QAston.
--HG--
branch : trunk
2010-01-11 20:44:13 -03:00
Astellar
f41e837143 Addition to previous commit.
--HG--
branch : trunk
2010-01-10 22:42:41 +03:00
Astellar
40f70a8594 Fixed quest Catch and Release, some fixes for Tag Murloc spell.
--HG--
branch : trunk
2010-01-10 22:37:31 +03:00
Rat
5b6079ea67 *cleaned up SharedDefines
--HG--
branch : trunk
2010-01-10 16:27:47 +01:00
Rat
903f975dc8 *fix spell: Tag Murloc (30877)
--HG--
branch : trunk
2010-01-10 15:29:04 +01:00
QAston
f9c4030f59 *Implement attribute SPELL_ATTR_NEGATIVE_1
*Remove unneeded hacks from SpellMgr::_isPositiveSpell
*Missing ! in prev commit.

--HG--
branch : trunk
2010-01-10 13:48:57 +01:00
QAston
8e9d2cdf01 Update aura system:
* Change system logic - unify Auras, AreaAuras and PersistentAreaAuras:
  * Aura has now its owner - which is the WorldObject, which applies aura (creates AuraApplication object) dependant on aura radius, and effect type
  * Owner can be Dynobj (DynObjAura class) for PersistentAreaAuras, or Unit (UnitAura class) for Area and nonArea auras
  * Aura data is shared for all units which have AuraApplication of the Aura
   * Because of that AuraEffect handlers , and periodic tick functions can't modify AuraEffect object (they are const now)
  * Remove spell source and AreaAuraEffect classes
  * Add AuraEffect::UpdatePeriodic function, to allow periodic aura object modification (target independant)
  * Add AuraEffect::CalculateAmount and AuraEffect::CalculateSpellMod function, to allow non-default amount calculation
  * AreaAura updates are done in owner _UpdateSpells cycle
  * Since now you don't need to wait an aura update cycle to get area aura applied on it's correct target list
  * And you can access area aura target list
  * Add basic support for aura amount recalculation
  * Save recalculation state and base amount of auras to db
  * Add AuraEffect::CalculatePeriodic function to determine if aura is periodic, and to set correct tick number after aura is loaded from db
  * Add ChangeAmount function in addition to SetAmount function, to allow easy reapplication of AuraEffect handlers on all targets
  * Sort aura effect handlers in SpellAuras.cpp and .h by their use
  * Add check for already existing aura of that type to some AuraEffect handlers, to prevent incorrect effect removal
  * SPELL_AURA_CONVERT_RUNE and MOD_POWER_REGEN and MOD_REGEN hacky handlers are now implemented correctly
  * Send aura application client update only once per unit update - prevent unnecesary packet spam
 * Fix ByteBuffer::appendPackGUID function - it added additionall 0s at the end of the packet
 * Fix memory leak at player creation (not deleted auras)
 * Updated some naming conventions (too many to mention)
 * Added Unit::GetAuraOfRankedSpell() function
 * Remove procflags on aura remove, use Aura::HandleAuraSpecificMods instead
 * Added functions to maintain owned auras (GetOwnedAuras, GetOwnedAura, RemoveOwnedAura, etc)
 * Implement AURA_INTERRUPT_FLAG_LANDING
 * Implement EffectPlayerNotification (thanks to Spp)
 * Remove wrong aura 304 handler
 * Add better handler for death runes
 * Remove unnecesary variables from DynamicObject class, and cleanup related code, link dynobj duration with aura
 * Add GetAuraEffectTriggerTarget function in CreatureAi for special target selection for periodic trigger auras used in a script
 * Add many assert() procection from idiots using some functions in wrong way
 * I am to lazy to write here anything more
Thanks to Visagalis for testing this patch
PS: Do not make patches like this, please

--HG--
branch : trunk
2010-01-10 01:23:15 +01:00
_manuel_
d4228470e4 Fixed typo by Corfiik. Now talent Tidal Waves should work.
--HG--
branch : trunk
2010-01-08 13:12:49 -03:00
Spp
7fff2a72a1 Fix Essence of Wintergrasp apply conditions removed in 3.2.2 upgrade
--HG--
branch : trunk
2010-01-07 07:36:49 +01:00
p0wer
17e4fbd4ad Make the core boot alot cleaner. Fix some formating. Make custom attributes for spells show a bar and how much they are loading.
Overall fix 99% of display issues while core is booting.

--HG--
branch : trunk
2010-01-01 14:19:29 -06:00
XTZGZoReX
2159602f27 * Remove useless CheckDB functionality. This does not belong in core in any shape or form.
--HG--
branch : trunk
2009-12-29 18:25:21 +01:00
p0wer
744c514b89 Fix Tidal Waves proc amount. After casting (Lesser) Healing Wave twice the buff will be removed.
--HG--
branch : trunk
2009-12-28 21:09:16 -06:00
n0n4m3
a5110c3382 Fixed spell Ebon Plague, byThemris.
--HG--
branch : trunk
2009-12-26 14:05:55 +01:00
Brian
eee8e179a1 * Commented useless debug output for spell_script_target and
* spell_target_position. If someone REALLY wants to see which ones are
* missing, they can uncomment them for a debug compile.
* Can finally start the core in debug mode and get useful data...

--HG--
branch : trunk
2009-12-21 16:28:57 -07:00
Brian
6b9d05c315 * Commented out a useless debug line for spell chain data since it is read
* from DBC and can't be fixed with the current way the core handles
* spell chains

--HG--
branch : trunk
2009-12-21 14:32:07 -07:00
n0n4m3
9f40c92fb4 Restore patch: No Fly Zone using Spell
--HG--
branch : trunk
2009-12-20 18:02:57 +01:00
n0n4m3
772cf54fb5 Update Spell code for 322a. Part 2
--HG--
branch : trunk
2009-12-17 12:23:01 +01:00
spp
5647f54e0f Fly aura removal by No Fly Zone spell when it finish, not when it's unapplied. Closes #633
--HG--
branch : trunk
2009-12-04 03:43:22 +01:00
tartalo
d7262a6298 Implement No Fly Zone using Spell, by Spp. Needs db support. Closes #494
--HG--
branch : trunk
2009-12-01 11:43:57 +01:00
Kudlaty
223d7d8116 Apply #456
Removed Essence of Wintergrasp from OutdoorPvP and implementation using the spell system.
This will affect Wintergrasp and all Northrend zones, dungeons and raids.
Note: need database support.
Patch by Spp

--HG--
branch : trunk
2009-11-27 03:16:49 +01:00
maximius
654519d1a6 *Some cleanup (mostly whitespace changes)
--HG--
branch : trunk
2009-11-20 19:11:28 -08:00
maximius
7ad284bd33 *Some cleanup.
--HG--
branch : trunk
2009-11-19 03:53:49 -08:00
maximius
963a6c14f1 *Cleansing Totem Pulse at cast, thanks lobuz
--HG--
branch : trunk
2009-11-17 20:09:01 -08:00
maximius
ce0f37bed3 *Correct Divine Storm heal, thanks lobuz
--HG--
branch : trunk
2009-11-17 19:28:36 -08:00
Anubisss
3e14909be5 *Ovverride value of Heroism's excludeCasterAuraSpell, because DBC has crap(0) value(interesting that Bloodlust has correct value).
*This fix the bug that Heroism doesn't cast Exhaustion to the target.

--HG--
branch : trunk
2009-10-22 20:35:32 +02:00
maximius
3f338cc1c3 *Massive cleanup redux.
--HG--
branch : trunk
2009-10-17 16:20:24 -07:00
maximius
e585187b24 *Backed out changeset 3be01fb200a5
--HG--
branch : trunk
2009-10-17 15:51:44 -07:00
maximius
26b5e033ff *Massive cleanup (\n\n -> \n, *\n -> \n, cleanup for(...) to for (...), and some other cleanups by hand)
*Fix a possible crash in Spell::DoAllEffectOnTarget

--HG--
branch : trunk
2009-10-17 15:35:07 -07:00
maximius
ad8aed5c0c *Allow Wintergrasp Spirit Healers to cast their spell, by manuel
--HG--
branch : trunk
2009-10-16 13:01:36 -07:00
maximius
b4c7a2514d *Blackfathom Deeps - Event: Aku'mai, by Tartalo
*Split Personality Achivement, by Destalker
*Halls of Lightning Fixes, by Destalker
    Volkhan fixes + Achievement
    Ionar Fix - without this he resets each time he is invisible, spamming sparks
    Arcing Burn - should be a debuff (and stackable, stackable part NYI :/)
*Naxxramas - Thaddius - the aura shall affect only the character without the proper aura, by Trazom
*Naxxramas - Kelthuzad - some timer adjustments (may need verification or tweaking) by Cass
*Merges by Stryker, thanks to all authors and testers.
[8458] Re-implement SPELL_AURA_MOD_TARGET_ARMOR_PCT in more porper way for weapon dependent cases. Author: VladimirMangos
[8459] Avoid mutiply apply weapon dependent armor penetration bonus for each weapon. Author: VladimirMangos
[8529] check rune cost only if spell has PowerType == POWER_RUNE. Patch provided by yavi. Author: Ambal
[8532] Fixed situation where some items like 42947 were not giving spell power bonus. By: Ambal
[8533] Not remove timed quest and correctly fail when time runs out. Add function to remove timed quest instead of direct access to set. Author: NoFantasy
[8536] Fixed spell 62776. By: Ambal
[8539] Check pet aura range at area aura update. By: Ambal
[8546] Implement battleground bonusweekends call to arms. Also fix typo in auctionmgr. Author: balrok
[8547] Implemented scriptcall: CorpseRemoved(uint32 & /*respawnDelay*/) it will be called when the corpse of the scripted creature get's removed, it's possible to adjust the next respawn inside the script. Author: balrok
[8561] Replace another auras code call by explicit code
[8566] avoid singleton-lock when accessing BattleGroundMGR::isBGWeekend() Proposed by vladimir. Comitter: balrok

--HG--
branch : trunk
2009-10-09 20:48:55 -07:00
maximius
36a2633f5d *[Fix] fly in Northend without Cold Weather Flying if summoned, by Spp
--HG--
branch : trunk
2009-09-23 00:45:47 -07:00
root@trinity
b07aba2513 * Changed the logging for missing spell_script_target / spell_script_position
* entries in DB to "debug" level.
* Set the default level for DBLogLevel in trinitycore.conf.dist to 2 "detail"

--HG--
branch : trunk
2009-09-16 13:16:42 -06:00
maximius
cd1a9a98c4 * [8456] Implement area check for SPELL_ATTR_EX6_NOT_IN_RAID_INSTANCE Author: VladimirMangos
--HG--
branch : trunk
2009-09-11 12:57:21 -07:00
maximius
960099efdb *Add back Themris' cleansing totem patch, accidentally removed in r4816
--HG--
branch : trunk
2009-09-10 09:25:32 -07:00
megamage
596d1714d4 *Fix a bug that druid's flight form is not removed after entering wintergrasp.
--HG--
branch : trunk
2009-09-04 09:36:38 -05:00
megamage
9d161ff757 [8449] Deprecate healing/damage item mods and merge internal data in to spell power. Author: VladimirMangos
* Report at loading about deprecated ITEM_MOD_SPELL_HEALING_DONE and ITEM_MOD_SPELL_DAMAGE_DONE
      and drop support code.
    * Merge healing/damage base spell bonus fields and function to spell power field/function.

--HG--
branch : trunk
2009-09-02 18:11:11 -05:00
megamage
dd72b5524c [8426] Use upper/lower iterator pairs as result instead 2 function calls. Author: VladimirMangos
--HG--
branch : trunk
2009-08-27 20:27:55 -05:00
megamage
eeb18e51bb *Correctly process more movement packets. Author: VladimirMangos
--HG--
branch : trunk
2009-08-27 20:14:50 -05:00
megamage
0175da87e4 *Handle some spell specific which is both food and drink. Source: Mangos
--HG--
branch : trunk
2009-08-24 20:17:33 -05:00
megamage
8871c2952a *Some better check of well-fed buff. Source: Mangos
--HG--
branch : trunk
2009-08-24 19:12:22 -05:00
megamage
1ee90e1022 *Update vehicle system. Make vehicle a seperate class from creature.
--HG--
branch : trunk
2009-08-23 22:09:43 -05:00
megamage
e231bb6020 *Seduction should have diminish fear/blind. By Themris. Thanks to Them.
--HG--
branch : trunk
2009-08-23 11:37:06 -05:00
megamage
bfb4ec311d *Fix a typo in proc flag. By thenecromancer
--HG--
branch : trunk
2009-08-23 11:33:00 -05:00
megamage
0b06baee4d *Update rules of aura stack.
--HG--
branch : trunk
2009-08-23 10:22:58 -05:00
megamage
dee4a9fd87 *Update flame leviathan script.
--HG--
branch : trunk
2009-08-23 01:08:09 -05:00
megamage
b35fe879ad *Some update of spell target selection.
--HG--
branch : trunk
2009-08-23 00:46:21 -05:00
megamage
9897816944 *Do not allow to use flying mount in wintergrasp.
--HG--
branch : trunk
2009-08-21 21:53:58 -05:00
megamage
648413ae0d *Set summontype 647 as type_totem for spell 52893
--HG--
branch : trunk
2009-08-17 23:09:17 -05:00
megamage
d205ff9e06 [8377] Resolve some spell_area problems in GM and non-GM mode. Author: VladimirMangos
* Make spell 40216 and 42016 casted/remove at aura 40214 apply/remove.
      And drop related spell_area possible existed data.
    * In general restore apply area limitations to spell casting in GM mode.

--HG--
branch : trunk
2009-08-17 16:34:02 -05:00