Commit Graph

20912 Commits

Author SHA1 Message Date
ariel-
3670779e8e Core/Creatures: Minor HasSpell method cleanup
Cherry-picked improved from 5734788c02
2018-03-19 17:29:13 -03:00
ariel-
d88b50a6ad Core/Spells: fix another regression with arcane missiles being marked positive
Closes #21670
2018-03-19 17:28:04 -03:00
ariel-
f87da3a306 Scripts/ICC: use script searchers instead of saving list of creature pointers
Closes #21644
2018-03-19 14:59:26 -03:00
ariel-
07e42f7d41 Core/Spells: always initialize hitinfo aura
Ref 437c5c7b9d
2018-03-19 00:45:02 -03:00
ariel-
6eb122792c Scripts/Spells: fix Seaforium Blast script crash
Closes #21663
2018-03-18 16:08:36 -03:00
ariel-
437c5c7b9d Core/Spells: fix delayed hit aura crash
Closes #21664
2018-03-18 15:36:37 -03:00
ariel-
1c8d9af084 Core/Spells: autogenerate miss proc for spells with auras with hit chance -100
Closes #21629
2018-03-16 12:34:42 -03:00
ariel-
a35d0a5f56 Core/Entities: completely remove 60% melee miss cap as there is no proof of its existence
- Auras modifying hit chance should have full effect now

Ref issue #21629
2018-03-16 12:28:22 -03:00
ariel-
9e0a343f72 Core/Entities: don't skip immunity checks for positive spells
Closes #21626
2018-03-15 02:59:08 -03:00
ariel-
a60728b3d2 Core/Conditions: reserve sourcetype value 2018-03-15 02:21:48 -03:00
Shauren
ddd60a948c Buildsystem: Separate strict database type checks from TRINITY_DEBUG/WITH_COREDEBUG option 2018-03-14 20:50:54 +01:00
ariel-
9cc109fe3e Core/Player: properly clear m_items array when unequipping items from the bag
- Also cleanup weapon damage ap mult when direct destroying a equipped weapon
2018-03-14 11:57:51 -03:00
ariel-
8cf7eda8c1 Core/Entities: cleanup of weapon damage
- ScalingStatDistribution/Value (ie heirlooms): apply bonuses in all cases, some calls used nullptr (like after disarm) and item wasn't regaining them
- AP multiplier wasn't correctly reflected after unequipping a weapon
- Correctly set base damages at unequip

Closes #21610
2018-03-14 03:44:00 -03:00
ariel-
f0794fd112 Core/Entities: simplify and fix secondary damage calc
Closes #21617
2018-03-14 03:43:59 -03:00
ariel-
8e853a82cc Scripts/Kalimdor: fix crash with Gordunni Trap 2018-03-14 03:43:59 -03:00
ariel-
2828869844 Core/Spells: fix issues with delayed spells and auras
- Was losing info of delayed targets due to remove_if move-assigning targets, it needs to be saved into delayed target vector before returning from lambda
- Delayed auras applying on many targets are now handled gracefully

Closes #21609
Closes #21612
2018-03-13 13:46:25 -03:00
ariel-
7d118f05ba Core/Spells: implemented 'Weakened Spirit' mechanic in Valithria Dreamwalker
- Debuff used to prevent multiple priests chaining 40% heal buff (Guardian Spirit)
2018-03-13 12:17:33 -03:00
ariel-
b978b673a9 Core/Spell: clear buffer from spell go before broadcasting it again without predictedpower flag 2018-03-12 19:34:37 -03:00
ariel-
abb602f7c1 Core/Spells: only apply aura effects when needed. Fixes #21602 2018-03-12 19:04:00 -03:00
Gooyeth
e2ae302e2c Core/Arena: Do not distribute points if the season is not in progress (#21600) 2018-03-12 22:41:11 +01:00
ariel-
6414e456ec Core/Spells: fix Magic Rooster applying dummy aura with NO_TARGET
Closes #21597
2018-03-12 12:59:19 -03:00
ariel-
ef4b1492e1 Core/Auras: fix nopch 2018-03-12 03:24:25 -03:00
ariel-
214fd579c0 Core/Auras: fix auras apply on player when loading. Fixes Ghost aura flags and player deathstate
Closes #21472
2018-03-12 02:59:57 -03:00
ariel-
8a8c7793c4 Core/Auras: cleanly remove linked auras when unapplying effect
Closes #21588
2018-03-12 02:58:58 -03:00
ariel-
ac97655063 Core/Spells: Fix some issues with channeled spells and aura duration mods
Closes #21584
2018-03-12 02:31:17 -03:00
jackpoz
f555a67bf8 Core/SmartScripts: Code cleanup 2018-03-11 21:01:53 +01:00
Killyana
5ad38c31b0 Core/SAI: Add event_parm5 "player only" for EVENT_OOC_LOS and EVENT_IC_LOS
Closes #21497
2018-03-11 18:46:07 +01:00
Killyana
8f0af67bcb Core/GameObject: Fix linked traps not being despawned properly and remove deprecated code
Closes #20159
2018-03-11 18:07:44 +01:00
Keader
a891eb364e Core/Unit: Guardians no longer enter combat before reaching the target (#19816) 2018-03-11 13:23:23 +01:00
Treeston
43491ba7f4 Scripts/Naxxramas: Fix an issue that could cause Sapphiron to stop using Drain 2018-03-11 13:05:41 +01:00
ariel-
02f1399fde Core/Entities: fix creatures ignoring immune flags. Closes #21578 for real 2018-03-10 20:51:14 -03:00
ariel-
f7869ad38b Core/Spell: fix LoS checks for GameObject spells
Closes #21580
2018-03-10 20:25:50 -03:00
ariel-
7f947646f9 Core/Spell: fix SendSpellMiss requiring caster Unit 2018-03-10 19:51:36 -03:00
ariel-
d6b9f148a7 Core/Spell: fix target checks
- Aura will be applied at last moment possible (after damage) to prevent regressions on #18395
- Partial revert of 9b38a6352c as it wasnt handling correctly checks without spells

Closes #21578
Closes #21579
Closes #21581
2018-03-10 19:40:19 -03:00
sirikfoll
e7e46b2a82 Scripts/Spells: Quest King of the Mountain
Added missing jump jets and battle standard visuals
Added allowed area conditions for the vehicle
Fixed Jumpbot's attack spell (thanks @keader for fixing the proc)
2018-03-10 13:31:49 -03:00
Shauren
901eed7828 Core/CrashHandler: Fixed generating crash logs from CRT debug assertions
(cherry picked from commit abdf6479dd)
2018-03-10 15:51:57 +01:00
ariel-
078b621c74 Core/Packet: nopch 2018-03-10 04:01:17 -03:00
ariel-
bc73251f3b Misc: fix bad copyright header 2018-03-10 03:57:32 -03:00
ariel-
1a2c6f6545 Scripts/Spells: fix Hypothermia 2018-03-10 03:55:35 -03:00
ariel-
0c2a6dee07 Core/Spell: fix spell visual for other players
- Ported SMSG_SPELL_GO and SMSG_SPELL_START to new packet system
2018-03-10 03:55:14 -03:00
ariel-
4ca9d6469d Core/Spells: register and apply individual aura effects on hit handler
- Remove area aura processing from spell system, they're fully handled by aura owner update now

Closes #21577
2018-03-10 00:58:48 -03:00
ariel-
d46f36f773 Core/Spells: tweak 'neutral' spell positivity
- Fixes Mind Control dummy self aura appearing as a debuff
2018-03-10 00:57:19 -03:00
ariel-
bd3530dd1f Core/Spells: move m_preCastSpell logic to scripts
- Bad name because it was actaully executed after effects
2018-03-10 00:55:24 -03:00
ariel-
94333b734d Core/Misc: nopch fixes, hopefully the last 2018-03-09 16:14:42 -03:00
ariel-
334fcbf40f Core/AI: nopch continued 2018-03-09 15:36:20 -03:00
ariel-
4669267633 Core/Auras: nopch reloaded 2018-03-09 15:22:29 -03:00
ariel-
8dc91cf0fa Core/Auras: yet another nopch 2018-03-09 15:16:18 -03:00
ariel-
4527995b66 Core/Misc: another nopch 2018-03-09 15:12:02 -03:00
ariel-
86e20f66b2 Core/Spells: more nopch 2018-03-09 15:03:56 -03:00
ariel-
ecea2d6265 Core/Auras: nopch fixes 2018-03-09 14:49:44 -03:00