Commit Graph

163 Commits

Author SHA1 Message Date
Ramusik
5908b2af47 Fixed Starfall: root effect shouldn't supress the starfall effect 2011-04-10 08:46:47 +03:00
Shauren
2f79b0f266 Core: Removed all double (and more) empty lines 2011-03-21 10:52:14 +01:00
Shauren
e5347a3bda Core: Fixed warnings:
C4100: 'variable' : unreferenced formal parameter
C4701: potentially uninitialized local variable
C4389: '!=' : signed/unsigned mismatch
C4245: 'argument' : conversion from 'X' to 'Y', signed/unsigned mismatch
2011-03-08 16:42:00 +01:00
Machiavelli
e1ac75afe2 Core/Spells: Proper implementation of SPELL_EFFECT_PLAYER_NOTIFICATION (131) - should send SMSG_PLAY_SOUND with EffectMiscValue as soundId.
Research by Kaelima
2011-03-07 21:13:18 +01:00
GWRde
22703bc58d Core/Spells: Fixed Glyph of Shadow Word: Pain 2011-03-07 19:36:34 +01:00
Shauren
36f848a4c2 Scripts/Icecrown Citadel: Only one Mutated Abomination can exist during Professor Putricide encounter
Scripts/Spells: Added blizzlike error messages for certain spells
Scripts/Items: Removed obsolete scripts
2011-03-04 23:53:11 +01:00
Shauren
7120f1eff8 Core/Spells:
* Implemented on CheckCast spell script hook
* Added possibility to send SPELL_FAILED_CUSTOM_ERROR and added enum with all possible options for it

Scripts/Spells:
* Added example script for CheckCast hook with SPELL_FAILED_CUSTOM_ERROR (profession research and Book of Glyph Mastery)
2011-03-04 21:19:43 +01:00
Machiavelli
a9582964d3 Core/Vehicles: Make the vehicle system more aura driven. Get rid of redundant checks and update relevant data.
Closes #805
2011-03-04 21:17:06 +01:00
Machiavelli
3ac80ee3a4 Core/Vehicles: Correct usage of npc_spellclick_spells instead of blatant hacks for vehicle entry.
Note: This may break a few vehicles, but only due to the absence of proper, non-hackish data.
2011-02-26 23:00:09 +01:00
Machiavelli
102c089ab8 Scripts/Kologarn:
- Correct target limitation for Focused Eyebeam
- Correct target selection and limitation for Stone Grip
** Fixes random teleports to the "safe spot" caused by aura unapply when that player wasn't intended as target.
** Stone Grip will only target the main tank if there's no one else in range.
- Despawn Rubbles on encounter reset/complete
- Use elegant MotionMaster::MoveJump instead of NearTeleportTo when releasing Stone Grip target

DB/NPC Templates:
- Add civilian flag for Armsweep Stalker and Rubble Stalker

Other:
- Fix 2011_02_23_2_world_conditions.sql to comply to standards
- Cleanup affected code
2011-02-23 18:17:20 +01:00
Machiavelli
480517c3be Scripts/Ulduar: Kologarn:
- Correct target selection of Stone Grip
- Correct functionality of Stone Grip (absorb aura, stun, damage, vehicle join, correct removal of the aforementioned when needed, +teleport to platform)
- Blizzlike casters for certain spells, which led to merging arms AI to KologarnsAI.
- Blizzlike timer for Stone Grip
- Fix Rubble spawn on arm death
2011-02-22 04:46:13 +01:00
Machiavelli
e07e20ffca Core/Log: Implement log masks for debug log level, to allow selective debug output. Update your worldserver.conf. 2011-02-20 20:16:34 +01:00
QAston
d18193e52d Core/DynamicObjects: Change the way how dynamic objects are bound to their owners, fixes some crashes in Aura::GetOwner. 2011-02-04 00:27:43 +01:00
johnholiver
ce4aca9011 Core/Spells: Move Glyph of Smite code to a better location.
Signed-off-by: Shauren <shauren.trinity@gmail.com>
2011-01-28 11:22:52 +01:00
leak
137b079eea Core: Generic cleanup (tab2spaces/trailing whitespace removal) 2011-01-26 01:03:35 +01:00
Manuel
19634e7fce Core/ZoneScript: Implemented ProcessEvent function for units.
Signed-off-by: Manuel <manue.l@live.com.ar>
2011-01-20 12:27:08 -03:00
leak
dd751242fc Core/Spells: Better solution for exploit check (Thanks to manuel)
Readd lost changes from char db type cleanup
2011-01-20 03:06:51 +01:00
leak
40af92dd66 Core/Spells: Stop exploit that allowed looting despawned gameobjects by packet manipulation. 2011-01-18 20:02:28 +01:00
Machiavelli
d399daab59 Core/Quests: Resolve ambiguity between QUEST_STATUS_COMPLETED and rewarded state by implementing QUEST_STATUS_REWARDED. The latter is not used in the database explicitly, only in the core. This is to prevent overhead by iterating over the rewarded quests storage multiple times.
All relevant upper level code has been updated accordingly to the best of my ability.
2011-01-13 23:06:59 +01:00
Shauren
8d59953f93 Scripts/Icecrown Citadel
* Call EnterEvadeMode before teleporting players to entrance - prevents players being stuck in combat
* Fixed Gaseous Blight stacking damage
* Properly initialize phase for Professor Putricide when entering combat
* Fixed Blood Nova and Boiling Blood abilities of Deathbringer Saurfang
2011-01-12 22:50:51 +01:00
Manuel
5cf76896eb Core/Battleground: Implemented blizzlike script for Isle of Conquest, written by gyullo and me, based on Socolin's and Josh's patch -BIG THANKS TO THEM-
Anyway the map is not yet playable, there are issues not related with the script.

I also want to thanks to QAston, linencloth, Shauren and Machiavelli to be so patient with my questions.
2011-01-09 00:00:08 -03:00
Machiavelli
dc3d6a2f23 Remove redundant code from 1487ebedaa 2011-01-07 19:13:19 +01:00
Machiavelli
c65e3822a2 Fix build from 06314c9387
closes #99
2011-01-06 22:45:07 +01:00
Sarjuuk
06314c9387 Core/Spells: Implemented Pygmy oil use effect
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
2011-01-06 21:40:32 +01:00
Ottowayne
7aa85728fc Core/Spells: Dummy for spell 51961; support for Quest 12532 & 12702
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
2011-01-06 20:22:39 +01:00
Ottowayne
1487ebedaa Core/Spells: Dummy for spell 47703 (Unholy Union) for quest 12126
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
2011-01-06 20:14:13 +01:00
sarjuuk
0cf89f635f Core/Spells: Starfall skips targets in stealth, invisibility or not in LoS
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>

Also minor codestyle fixes from previous commits
2011-01-06 19:57:36 +01:00
Ottowayne
b0c559e704 Core/Spells: Fix Spell 54577 - Support for Quest 12828
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
2011-01-06 19:33:22 +01:00
Anubisss
80da87f015 Add one more check to EffectDispel.
Passive auras are not dispelable.
This fixes a bug like spell Omen of Clarity (16864) can be dispelled by Purge (370) if you have a non passive aura like Mark of the Wild (1126).

Signed-off-by: Anubisss <anubisss210@gmail.com>
2011-01-02 22:43:36 +01:00
Shauren
9c0cd63e93 Core/Scripts: Added wrapper method for despawning creatures DespawnOrUnsummon 2011-01-02 21:33:37 +01:00
Machiavelli
957c69de83 Update copyright note for 2011.
Happy new year.
2011-01-01 15:01:13 +01:00
Machiavelli
bdc47053cc Core/Spells: Partial fix spells 62056, 63985 (Stone Grip Force Cast - Part of Kologarn encounter), underlying AuraEffect::HandleAuraControlVehicle will no longer prematurely return.
--HG--
branch : trunk
2010-12-27 14:53:47 +01:00
Machiavelli
d951407822 Revert 0a95c34021 (thanks QAston for talking sense into me)
--HG--
branch : trunk
2010-12-27 11:06:53 +01:00
Machiavelli
299118cd3a Remove missing lines from previous commit, thanks click for pointing out.
(WTB Coffee)

--HG--
branch : trunk
2010-12-27 09:49:38 +01:00
Machiavelli
d69a1c3629 Core/Spells: Fix SPELL_EFFECT_FORCE_CAST(140), SPELL_EFFECT_FORCE_CAST_WITH_VALUE(141). These should force the target to cast a certain spell, not serve as a proxy for the original caster to cast another spell.
--HG--
branch : trunk
2010-12-27 09:21:08 +01:00
Machiavelli
4a169412b7 Core/Spells: Implement 65594 (Cancel Stone Grip - Used in Kologarn encounter) spell
--HG--
branch : trunk
2010-12-27 09:19:06 +01:00
linencloth
efbc73d025 Core/Player: Split RemoveQuest into 2 separate functions
--HG--
branch : trunk
2010-12-26 21:34:08 +01:00
linencloth
6b58081e63 Core/QuestStatus: Fix EffectQuestClear, also clear rewarded quests again
--HG--
branch : trunk
2010-12-26 21:18:22 +01:00
Shauren
79070ca820 Scripts/Serpentshrine Cavern: Fixed "The Lurker Above" achievement and removed hacks for the event
--HG--
branch : trunk
2010-12-26 16:35:29 +01:00
linencloth
b150172521 Core/QuestStatus:
- Separate rewarded quests from active quests, and store them in a new table to reduce database size
- Drop the no longer needed `rewarded` column from character_queststatus for smaller table size
- Prevent filling the database with dropped quests
  - Delete useless records
- Implement queststatus save "queues" instead of states
- Minor optimizations

WARNING: Backup your database!

--HG--
branch : trunk
2010-12-26 04:16:18 +01:00
click
b181ba21d9 Core: Fix a few warnings here and there.
--HG--
branch : trunk
2010-12-25 06:28:38 +01:00
Machiavelli
d587948a0f Core/Spells: Use a workaround for Grab Crate, cast triggered spell with original caster as caster instead of target. Previous approach was prone to out of range errors.
Spell will now correctly restore 25 Pyrite energy (assuming aura 62495 is present to trigger the initial handler)

--HG--
branch : trunk
2010-12-25 03:18:21 +01:00
Shauren
928443d899 Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
--HG--
branch : trunk
2010-12-23 23:25:44 +01:00
Machiavelli
f3dd337c6a Core/Spells: Fix Glyph of Felhunter
Author: Lopin

--HG--
branch : trunk
2010-12-23 19:03:28 +01:00
Shauren
0f3b9019a8 Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
--HG--
branch : trunk
2010-12-22 21:25:23 +01:00
Shauren
7b4e1c6387 Core/ObjectMgr: Static members are no longer accessed through singleton
--HG--
branch : trunk
2010-12-22 20:23:47 +01:00
Shocker
446c300505 Core/Spells: Small cleanup in SpellEffects, spells always have caster
--HG--
branch : trunk
2010-12-22 20:18:34 +02:00
Shocker
42304c0b25 Core/Spells: Implement SPELL_EFFECT_UNTRAIN_TALENTS, thanks to Heisenberg, closes issue #5238
--HG--
branch : trunk
2010-12-22 20:14:30 +02:00
Machiavelli
baff745be1 Core/Spells: Fix Improved Felhunter mana energize part.
Based on code by Karolis.Rudzevicius
Fixes issue #2125
Fixes issue #2109

--HG--
branch : trunk
2010-12-20 00:35:11 +01:00
linencloth
59da698189 Core: Rename spell attributes, use more general names
--HG--
branch : trunk
2010-12-19 05:15:47 +01:00