Commit Graph

1779 Commits

Author SHA1 Message Date
jackpoz
510bb30b2c Scripts/Misc: Fix issues reported by static analysis 2016-03-06 16:11:55 +01:00
sirikfoll
c4e4ee3ae1 Core/Scripts: Fixed Yogg-Saron Portals
Closes #16390
Closes #16708
2016-03-04 20:45:28 +01:00
jackpoz
31cd082833 Scripts/Ulduar: Fix crash
Change an assert to a NULL check on Flame Leviathan vehicle kit, it can be NULL on map unload.
Close #16662
2016-02-27 12:02:32 +01:00
treeston
1fbe7979ff Nobody saw that. 2016-02-24 15:47:57 +01:00
Treeston
4e4b2b9a13 Merge pull request #16644 from Treeston/3.3.5-customcharmai
Core/UnitAI: Rework creature-controlled player behavior.
2016-02-24 13:39:31 +01:00
treeston
2f14664340 Core/UnitAI: Rework creature-controlled player behavior.
- Removed hacked control mechanism, use proper PlayerAI instead
- Port old hacky code to new SimpleCharmedPlayerAI class
- Make adjustments to aforementioned code to fix bugs:
    - Properly clean up movement after charm ends
    - Only try to attack a target if charmer is engaged in combat
2016-02-23 13:41:56 +01:00
Naios
9e43365b3d Core/Scripts: Split the huge scriptloader into smaller pieces
* Each subdirectory contains it's own translation unit now
  which is responsible for loading it's directory
* Improves merging & decoupling between 3.3.5 <-> 6.x
* Removes unused Battleground loader
* Ref #15671

(cherry picked from commit 5534915f74)
2016-02-22 16:25:54 +01:00
treeston
c70e3e31a7 Merge remote-tracking branch 'sirikfoll/despawnAtEvade' into 3.3.5 (PR #16528) 2016-02-14 19:53:37 +01:00
sirikfoll
a36d78526d Core/Scripts port _DespawnAtEvade functionality to 3.3.5 branch
Implement _DespawnAtEvade  functionality to boss Lich King
2016-02-12 15:02:28 -02:00
treeston
a23ccc1b83 Scripts/Naxxramas: Fix an edge case crash in Gothik. Closes #16575. 2016-02-12 12:18:17 +01:00
treeston
cfed2d7a3d Merge remote-tracking branch 'Eliminationzx/FixJumpDestOrientation' into 3.3.5 (PR #16450) with some minor CS adjustments 2016-02-10 17:41:19 +01:00
Treeston
2c437ff8ec Merge pull request #16491 from Treeston/3.3.5-boundarycheck
[3.3.5] Add target boundary check to BossAI CanCreatureAttack call
2016-02-10 17:23:43 +01:00
Elimination
ff80f249a7 Fix jump dest orientation 2016-02-10 20:25:29 +07:00
treeston
19ed18c881 AI/BossAI: Make creature never chase targets that are out of bounds
- Add missing const attribute on CheckBoundary arg.
- Prevent AI from attacking a target that is out of bounds. This prevents exploids such as killing Gluth/Deathbringer from out of bounds.
2016-02-09 22:46:57 +01:00
Rushor
c560cb0a0c Scripts/Northrend: Knockbackimmunity Cleanup 2016-02-06 18:17:16 +01:00
joschiwald
b259d5c2bc Scripts: addition to 8b6954e81b
Closes #16466
2016-02-06 17:26:27 +01:00
joschiwald
8b6954e81b Core/Gossips: added some sanity checks to prevent duplicate interaction 2016-02-04 20:43:28 +01:00
treeston
815f43be7a Scripts/UtgardeKeep: Bonus Ingvar the Plunderer fixes to reset behavior. There should no longer be weirdness if a reset happens during the RP phase. 2016-01-31 15:14:01 +01:00
treeston
c829fc7de4 Scripts/UtgardeKeep: Ingvar updates:
- Roar at start of phase two
- Ingvar no longer does a weird move-jump towards his target when resurrecting
- Fixed a duplicate yell on phase one end
2016-01-31 14:27:18 +01:00
Keader
36648d1079 Fix Kinetic Bomb stuck after knockback effect. 2016-01-28 17:20:41 -03:00
treeston
f5bd7b903c Coverity fix for CID 1349782. 2016-01-23 13:30:07 +01:00
treeston
cebdf03349 Fix warning. 2016-01-20 23:20:18 +01:00
joschiwald
ea38a7d95b Scripts/ICC/Teleporter: moved gossips to db 2016-01-20 00:32:30 +01:00
treeston
e8a79737a5 Merge branch '3.3.5-horsemen' into 3.3.5-base (PR #16194) 2016-01-19 21:39:23 +01:00
treeston
d23ef5d6d0 Merge branch '3.3.5-gothik' into 3.3.5-base (PR #16142) 2016-01-19 21:38:24 +01:00
treeston
b945d01ee5 Instance boundary follow-up:
- Stop tools from complaining about leaks.
- Also, list -> vector.
- Fix an ambiguous constructor warning.
- Fix a bug with Gormok and Sindragosa (Fixes #16280).
2016-01-18 18:08:15 +01:00
treeston
2d7aa15fc0 Scripts/Naxxramas: Four Horsemen rework:
- Rewrite pretty much the entire encounter code
- Get rid of ugly define ugliness
- Sniffed waypoints
- Blizzlike timings
- Missing emotes
2016-01-15 20:17:48 +01:00
treeston
78228b59ab Scripts/Naxxramas: Gothik the Harvester rework:
- Move TeleportTo hack to proper spell casts
- Add missing lines to boss
- Fix add spawn timings
- Fix visuals
- Fix logic for gate opening
- Fix add aggro behavior
- Fix add casting AI
- Fix some other stuff I probably forgot
2016-01-13 16:27:35 +01:00
treeston
5b8b8c6530 Merge branch '3.3.5-bossboundary' into 3.3.5-base (PR #16089) 2016-01-13 15:33:17 +01:00
treeston
2da458c56d Scripts/Instances: Complete rewrite of the boundary system.
- Migrate boundary logic to Maps/AreaBoundary instead of having it sit in InstanceScript (to possibly allow use for other purposes).
- Implement the first five boundary types in Maps/AreaBoundary.cpp.
- Add boundary checks to Creature's update logic
- Add boundary data for all Northrend raids
- Add boundary initialization structures and methods to InstanceScript
- Modify EnterEvadeMode signature. It now passes a value from the EvadeReason enum as parameter to allow special casing depending on evade reason
- Remove previous (weird) boundary code that had them linked to GO spawns
2016-01-12 22:24:23 +01:00
jackpoz
4191bb868a Scripts/ICC: Fix static analysis issue
Fix an issue reported by static analysis
2016-01-09 21:53:53 +01:00
ShinDarth
b1a89943a2 Scripts/ICC: Fixed Professor Putricide
- closes https://github.com/TrinityCore/TrinityCore/issues/16207
2016-01-08 10:33:16 +01:00
Rushor
923a368ac7 Update copyright note for 2016 2016-01-01 12:02:33 +01:00
Killyana
13e509a622 Script/Creature: Imprisoned Beryl Sorcerer
Add missing emote state
Move the credit quest on the 5th hit instead of the 7th one
2015-12-30 02:05:24 +01:00
jackpoz
e6903fdffa Merge pull request #15852 from Golrag/icc_boss_aggro 2015-12-15 21:29:10 +01:00
treeston
54d583b0fb Scripts/Naxxramas: Instructor Razuvious rework:
- Fix missing yells
- Rearrange existing yells to match live
- Sniffed positions for adds
- Improve add respawn handling
- Make adds not fight the player for control (don't use their spells on their own etc.)
- Update adds' hotbar keys to match live (this will affect other creatures with nonsequential possess keys as well)
- Fix adds' movement when mind controlled, they no longer move automatically when right-clicking (this affects all mind-controlled creatures)
- Blizzlike timers
2015-12-14 20:11:57 +01:00
jackpoz
187e45d24b Merge pull request #15910 from Treeston/3.3.5-maexxna 2015-12-08 12:40:04 +01:00
jackpoz
3267c90102 Core/Unit: Add Unit::KillSelf() overload
Add Unit::KillSelf() function as overload of Unit::Kill(this) . Use KillSelf() whenever the killer and the victim are the same to clearly state the Unit is going to kill itself.
2015-12-07 20:06:02 +01:00
treeston
5dd6163387 Scripts/Naxxramas: Maexxna cleanup:
- Improved Web Wrap target selection
- Added missing text
- Cleanup of web wrap positioning - two players will never be flung to the same position (25-man)
- Further improvement to web wrap spawn behavior - targetable web wrap now only spawns after the player has finished being flung to the respective position (blizzlike)
- Add additional web wrap positions (sniff)
2015-11-30 20:18:55 +01:00
jackpoz
6e296ddaa2 Scripts/EyeOfEternity: Fix crash
Fix crash happening when a player would kill a Melee npc on the disks during Malygos fight and mount it before it ended the waypoint path.
Close #15900
2015-11-26 21:47:50 +01:00
MitchesD
3b90b0368a Core/Misc: fix warning and misc codestyle fixes 2015-11-26 19:28:53 +01:00
treeston
bf99630399 Scripts/Naxxramas: Thaddius follow-up:
- Reduce initial spawn timer on the encounter from 30 seconds to 5 seconds
- Rearrange respawn logic to fix the "petrified" visual from not showing properly
- Fix a potential infinite respawn loop that could prevent the encounter from initializing properly (fixes and closes #15898)
2015-11-26 18:57:15 +01:00
Golrag
ce90e30a80 Scripts/ICC: * Bosses now enter when in aggro range.
* Removed some of the MoveInLineOfSight calls
* Added more AreaTriggerScripts
2015-11-16 16:24:10 +01:00
Carbenium
f01ef901ef Script/Naxxramas: Fix a -Winconsistent-missing-override warning reported by clang 3.6 2015-11-14 19:48:05 +01:00
tkrokli
95d6f09243 Scripts/Thaddius: Coverity scan Control flow issues (MISSING_BREAK)
Coverity scan defects CID 1339315, 1339316 and 1339317:
- CID 1339315: boss_thaddius.cpp: 542
- CID 1339316: boss_thaddius.cpp: 811
- CID 1339317: boss_thaddius.cpp: 398

Added missing break; statements.
2015-11-14 05:12:25 +01:00
MitchesD
e14e291ef6 Merge pull request #15523 from Treeston/3.3.5-thaddius
Scripts/Naxxramas: Thaddius: Complete rewrite
2015-11-12 19:46:46 +01:00
Carbenium
c5f635b689 Core/Creature: Remove duplicate call to LoadCreatureAddons in Creature::Create
* Add error log for duplicated aura entries in creature_(template_)addon
2015-11-11 00:13:43 +01:00
treeston
29feae5901 Scripts/Naxxramas: Complete rewrite of the Thaddius encounter. 2015-11-08 14:57:01 +01:00
Vincent-Michael
7d5e7102cd Core: Whitespace cleanup 2015-11-07 20:01:53 +01:00
sirikfoll
22f1d26986 DB/CORE Minor change in quest Kick, What Kick? and some codestyle
Remove the line that despawns the 'Apple' npc, this despawn is non-blizzlike and breaks the quest.
Thx Killyana for sql and valuable information

Closes #15480
2015-11-03 17:01:25 +01:00