Commit Graph

19310 Commits

Author SHA1 Message Date
QAston
57e78dac6b Merge pull request #11853 from Unholychick/patch-2
Done & taken procs & a few trinket fixes
2014-04-17 18:18:02 +02:00
joschiwald
8877a87c99 Merge pull request #11614 from MitchesD/kelthuzad
Scripts/Kelthuzad: move spells into spelldifficulty_dbc and cleanup
2014-04-17 02:02:51 +02:00
joschiwald
fa472c6142 Merge pull request #11787 from MitchesD/misc
Scripts/ZulGurub: clean up the old code
2014-04-17 02:01:05 +02:00
joschiwald
0a014e1431 Scripts/UtgardeKeep: fixed some issues on Ingvar the Plunderer
Closes #10859
2014-04-17 00:09:43 +02:00
Unholychick
057169c21c Fix done & taken procs
Corrects the logic for dot/hot procs and fixes spells such as althor's abacus, egg of mortal essence, black magic, spiritual attunement etc etc.
Reverts the remaining part of 8edf6247c0
2014-04-15 00:03:01 +02:00
joschiwald
533cbf20bb Core/Spells: addition to b9a62115b1 2014-04-14 21:12:05 +02:00
untaught
b9a62115b1 Core/Spells: fixed Relic of the Earthen Ring
Closes #11282
2014-04-14 19:48:13 +02:00
jackpoz
ba61ec085d Scripts/Commands: Add comment about 9d58410739 changes 2014-04-13 16:02:41 +02:00
jackpoz
9d58410739 Scripts/Commands: Fix memory leak in ".gobject add" command
Valgrind log:
 158 (104 direct, 54 indirect) bytes in 1 blocks are definitely lost in loss record 24 of 73
 at operator new(unsigned long) (vg_replace_malloc.c:319)
 by GameObjectModel::Create(GameObject const&) (GameObjectModel.cpp:152)
 by GameObject::Create(unsigned int, unsigned int, Map*, unsigned int, float, float, float, float, float, float, float, float, unsigned int, GOState, unsigned int) (GameObject.cpp:237)
 by gobject_commandscript::HandleGameObjectAddCommand(ChatHandler*, char const*) (cs_gobject.cpp:155)
2014-04-13 15:01:20 +02:00
jackpoz
dc58ec0d6c Scripts/Commands: ".modify speed" targets current Player by default
Allow ".modify speed" command to target current Player if there is no target or if the selected Unit is a Creature.
This behavior could be extended to other commands that require target Players.
2014-04-13 14:06:21 +02:00
jackpoz
a07e82530f Scripts/Commands: Fix .mmap loc wrong coordinates
Fix .mmap loc command printing swapped x and y tile coordinates
2014-04-13 13:40:42 +02:00
Shauren
e51976e17a Core/Spells: Fixed players being able to mount with all transform auras
Closes #11852
2014-04-13 01:06:46 +02:00
Warpten
17923c3c44 Scripts/Commands: Ensure gameobject template is valid from .gob add temp [...]
As per Aokrome's spamming. "Avoids false positive logs"
2014-04-12 14:45:51 +02:00
Nyeriah
870d5d9c45 [TW278] - Core/Scripts: Prevent multiple spawns of Ulag
http://www.wowhead.com/quest=1819/ulag-the-cleaver
2014-04-11 22:36:38 +02:00
MitchesD
ab602837b1 Scripts/ZulGurub: clean up the code and remove old hacks 2014-04-11 18:43:38 +02:00
jackpoz
7b9b0edb5d Core/GameObjects: Fix crash with Summoning Ritual GOs
Fix a crash happening with GAMEOBJECT_TYPE_SUMMONING_RITUAL GameObjects if a Player clicked on the GO, logged out and let another Player click on it.
Issue added in 464c0c1611
Fixes #11856
2014-04-10 20:41:34 +02:00
Warpten
335fe8e1b0 Scripts/Ruby Sanctum: Fixed Halion engaging combat outside of his Flame Ring. 2014-04-10 14:28:58 +02:00
Warpten
b36e7c0211 Scripts/Ruby Sanctum: Fixed Onyx Flamecallers not aggroing players once pathing ended. 2014-04-09 17:55:54 +02:00
Shauren
ade9c92080 Merge pull request #11847 from trickerer/SS
Core/Spells: Fixed Sweeping Strikes damage
2014-04-09 17:26:19 +02:00
trickerer
d123780b2b Fix Sweeping Strikes damage 2014-04-09 20:13:17 +07:00
joschiwald
8b8aaa06fc Core/ChatLog: handle chatlog options with extended logging system 2014-04-08 22:52:05 +02:00
jackpoz
37e6a3e1d2 Core/CrashHandler: Log GetLastError() id if no description is found
Log the System Error id returned by GetLastError() in case FormatMessage() doesn't find a proper description for that message.
2014-04-08 22:01:56 +02:00
joschiwald
92a71b45aa Merge pull request #11840 from Rochet2/AddonMessaging
Core/Chat: Fix AddonMessaging and logging
2014-04-08 21:31:01 +02:00
joschiwald
c6a4d5a1de Core/Logging: store loggers in cache correctly 2014-04-08 21:27:02 +02:00
jackpoz
a3afd4bb9d Merge pull request #11857 from Unholychick/master
Core/Spells: Fix SPELL_DAMAGE_CLASS_NONE unable to crit
2014-04-08 19:34:18 +02:00
Unholychick
7a0c2fc4f7 Fix SPELL_DAMAGE_CLASS_NONE unable to crit
Corrected logic mistake where switch fallthrough was intended (or should have been).
Fixes the following.
// Earth Shield
// Lifebloom Final Bloom
// Divine Hymn
// Item - Bauble of True Blood 10m
// Item - Bauble of True Blood 25m
2014-04-08 14:32:31 +02:00
Дмитрий
5be05913e6 .cheat god should also affect on falling damage. 2014-04-08 14:40:16 +03:00
jackpoz
8927a04253 Core/Movement: Fix LoS issue of NPCs chasing targets
Add Line of Sight checks to WorldObject::GetNearPoint(), fixing to TargetedMovementGenerator not reaching a point with valid LoS to the target and MotionMaster::MoveKnockbackFrom() knocking creatures inside walls.
Remove unused code.
2014-04-07 22:16:31 +02:00
Unholychick
7b55dcf0f8 Fix SPELL_AURA_MOD_AOE_AVOIDANCE
There is not a single spell using this aura, but now it works :)
2014-04-07 09:50:05 +02:00
Rochet2
d222a0864d Core/Chat: Fix AddonMessaging and logging 2014-04-06 15:19:15 +03:00
jackpoz
98a9a088bf Merge pull request #11836 from Unholychick/patch-1
Partially revert 8edf6247c0
2014-04-06 00:17:18 +02:00
jackpoz
5b1a28076e Scripts/Ulduar: Fix uninitialized values
Fix uninitialized values in Ulduar script reported by Valgrind.
2014-04-05 23:41:01 +02:00
jackpoz
af78f2b7c5 Core/CrashHandler: Add more informations about locals
Handle BasicType btChar and custom type std::basic_string<char,std::char_traits<char>,std::allocator<char> > (std::string).
This allows WheatyExceptionReport to log the text stored in char*, char[] and std::string.
2014-04-05 22:24:59 +02:00
Unholychick
28ba3d04b3 Partly revert 8edf6247c0
This wasnt the correct way to fix trinkets and talents that should proc on periodic heals, as it also made talents that procs off spells with casttime proc...
Mentioned are affected, but there is a potential fix in:
https://github.com/TrinityCore/TrinityCore/issues/1896

NOTE to self: learn to use the proc_flag table
2014-04-05 21:06:14 +02:00
joschiwald
29610b250d Core/Spells: fixed Throw Shield Visual and Clone Weapon 2014-04-05 00:37:07 +02:00
jackpoz
c4f4a023ea Core/Chat: Fix valid chat links being handled as invalid
Fix a case where valid chat links would have been handled as invalid.
This happened if these conditions were true:
- the link was a profession and the link name started with the same name of the profession, like spell id 61120 in esES locale "Inscripción de la tormenta de maestro" with profession name "Inscripción"
- the profession name was the same for more than 1 locale available, like esES and esMX, or enUS and enGB

Restore memmove() instead of memcpy() wrongly replaced in 791130f6fa , it's unsafe to use memcpy() with overlapping memory regions.
2014-04-04 22:16:14 +02:00
MitchesD
718b0e6bdd Core/SmartScripts: SMART_ACTION_EQUIP prevent to false errors 2014-04-03 19:47:27 +02:00
jackpoz
0930482fa4 Core/Misc: Fix uninitialized values
Fix Position members not being always initialized.
Valgrind log:
 at : Position::NormalizeOrientation(float) (Object.h:388)
 by : Position::SetOrientation(float) (Object.h:315)
 by : Position::Relocate(Position const&) (Object.h:310)
 by : spell_ulduar_stone_grip::spell_ulduar_stone_grip_AuraScript::OnRemoveVehicle(AuraEffect const*, AuraEffectHandleModes) (boss_kologarn.cpp:592)
2014-04-02 20:42:46 +02:00
Unholychick
8edf6247c0 Fix trinkets/talents procs on hots taken/done 2014-04-01 10:09:26 +02:00
Unholychick
8f607ed8a3 Revert f79a8813a0 2014-04-01 10:06:37 +02:00
jackpoz
10ba63cf3d Core/Misc: Fix typo in f47962f670 2014-03-31 21:10:29 +02:00
jackpoz
f47962f670 Core/Misc: Fix some static analysis issues
Add some asserts and additional NULL checks as sanity checks.
2014-03-31 20:59:33 +02:00
Vincent-Michael
bacfbdc4ee Core/Sai: Added new db errors :P (hihi) 2014-03-31 17:32:39 +02:00
Gacko
a01fd35dc9 Core/CreatureText: Unify log messages and add GUID 2014-03-30 22:17:03 +02:00
Shauren
b949d0b982 Core/Misc: Defined a few fields in Map.dbc and rewritten InstanceMap::GetMaxPlayers to match what the client does to determine max players 2014-03-30 15:42:05 +02:00
Gacko
7630b3c627 SmartAI: Use same method for removing auras in EnterEvadeMode as in CreatureAI
Also fixes warnings about duplicate auras. Self-casted auras were not removed on entering evade mode in SAI as they are in CreatureAI.
2014-03-30 15:05:04 +02:00
jackpoz
0056ec04c0 Core/Misc: Fix warning with GCC 2014-03-30 13:30:00 +02:00
jackpoz
dfca19444a Core/Misc: Fix warning 2014-03-29 21:51:45 +01:00
jackpoz
4cffd2e707 Core/Commands: Handle "" as empty string argument
Fixes #11548
2014-03-29 21:07:46 +01:00
Vincent-Michael
0b615ec159 Scripts/Misc: Small code optimizations 2014-03-29 20:58:49 +01:00