Brian Swango
8d92ccd54a
Fixed tabs
2014-08-18 20:06:49 -04:00
Brian Swango
87cbe5a2fc
Core/Loot: Fixes lootable items being able to be moved in inventory, and
...
also loot generated that uses conditions from being saved to the DB.
2014-08-18 20:03:13 -04:00
jackpoz
4a3416627d
Core/Creatures: Fixed an arithmetic error in respawn code
...
Creatures should now respawn correctly in their correct time.
Issue was caused by single-precision floating-point format losing precision on lower digits with high numbers, for reference http://docs.oracle.com/cd/E19957-01/806-3568/ncg_goldberg.html
Closes #12428
2014-08-19 00:00:54 +02:00
Zharvek
58c2b66e95
Core/RBAC: Fix RBAC permissions
...
This commit adds three missing commands to the world.commands table. The RBAC.h file is updated to the correct IDs from the auth.rbac_permissions table and the world.commands table. The RBAC.h file also had to be reordered to keep it clean.
Closes #12854
Signed-off-by: DDuarte <dnpd.dd@gmail.com >
2014-08-18 22:06:06 +01:00
Unholychick
377f385c81
Scripts/Ulduar: Spellscripts for Mimiron
...
Closes #12579
Signed-off-by: DDuarte <dnpd.dd@gmail.com >
2014-08-18 22:01:47 +01:00
jackpoz
cb53d64191
Merge pull request #12847 from ShinDarth/tc_fix_mount_abuse_after_bg
...
Core/Battleground: fixed possible mount abuse after leaving BG
2014-08-16 18:17:46 +02:00
ShinDarth
ae97b50af2
Core/Battleground: fixed possible mount abuse after leaving BG
2014-08-16 16:09:05 +02:00
Shauren
7cb72c2aac
Core/DBLayer: Fixed an incredibly rare memory leak happening when player started loading from database and never finished
2014-08-16 01:43:42 +02:00
Shauren
5c60976046
Core/Transports: Delayed adding transport model to next tick after teleporting to fix race conditions happening when teleporting transport happens at the same time as destination map balances its dynamic LoS tree
2014-08-16 01:06:30 +02:00
Shauren
acfaf2d182
Core/Misc: Fixed loading trinity_string
2014-08-15 20:01:58 +02:00
Shauren
aab4ab166d
Core/Socket: Added helpers to retrieve the size of currently ready data
2014-08-15 18:43:17 +02:00
Shauren
2fdc4723c2
Core/Misc: Optimized locale loading
2014-08-15 11:36:11 +02:00
Vincent-Michael
5b355c57ba
Core/Creature: Fix warning
2014-08-14 16:36:04 +02:00
joschiwald
ccfa82e7d5
Core/Creature: update creature_template and some other small things
...
http://www.trinitycore.org/f/topic/9572-creature-damage/
2014-08-14 16:09:14 +02:00
Jared P. Jones
1b65cda948
Scripts/Icecrown Citadel: The Teleporters in ICC are now Blizzlike *Upon entering the raid, the Lights Hammer teleporter is no longer immediately active. Both the Light's Hammer and the Oratory Portal will pop up after the completion of Lord Marrowgar as it does on official during 3.3.5a. *A teleporter in ICC can no longer teleport you to itself. *There is no longer a reason to allow GMs to use portals without available GOSSIP text and teleport locations. Therefore the teleports now use GO_FLAG_NOT_SELECTABLE when they are unavailable. In the future we can enable GMs to use portals without bosses defeated, however for now all it does is break the instance if some bosses are done out of order. *Currently the Upper Spire teleporter cannot be visited unless the event ColdFlameTraps is completed. This isn't blizz-like. During WotLK retail, the teleporter in the upper spire can be visited once any member has walked over an AreaTrigger which is located the moment you enter the UpperSpire Facade. The cold flame event has nothing to do with the teleporter, the cold flame event instead should be triggered to "DONE" when a rogue instead disarms it. *A bug has been addressed that causes the ColdFlameTraps event to not start back up after a server restart. The event will now restart as long as the player goes through the Saurfang->Upper Spire doorway; I'm not sure who required the doorway to be an area trigger, but it's hacky and not blizzlike. I have not yet addressed the area trigger problem with the doorway in this commit, mainly because the point of this commit is to make the ICC teleporters extremely Blizz-Like. *The "Conspicuous Lever" will now spawn inside of ICC. (From Sniff on Retail) While the lever currently doesn't do anything, in the future it will turn off the ColdFlame Traps. *The teleporter near Saurfang is not supposed to disable during the Intro. It disables whenever Saurfang enters combat with the players. The teleporter then enablers again when combat stops.
...
Closes #12834
2014-08-14 14:35:47 +02:00
Shocker
07158af425
Core/Spells: Implement SPELL_ATTR7_IGNORE_DURATION_MODS attribute
2014-08-13 03:53:56 +03:00
Shauren
bd4edf6e22
Core/Threading: Fixed possible race condition with m_timeOutTime and fixed Thread #1 : pthread_cond_{signal,broadcast}: dubious: associated lock is not held by any thread in PCQ
2014-08-12 18:18:52 +02:00
Dr-J
9f7075215d
Remove Manaforges CPP Script
...
Remove script
2014-08-12 13:36:21 +01:00
Shauren
c741d2682a
Core/NetworkIO: Prevent queueing more async operations when socket is already closed
2014-08-11 20:43:07 +02:00
leak
1a27ce1267
Core/NetworkIO: Restore networking related scripting hooks
...
Closes #12607
2014-08-11 17:40:43 +02:00
leak
528baae5f7
Kill potentially uninitialized variable warning
2014-08-11 14:03:16 +02:00
Shauren
730ca4d9e0
Merge pull request #12818 from MrSmite/pet_spell_cooldown
...
Fix pet spell cooldown
2014-08-11 09:02:58 +02:00
leak
14cb6e4235
Resolve shutdown crash/leak if MySQL server is not running
...
Fixes #12734
2014-08-10 22:43:48 +02:00
Vincent-Michael
9aea8046ce
Core: Fix non pch build
2014-08-10 21:46:04 +02:00
Shauren
f5bf13295c
Core/NetworkIO: Prevent double closing the same socket
2014-08-10 21:32:57 +02:00
Shauren
99e36e923f
Core/Misc: Removed ACE leftovers
2014-08-10 12:09:26 +02:00
Shauren
4fe45b8c63
Core/Worldserver: Replaced old hack sending key events to unblock console thread
2014-08-10 11:50:19 +02:00
Shauren
39d3480172
Core/Authserver: Fixed writing to invalid memory address
2014-08-10 11:48:43 +02:00
Shauren
df11916ad5
Core/NetworkIO: Allow receiving packets bigger than buffer size and properly handle situations where not entire packet was read in one go
...
Core/Authserver: Restored authenticator functionality
2014-08-10 11:00:27 +02:00
MrSmite
5dcf111150
Fix pet spell cooldown being extended without successful cast
...
Closes #12560
2014-08-10 04:51:46 -04:00
Vincent-Michael
0daebd9705
Core: Fix build for Intel Composer XE
2014-08-10 01:08:07 +02:00
DDuarte
df3b08d140
Core/Server: Use nullptr instead of 0 where pointers are expected
2014-08-09 21:32:26 +01:00
DDuarte
a394205eca
Core/Server: Add missing overrides
2014-08-09 20:17:40 +01:00
jackpoz
272b9d3d16
Core/WorldSession: Fix socket not being closed on clean logout
...
Close the WorldSession socket if Player didn't even login or logged out successfully and then closed the client.
2014-08-09 19:37:57 +02:00
Vincent-Michael
893d58fa87
Scripts/Commands: Fix static analysis issues
2014-08-09 19:18:05 +02:00
Shauren
d830890305
Core/Trade: Fixed putting soulbound items to "will not be traded" slot
2014-08-09 10:08:53 +02:00
Duarte Duarte
a5d2d3ac85
Merge pull request #12810 from Carbenium/questreward
...
Core/Player: Fix an issue with Player::RemoveRewardedQuest not deleting ...
2014-08-09 01:14:23 +01:00
Carbenium
dbaf0557e8
Core/Player: Fix an issue with Player::RemoveRewardedQuest not deleting the queststatus_rewarded form database
...
Needed for SPELL_EFFECT_CLEAR_QUEST
2014-08-09 01:54:22 +02:00
jackpoz
8402570bb8
Scripts/Misc: Fix static analysis issues
...
Replace CAST_AI() macro with ENSURE_AI() when dynamic_cast is not supposed to return NULL.
2014-08-09 00:12:20 +02:00
jackpoz
78af80230d
Core/Misc: Fix static analysis issues
2014-08-08 21:14:12 +02:00
Shauren
936db9d50d
Core/NetworkIO: Handle exceptions thrown from socket constructor when retrieving remote address
2014-08-08 14:01:09 +02:00
Vincent-Michael
7c6e1b1505
Revert "Core: Fix build for vs2014"
...
This reverts commit e303451189
2014-08-07 21:21:19 +02:00
Vincent-Michael
e303451189
Core: Fix build for vs2014
2014-08-07 20:41:33 +02:00
jackpoz
f25a87cda0
Core/Misc: Remove unused variable
2014-08-07 19:23:01 +02:00
Duarte Duarte
ca368a781b
Core/Socket: Fix typo in constructor
...
Using moved objects is generally a bad idea
Thanks @Daejiv
Closes #12800
2014-08-07 14:25:43 +01:00
Vincent-Michael
fad2bd4f92
Core: Kill AGAIN whitespace :(
2014-08-07 07:19:06 +02:00
Vincent-Michael
8c73b2dbae
Core: Fix non pch build
2014-08-07 07:00:17 +02:00
leak
48b94c3beb
Prevent reading address information from potentially closed socket
2014-08-06 23:16:40 +02:00
jackpoz
0f07dcfea6
Core/Scripts: Fix possible crash
...
Fix possible NULL dereference crash spotted by Coverity.
2014-08-06 20:55:43 +02:00
Shauren
7d97b4b841
Core/Misc: Fixed textlike/hexlike methods of ByteBuffer to print properly
2014-08-06 10:00:23 +02:00
