Commit Graph

6361 Commits

Author SHA1 Message Date
jackpoz
d52eb14bb6 Core/NetworkIO: Adjust more packet throttling values
Ignore some opcodes that don't cause any trouble.
Remove old Allow/Disable Anti-DoS system since it's no longer required.
2014-06-09 21:37:44 +02:00
Shauren
f81635ebe5 Core/Vehicles: Fixed channeled spells being interrupted for passengers when vehicle moves 2014-06-09 21:08:19 +02:00
Trisjdc
0b3e391ac4 Merge pull request #11739 from Golrag/master
Core/Spells: Fixed Shadowstep taking the caster out of combat while it shouldn't
2014-06-09 00:53:28 +01:00
Trisjdc
38e12321a5 Merge pull request #12069 from Trisjdc/cheat_death
Core/Spells: Fix Cheat Death formula
2014-06-09 00:45:12 +01:00
Trisjdc
551c565746 Core/Handlers: Move a couple of logs to debug, they can appear without anything abnormal due to client latency 2014-06-08 23:11:42 +01:00
Lucas
5d40838207 Fix Warnings 2014-06-08 21:21:49 +02:00
Sebastian Valle Herrera
d0c9ac1d69 Merge pull request #12228 from Unholychick/patch_periodics
Core/Spells: Implement Periodic mechanics
2014-06-08 13:13:14 -05:00
jackpoz
fc7062049f Core/Calendar: Sanitize calendar event parameters
Prevent events added in the past which in some conditions would cause an infinite loop in the client.
2014-06-08 17:33:17 +02:00
jackpoz
927f16de49 Revert "Core/Calendar: Fix memory leak when malformed CMSG_CALENDAR_ADD_EVENT is received"
This partially reverts commit 51e38872c7.
The stack-initialized variable calendarEvent would have called CalendarMgr::FreeEventId() when it went out of scope, marking the current event id as free and allowing next event to overwrite current event.
This doesn't fix the memory leak issue which still needs to be addressed in a proper way.
2014-06-08 17:18:07 +02:00
Vincent-Michael
1d39db16b9 Core/Misc: Kill Whitespace ... 2014-06-07 23:58:08 +02:00
jackpoz
5fee5b0125 Core/Banks: Fix some bank exploits
Re-implement the cheat checks removed in a12501fb5e and check if Player can interact with the Banker when handling bank-related opcodes.
2014-06-07 22:47:50 +02:00
Sebastian Valle Herrera
8304c09547 Merge pull request #12231 from Trisjdc/fishing_boober_link
Core/GOs: When unlinking Fishing Bobber from player to prevent despawning, unlink from spell as well to prevent removing unwanted auras
2014-06-07 14:24:30 -05:00
Unholychick
d4bbc26261 Core/Spells: Implement Periodic mechanics
Change behaviour of single target periodic aura ticks to be more blizzlike
Also add some missing handling of SPELL_AURA_MOD_CREATURE_AOE_DAMAGE_AVOIDANCE
Fixes Deep wounds and Chimera Shot Serpent
Remove an ancient hack with Drain Soul, spell id 100001 can now be deleted from spell_dbc table
Allows Rolling dot mechanics and allows DK's to roll diseases with pestilence,
see link for info:

http://forums.elitistjerks.com/topic/82503-frost-dps-in-333this-will-be-a-day-long-remembered/page-88
2014-06-07 19:13:57 +02:00
Trisjdc
97046283b5 Core/Spells: Anti-Magic shell should give immunity to all spells that belong to SPELL_SCHOOL_MASK_MAGIC regardless of dispel type 2014-06-07 18:06:22 +01:00
Trisjdc
6abfdc1cea Core/GOs: When unlinking Fishing Bobber from player to prevent despawning, unlink from spell as well to prevent removing unwanted auras 2014-06-07 17:58:45 +01:00
Sebastian Valle Herrera
6c31c33f66 Merge pull request #12128 from Trisjdc/aura_transform
Core/Auras: Update model overwriting rules for SPELL_AURA_TRANSFORM
2014-06-07 11:49:00 -05:00
Sebastian Valle Herrera
35b8874cca Merge pull request #12216 from Trisjdc/quest_item_check
Core/Players: Improve quest item adding/removal checks, solves cases where quest item removal (under specific conditions) incorrectly incompletes quests
2014-06-07 11:46:57 -05:00
Sebastian Valle Herrera
906abd7956 Merge pull request #12204 from Trisjdc/map_enter
Core/Maps: Allow logging players to enter in instances that have an encounter in progress
2014-06-07 11:46:37 -05:00
Sebastian Valle Herrera
fd7589617d Merge pull request #12057 from Trisjdc/imp_in_a_ball
Scripts/Items: Imp in a Ball
2014-06-07 11:44:22 -05:00
joschiwald
32a3ecb986 Core/Spells: add missing spellradius to spell "Achievement Check" (fixes hor achievments) 2014-06-07 17:04:20 +02:00
Aokromes
61d6b69166 Merge pull request #12225 from Trisjdc/event_map_move
Core/Utils: Move EventMap to Util.h
2014-06-07 00:08:02 +02:00
Michael
8207aff0d6 Core/NetworkIO: Added latency info for opcodes overflow log 2014-06-06 19:41:57 +02:00
Trisjdc
eae18d8ed0 Core/Utils: Move EventMap to Util.h 2014-06-06 11:14:32 +01:00
Trisjdc
b4b3e6f3a2 Scripts/Items: Imp in a Ball 2014-06-06 11:01:36 +01:00
Trisjdc
bb01c60a52 Core/Players: Improve quest item adding/removal checks, solves cases where quest item removal (under specific conditions) incorrectly incompletes quests 2014-06-06 10:41:45 +01:00
jackpoz
d565c2b303 Core/Talents: Align server checks to Client limits
Set the max amount of talents to process in CMSG_LEARN_PREVIEW_TALENTS_PET to 30 ( 24 talents rounded up ).
2014-06-05 22:50:11 +02:00
jackpoz
7d623eed18 Core/Talents: Align server checks to Client limits
Set the max amount of talents to process in CMSG_LEARN_PREVIEW_TALENTS to 150 ( 44 talents for 3 trees rounded up ).
2014-06-05 22:19:02 +02:00
Sebastian Valle Herrera
36102bea64 Merge pull request #12039 from Trisjdc/creature_ai_talk
Core/CreatureAI: Implement CreatureAI::TalkToMap for all your map-wide talking needs
2014-06-05 10:50:23 -05:00
Sebastian Valle Herrera
42d4144f90 Merge pull request #12045 from Trisjdc/session_expire
Core/WorldSession: After sudden disconnects, session should persist for a minute
2014-06-05 10:49:28 -05:00
Trisjdc
afb7c705c2 Core/Spells: *Properly* solve the Disarm vs Bladestorm issue 2014-06-05 11:48:43 +01:00
blub
700baded7a Merge pull request #12215 from Trisjdc/warning_fix
Warning fix
2014-06-04 20:14:29 +02:00
Trisjdc
2a6d3fa67c Warning fix 2014-06-04 19:12:02 +01:00
jackpoz
bd45a0bba9 Core/Tickets: Don't try to save the same sub-survey more than once 2014-06-04 19:56:13 +02:00
Shauren
84d0094ffa Core/Tickets: Sprinkled some transaction magic on HandleGMSurveySubmit 2014-06-03 23:24:00 +02:00
Trisjdc
d12737d9bb Core/WorldSession: After sudden disconnects, session should persist for a minute
- With this change, if a player alt-f4, he'll only fade from world after a minute
2014-06-03 01:12:34 +01:00
Trisjdc
18868f5cbd Core/Maps: Allow logging players to enter in instances that have an encounter in progress 2014-06-03 00:57:36 +01:00
Trisjdc
d99f0362cb Core/Auras: Update model overwriting rules for SPELL_AURA_TRANSFORM 2014-06-03 00:39:20 +01:00
Sebastian Valle Herrera
409a19e623 Merge pull request #12201 from Unholychick/patch-2
Core/Spells: Implement SPELL_ATTR4_FIXED_DAMAGE
2014-06-02 18:23:17 -05:00
Sebastian Valle Herrera
d41779f8fa Merge pull request #12135 from Trisjdc/event_map_extension
Core/Util: A couple useful new functions for EventMap
2014-06-02 18:10:08 -05:00
Trisjdc
8db02c52ac Core/Util: A couple useful new functions for EventMap, as well as getting rid of some old junk 2014-06-02 23:59:35 +01:00
Sebastian Valle Herrera
d097a5ec97 Merge pull request #12182 from Xter/rbac
Core/RBAC: fix RBAC_PERM_COMMANDS_BE_ASSIGNED_TICKET and RBAC_PERM_LOG_G...
2014-06-02 17:47:40 -05:00
Sebastian Valle Herrera
f5e6292b48 Merge pull request #12032 from Trisjdc/haste_formula
Core/Players: Fix haste rating formulas
2014-06-02 17:23:16 -05:00
jackpoz
0c1ddc970d Core/Misc: Kick player in case of multiple CMSG_PLAYER_LOGIN
Kick player in addition to logging an error in case of multiple CMSG_PLAYER_LOGIN.
2014-06-02 17:03:31 +02:00
Lucas
82cefb661d Core/Spells: Implement SPELL_ATTR4_FIXED_DAMAGE
Spells with this attribute will ignore damage taken auras except for mechanic damage taken (trauma, etc) and will ignore resilience because the damage caused by those spells is based off another spell' damage
2014-06-02 15:41:02 +02:00
jackpoz
282a7cad7d Core/Misc: Code cleanup
Remove old unused opcode handler WorldSession::HandlePageQuerySkippedOpcode() for CMSG_PAGE_TEXT_QUERY since it's already handled by WorldSession::HandlePageTextQueryOpcode()
2014-06-01 16:15:27 +02:00
jackpoz
70bd70080d Core/QuestPOI: Mitigate possible DoS with CMSG_QUEST_POI_QUERY
Avoid sending POIs for same quest if the client somehow sent duplicates quest id in same CMSG_QUEST_POI_QUERY packet. This also reduce the effects of possible DoS and increases the difficulty to cause it.
Fix a typo which caused no quest POIs to be sent at all if the client queried data for 25 quests.
2014-06-01 13:33:46 +02:00
xter
19c56cbc0e Core/RBAC: fix RBAC_PERM_COMMANDS_BE_ASSIGNED_TICKET and RBAC_PERM_LOG_GM_TRADE permissions 2014-05-31 14:04:37 +02:00
Warpten
7b49038454 Merge pull request #12171 from Ankso/player_update_zone
Core/Players: Update the player's zone and area only after the player's position is updated server-side.
2014-05-30 19:53:47 +02:00
Ankso
ab62fe30bc Core/Players: Update the player's zone and area after update the player's
position server side.
2014-05-30 17:18:52 +02:00
jackpoz
8d539ee6c0 Merge pull request #12162 from Trisjdc/aura_split_damage_breaking
Core/Spells: Break 'Fear' and similar auras on damage sharing of SPELL_AURA_SPLIT_DAMAGE_PCT
2014-05-29 21:21:39 +02:00