Commit Graph

142 Commits

Author SHA1 Message Date
Machiavelli
dc3d6a2f23 Remove redundant code from 1487ebedaa 2011-01-07 19:13:19 +01:00
Machiavelli
c65e3822a2 Fix build from 06314c9387
closes #99
2011-01-06 22:45:07 +01:00
Sarjuuk
06314c9387 Core/Spells: Implemented Pygmy oil use effect
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
2011-01-06 21:40:32 +01:00
Ottowayne
7aa85728fc Core/Spells: Dummy for spell 51961; support for Quest 12532 & 12702
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
2011-01-06 20:22:39 +01:00
Ottowayne
1487ebedaa Core/Spells: Dummy for spell 47703 (Unholy Union) for quest 12126
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
2011-01-06 20:14:13 +01:00
sarjuuk
0cf89f635f Core/Spells: Starfall skips targets in stealth, invisibility or not in LoS
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>

Also minor codestyle fixes from previous commits
2011-01-06 19:57:36 +01:00
Ottowayne
b0c559e704 Core/Spells: Fix Spell 54577 - Support for Quest 12828
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
2011-01-06 19:33:22 +01:00
Anubisss
80da87f015 Add one more check to EffectDispel.
Passive auras are not dispelable.
This fixes a bug like spell Omen of Clarity (16864) can be dispelled by Purge (370) if you have a non passive aura like Mark of the Wild (1126).

Signed-off-by: Anubisss <anubisss210@gmail.com>
2011-01-02 22:43:36 +01:00
Shauren
9c0cd63e93 Core/Scripts: Added wrapper method for despawning creatures DespawnOrUnsummon 2011-01-02 21:33:37 +01:00
Machiavelli
957c69de83 Update copyright note for 2011.
Happy new year.
2011-01-01 15:01:13 +01:00
Machiavelli
bdc47053cc Core/Spells: Partial fix spells 62056, 63985 (Stone Grip Force Cast - Part of Kologarn encounter), underlying AuraEffect::HandleAuraControlVehicle will no longer prematurely return.
--HG--
branch : trunk
2010-12-27 14:53:47 +01:00
Machiavelli
d951407822 Revert 0a95c34021 (thanks QAston for talking sense into me)
--HG--
branch : trunk
2010-12-27 11:06:53 +01:00
Machiavelli
299118cd3a Remove missing lines from previous commit, thanks click for pointing out.
(WTB Coffee)

--HG--
branch : trunk
2010-12-27 09:49:38 +01:00
Machiavelli
d69a1c3629 Core/Spells: Fix SPELL_EFFECT_FORCE_CAST(140), SPELL_EFFECT_FORCE_CAST_WITH_VALUE(141). These should force the target to cast a certain spell, not serve as a proxy for the original caster to cast another spell.
--HG--
branch : trunk
2010-12-27 09:21:08 +01:00
Machiavelli
4a169412b7 Core/Spells: Implement 65594 (Cancel Stone Grip - Used in Kologarn encounter) spell
--HG--
branch : trunk
2010-12-27 09:19:06 +01:00
linencloth
efbc73d025 Core/Player: Split RemoveQuest into 2 separate functions
--HG--
branch : trunk
2010-12-26 21:34:08 +01:00
linencloth
6b58081e63 Core/QuestStatus: Fix EffectQuestClear, also clear rewarded quests again
--HG--
branch : trunk
2010-12-26 21:18:22 +01:00
Shauren
79070ca820 Scripts/Serpentshrine Cavern: Fixed "The Lurker Above" achievement and removed hacks for the event
--HG--
branch : trunk
2010-12-26 16:35:29 +01:00
linencloth
b150172521 Core/QuestStatus:
- Separate rewarded quests from active quests, and store them in a new table to reduce database size
- Drop the no longer needed `rewarded` column from character_queststatus for smaller table size
- Prevent filling the database with dropped quests
  - Delete useless records
- Implement queststatus save "queues" instead of states
- Minor optimizations

WARNING: Backup your database!

--HG--
branch : trunk
2010-12-26 04:16:18 +01:00
click
b181ba21d9 Core: Fix a few warnings here and there.
--HG--
branch : trunk
2010-12-25 06:28:38 +01:00
Machiavelli
d587948a0f Core/Spells: Use a workaround for Grab Crate, cast triggered spell with original caster as caster instead of target. Previous approach was prone to out of range errors.
Spell will now correctly restore 25 Pyrite energy (assuming aura 62495 is present to trigger the initial handler)

--HG--
branch : trunk
2010-12-25 03:18:21 +01:00
Shauren
928443d899 Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
--HG--
branch : trunk
2010-12-23 23:25:44 +01:00
Machiavelli
f3dd337c6a Core/Spells: Fix Glyph of Felhunter
Author: Lopin

--HG--
branch : trunk
2010-12-23 19:03:28 +01:00
Shauren
0f3b9019a8 Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
--HG--
branch : trunk
2010-12-22 21:25:23 +01:00
Shauren
7b4e1c6387 Core/ObjectMgr: Static members are no longer accessed through singleton
--HG--
branch : trunk
2010-12-22 20:23:47 +01:00
Shocker
446c300505 Core/Spells: Small cleanup in SpellEffects, spells always have caster
--HG--
branch : trunk
2010-12-22 20:18:34 +02:00
Shocker
42304c0b25 Core/Spells: Implement SPELL_EFFECT_UNTRAIN_TALENTS, thanks to Heisenberg, closes issue #5238
--HG--
branch : trunk
2010-12-22 20:14:30 +02:00
Machiavelli
baff745be1 Core/Spells: Fix Improved Felhunter mana energize part.
Based on code by Karolis.Rudzevicius
Fixes issue #2125
Fixes issue #2109

--HG--
branch : trunk
2010-12-20 00:35:11 +01:00
linencloth
59da698189 Core: Rename spell attributes, use more general names
--HG--
branch : trunk
2010-12-19 05:15:47 +01:00
Shauren
82f45966fc Core/Unit: Renamed addUnitState/hasUnitState/clearUnitState to AddUnitState/HasUnitState/ClearUnitState
Core/Vehicles: Allow the vehicle to always damage the passenger (removed unneded dbc hacks from scripts)

--HG--
branch : trunk
2010-12-17 13:43:24 +01:00
Anubisss
6d9029c12e Make some cleanup.
My thank goes to Az@zel for the code analysis.

--HG--
branch : trunk
2010-12-16 18:08:23 +01:00
azazel
d2d62eab50 Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
NOTE: Initially I just wanted to fix some warnings, but noticed that there is no common method for percentage calculation and various formulas are used many time in the code making it difficult to read and understand what the code actually does. So, I introduced several template methods for calculating percent values and adding those values to the original base. I replaced all the raw calculations throughout the code where found, but I could have missed something or could have made a mistake. So, please report any strange behaviour after this commit.
If you ask me why I did it: for the sake of consistency and exact understanding what code means. If you see CalculatePct method, you clearly understand, that it find the value of x percent of y. And you can easily express, for example, spell behviour "reduces smth by x%" by the means of a method instead of recalling school maths.

--HG--
branch : trunk
2010-12-11 20:37:38 +06:00
azazel
e7eb4e22e2 Core/Mechanics: cleanup shapeshift form code (by VladimirMangos)
--HG--
branch : trunk
2010-12-09 17:03:42 +06:00
Machiavelli
bbf619c20d Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
Author: dr.tenma
Closes issue #4506
Closes issue #1874

--HG--
branch : trunk
2010-12-04 10:31:14 +01:00
Shauren
3badf69b63 Core/Spells: Fixed bad Z coordinate for Spell::EffectBind with location stored in database
Core/Scripts: Corrected few mistakes in misc scripts

--HG--
branch : trunk
2010-12-03 13:54:00 +01:00
Shocker
a23ae5c94c Core/Spells: Implement SPELL_EFFECT_WMO_CHANGE, patch by Heisenberg
Closes issue 4984.

--HG--
branch : trunk
2010-12-01 20:59:05 +02:00
Spp
addd762c4d Core: Fix warnings
--HG--
branch : trunk
2010-11-16 14:08:12 +01:00
Shocker
48d90fab32 Misc: Some engrish fixes, thanks to ZxBiohazardZx, closes issue 4740
--HG--
branch : trunk
2010-11-14 23:46:34 +02:00
linencloth
bb9336ca27 Core/Spells: Effect sanctuary should stop attackers without threatlist too
Closes issue 1943

--HG--
branch : trunk
2010-11-13 20:23:05 +01:00
Shauren
ec49ce5fc3 Core/Spells: Fixed possible crashes in scaling mounts code when player is not in a valid zone
--HG--
branch : trunk
2010-11-13 18:54:33 +01:00
linencloth
880ef0c398 Core/Spells: Fix spelleffect sanctuary
- No longer removes every attacker, but updates the visibility
  - Using that effect won't remove attackers that can still see through the stealth of the caster based on distance
- Ignores spells that were casted before or at the same time of that effect
- Trigger other needed spells when casting Shadowmeld

--HG--
branch : trunk
2010-11-13 18:04:56 +01:00
linencloth
bf888285aa Core:
- Redesigned stealth and invisibility handling
  - Implemented the handling of multiple stealth types
- Implemented fake inebriation
- The message deliverer no longer sends packets from a non-visible source
  - The server won't send that much garbage which just takes bandwith
  - It won't be possible to use cheats to detect invisible objects
- Removed a lot of checks for the Z-coord
  - Fixes visibility problems happening while flying
- Limited the grid activation range of creatures to use less resources
- Implemented Shroud of Death
- Implemented increased visibility range for active objects
- Removed visibility check at spellhit (only sanctuary effects should prevent it)
(And a lot of other changes...)

Closes issue 4208
Closes issue 3049
Closes issue 2097
Closes issue 2198
Closes issue 2384
Closes issue 2197
Closes issue 2319

--HG--
branch : trunk
2010-11-13 17:18:09 +01:00
Xanadu
78a8b09774 Core/Spells: Fixed Vanish not applying stealth. Closes issue #4699.
--HG--
branch : trunk
2010-11-13 06:43:45 +01:00
Shauren
cc220ca7b6 Scripts/Spells: Added script for Animal Blood pool spawning (fixes fishing daily quest "Blood is Thicker")
--HG--
branch : trunk
2010-11-10 11:37:41 +01:00
_manuel_
5674f81e51 Core/Spells: Deterrence should deflect Death Grip.
Fixes issue 4582.

Based on gastuslg´s patch and thanks to click.

--HG--
branch : trunk
2010-11-09 23:02:47 -03:00
Machiavelli
ddc812163a Core/Spells: Fix Shield of Righteousness damage
Author: Dr.Tenma
Fixes issue #4174

--HG--
branch : trunk
2010-11-09 11:15:00 +01:00
click
c58e227ffa Core/Spells: Fix hunter pet namechanging when using Certificate of Ownership (spellID 53987, used by itemID 43850)
(There's also, as far as I know, no window on hunter pet renames, one selects the pet and clicks 'rename').
Closes issue 2967.

--HG--
branch : trunk
2010-11-07 22:23:12 +01:00
Rat
5cb119e617 Core/AI: implemented SmartScripts System (still beta) not 100% complete
WARNING: Use scripts at own risk. You were warned.
NOTE0: creature, gameobject, areatrigger type scripts should be fully functional
NOTE1: has no effect on any core related stuff if not using any SmartScript
NOTE2: all event/action/etc descriptions can be found in SmartScriptMgr.h

SmartScripts is a reloadable DB-Sript system, with full control for special scripting,
like escorting, following, complex combat handling, pre-stored AI templates(caster, turret, etc) and much more
with a total of 66 events, 78 actions, 22 target types, and can be easily extended

--HG--
branch : trunk
2010-10-27 21:01:47 +02:00
Supabad
b7b65eacf2 Core/Spells: Destructable Buildings
- Fix issue where damage can be done to GameObjects with hp 0
- add check for Gameobjects with faction 0

--HG--
branch : trunk
2010-10-19 13:15:47 +02:00
Shocker
e38e590ec8 Core/Spells: Really move spec changing InBattleground check to its correct location
--HG--
branch : trunk
2010-10-16 17:53:33 +03:00