Commit Graph

30260 Commits

Author SHA1 Message Date
Shauren
8396dabdad Core/Misc: Fixed coverity issues
Uninitialized fields: CID 1354593, 1354595, 1354738
Unchecked return value: CID 1354558
Out of bounds access: CID 1352989, 1352993
Null pointer dereference: CID 1296286
2016-06-06 09:16:59 +02:00
Shauren
d59bba3c5d Core/Misc: Fixed uninitialized field
Coverity CID 1354596
2016-06-06 08:51:42 +02:00
Shauren
d8e0ce4d40 Core/Misc: Fixed uninitialized fields in black market packets
Coverity CID 1354736 and 1354737
2016-06-06 08:49:10 +02:00
Shauren
b920d6a35c Core/Spells: Fixed possible null pointer dereference
Coverity CID 1355243
2016-06-06 08:45:09 +02:00
Shauren
1c139214b5 Core/Spells: Silence coverity false positive - CID 1356246 2016-06-06 08:38:39 +02:00
Shauren
737469cfaa Core/PacketIO: Update movement packets 2016-06-05 17:57:19 +02:00
Vincent-Michael
9d7a17d9f5 Core/Commands: Added ".npc set phase" command error message for invalid phaseid
Closes #14927
2016-06-05 16:43:41 +02:00
Aokromes
18aa8df320 DB/Misc: Instance template for Hellfire Citadel
Closes #17114 by Ulduar
2016-06-05 14:20:14 +02:00
Shauren
6b1c85a676 Core/PacketIO: Updated spell packets 2016-06-05 14:08:53 +02:00
Aokromes
08c6b2aed5 DB/Creature: Scarlet Centurion, Flamethrower and Pile of Corpses SAI
By unknown closes #15467
2016-06-05 09:18:20 +02:00
Aokromes
3d93c12f5f DB/Creature: Innkeeper Farley - Lion's Pride Inn - Goldshire
Closes #16227
2016-06-05 07:56:29 +02:00
Aokromes
b5bafef8af DB/Misc: Fix startup errors
Updates #17237 by tkrokli
2016-06-05 04:37:13 +02:00
Shauren
6ce84d9401 Core/PacketIO: Fixed sending SMSG_SPELL_EXECUTE_LOG 2016-06-05 01:19:25 +02:00
Shauren
dd1533b315 Core/Utils: Added additional argument to Tokenizer class to make it behave like strtok - not returning empty tokens in case of multiple consecutive separators in input string 2016-06-04 16:40:57 +02:00
Shauren
40065aa658 Core/GameTables: Fixed loading gametables with trailing tabs 2016-06-04 16:36:23 +02:00
jackpoz
3f02f9edcd Grafana/Dashboards: Fix General info datasources
Fix General info datasources for counter panels

(cherry picked from commit 911bffd208)
2016-06-04 13:26:22 +02:00
Aokromes
1379505bf2 Update worldserver.conf.dist 2016-06-04 12:49:07 +02:00
DDuarte
8b26aea95a Implement real time statistic visualization (#16956)
Docs at https://trinitycore.atlassian.net/wiki/display/tc/Monitoring+a+TrinityCore+server

* Common/Graphs: Initial proof of concept

* Move influx db code to its own class

* Reuse the same socket

* Allow to log values of different categories

* Allow to log events

* Pass the timestamp to influxdb

* Send events in batches

* Send data async

* Log server shutdown.
Fix memory leak.

* Allow to enable/disable Stats in the settings and at runtime

* Read interval between each batch send from config

* Add InfluxDB connection info to configs

* Move each event category to its own table

* Log pathfinding queries

* Move categories table initialization to constructor using enum as key to avoid assigning the table name to the wrong enum value

* Log player login/logout events.
Pass the hostname correctly in the HTTP request.

* Fix linux build

* Handle "Connection: close" HTTP header, reconnecting on next scheduled send.
Disable StatsLogger if connection fails, logging the error.

* Add an enum for categories of logged values, it's still possible to pass a string instead of the enum.

* Don't log the whole batchedData when InfluxDB returns an error, it's too long and unreadable on console.

* Allow to call a function at a specified interval in thread-safe World::Update() context to log data like player count.

* Log map tile load/unload

* Core/StatsLogger: Allow logging more value types other than ints

https://docs.influxdata.com/influxdb/v0.10/write_protocols/write_syntax/

* Fix a typo in string escape of StatsLogger

* Yet more fixes to the escaping in FormatInfluxDBValue

* DB/Gameobject: Fix respawn time of few Quest GameObjects

By Tauriella, closes #16701

* DB/Misc: Fix some engrish

By tkrokli closes #16648

* Tools/MMaps: Add format library linking to mmaps_generator

(Very) partial cherry pick of ed75b0649a

* Core/StatsLogger: Simplify code

Convert values and categories arrays to maps initialized in-place
Remove constructor and destructor

* Core/StatsLogger: Add realm name to the event and value tags

* Log amount of processed packet of each session

* Apply recent singleton changes to sStatsLogger too

* Fix influxdb data format if no realm name is present

* Remove unneeded newlines from request body, fixes response 400 from InfluxDB 0.10

* Rename Reporting folder to Metric

* Rename StatsLogger to Metric

* Rename InfluxDB configs to Metric

* Add Grafana dashboards

* Add a random annoying macro

* Move string formatting to Metric::SendBatch(), reducing performance footprint of Metric::LogEvent() and Metric::LogValue()

* Update grafana graphs refresing tags on load and showing now-15m data, refreshing every minute. These settings can be modified in grafana.

* Rename MetricData fields

* Contrib/Grafana: Rename dashboard files

* Contrib/Grafana: Replace hardcoded Windows/Ubuntu realm names by the default, Trinity

* Config/Worldserver: Add missing section to the index

* Contrib/Grafana: Add singlestat panels with current online players, update diff averages (1 min, 5 mins and 15 mins)

http://i.imgur.com/Zi8lfvS.png

* Core/Metric: Replace the enums MetricEventCategory and MetricValueCategory by strings

For the sake of simplicity and less recompile time when adding new metrics, similar to how TC_LOG_* works

* Contrib/Grafana: Display the current number of online players and not its average

Closes #15075
(cherry picked from commit 3ae1016082)

# Conflicts:
#	src/server/game/Server/WorldSession.cpp
#	src/server/game/World/World.cpp
#	src/server/worldserver/Main.cpp
2016-06-04 11:26:57 +01:00
Shauren
2c2bb4a237 Core/Auras: Named currency gain modifying aura types 2016-06-03 23:27:07 +02:00
Shauren
3a63cfb1b2 Core/PacketIO: Updated SendKnownSpells 2016-06-03 19:14:59 +02:00
Shauren
a1ce7ae6a2 Build fixes 2016-06-03 16:49:42 +02:00
Shauren
3ab3a667ed Core/Spells: Add assertions validating various spell enums 2016-06-03 16:45:01 +02:00
Shauren
7f21c2979e temp disable packet pch 2016-06-03 15:51:27 +02:00
Warpten
12f029d442 Core/PacketIO: Implemented new Cast HighGuid type and fix some mistakes with SMSG_MOVE_UPDATE_APPLY_MOVEMENT_FORCE
Core/Updatefields: Health is now stored as an unsigned long int.
2016-06-03 09:27:27 +02:00
Sean Rhone
9db75766e7 Update worldserver.conf.dist (#17270)
- Very minor typo
2016-06-03 00:35:24 +01:00
Warpten
c631656fb8 Core/PacketIO: Update a few movement-related structures and enable some opcodes. 2016-06-03 00:13:31 +02:00
Shauren
832944db24 Core/PacketIO: Updated SMSG_DB_REPLY 2016-06-03 00:00:49 +02:00
Shauren
fa1c499150 Core/PacketIO: Fixed starting spline movement with 0 length segments 2016-06-02 18:55:42 +02:00
Shocker
63f8f54e5c Core/Spells: Define SPELL_EFFECT_ALTER_ITEM 2016-06-02 17:07:07 +03:00
jackpoz
11175b148e Travis: Remove unneeded apt-get update
(cherry picked from commit 24ac2bb9be)
2016-06-02 14:41:55 +02:00
Shauren
3ccb1e665f Core/Auras: Send aura update to client when aura amount changes and aura has SPELL_ATTR8_AURA_SEND_AMOUNT 2016-06-01 23:08:30 +02:00
jackpoz
a6731f9a97 Travis: Move to Ubuntu 14.04 Trusty Travic-CI from Ubuntu 12.04
(cherry picked from commit 21ee9be110)

# Conflicts:
#	.travis.yml
2016-06-01 21:20:30 +02:00
Shauren
cc03d7ca24 Core/PacketIO: Updated SMSG_UPDATE_OBJECT 2016-06-01 20:14:16 +02:00
Shauren
f682e155c8 Core/Garrison: Crash fix 2016-06-01 20:13:23 +02:00
Shauren
a37469de59 Core/Players: Fixed Player::LoadFromDB 2016-06-01 20:13:06 +02:00
Killyana
a6f6bb4fcc DB/Quest: Fix some Monk Trainer quests
Closes  #16017
By Suraf
2016-05-31 19:14:31 +02:00
Shauren
2cead228d2 Core/PacketIO: Fixed setting player declined names
Closes #16669
2016-05-31 17:03:05 +02:00
Shauren
e78abe9911 Core/Auras: Fix copypaste mistake from fde9e8985f 2016-05-31 17:02:22 +02:00
Aokromes
0e47d4211b Update 2016_05_31_04_world.sql 2016-05-31 16:19:18 +02:00
Aokromes
8e7d59abcc DB/Quest: Never Trust a Big Barb and a Smile
Closes #16311 by Crosha
2016-05-31 14:13:55 +02:00
Aokromes
0bdb2ce8e3 Update 2016_05_31_01_world.sql 2016-05-31 14:11:55 +02:00
Aokromes
522fe01e38 DB/Spell: Teleport to Saurok Creation Pit
Closes #16694 (by deleted account)
2016-05-31 13:39:25 +02:00
Aokromes
bc0c71add7 DB/Profession: Fixed Jewelcrafting teachers and their spells
Closes #17151 by Fredi100
2016-05-31 13:23:32 +02:00
Aokromes
c273bca24f DB/Profession: Added Enchanting trainer spells
Closes #17162 by IzFrost
2016-05-31 13:22:17 +02:00
Aokromes
d868e06db6 DB/SAI: Cloud Prince (upgrade script) and Storm Young Dragon
Closes #17173, by Mihapro
2016-05-31 12:18:46 +02:00
Aokromes
bd8c173c9b DB/Profession: Fixed riding teachers and their spells
Closes #17161 by Fredi100
2016-05-31 12:14:30 +02:00
Shauren
94005f3496 Core/Players: Fixed character appearance validation 2016-05-30 23:51:39 +02:00
Shauren
5ad01990c6 Core/PacketIO: Updated opcodes to 7.0.3.21796 2016-05-30 23:51:06 +02:00
Shauren
c95f4a5070 Core/GameObjects: Updated GameObjectTemplate to 7.0.3.21796 2016-05-30 23:49:35 +02:00
Shauren
25d82b2c31 Core/Entites: Updated updatefields to 7.0.3.21796 2016-05-30 23:43:04 +02:00