Commit Graph

9437 Commits

Author SHA1 Message Date
mik1893
df744c75e7 Core/Spell: Triggered spells should inherit LOS checking from triggering aura
Avoid triggered spells to ignore LOS by default
Fixed wrong behaviour of Bladestorm spell
2014-08-25 17:16:02 +02:00
Duarte Duarte
70b70f9cda Merge pull request #12919 from MitchesD/misc_3
Core/Channels: fixed possible exploit with channel password
2014-08-25 00:52:30 +01:00
MitchesD
80cde8aa10 Core/Channels: fixed possible exploit with channel password
You were able to setup longer password than you can write into the dialog window. Limit in dialog is 31 chars, in DB is varchar(32) but there was no limit in command /pass <channel> <password>, so that was the problem.
2014-08-24 23:54:28 +02:00
Vincent-Michael
72b9b50bc7 Core/Unit: Fix some phasing change problems with vehicle 2014-08-24 22:09:10 +02:00
jackpoz
7fa49c8d62 Scripts/Ruby Sanctum: Fix Halion event ai not being updated
Fix Halion event ai not being updated due to private member hiding base class member.
Fixes #12835
2014-08-24 20:35:44 +02:00
Vincent-Michael
4a58341e6d Core: Fix warnings 2014-08-24 18:08:29 +02:00
jackpoz
a3b14db015 Merge 'Numielle/master' into master
This is a workaround required by the current spell system limitations.
Close pull request #11915 .
2014-08-24 17:11:51 +02:00
jackpoz
c20f92c08c Merge branch 'Rochet2/questreward'
Close pull request #12657
2014-08-24 14:38:55 +02:00
Rochet2
9beae1dc97 Removed OnQuestComplete hook, use QuestReward instead. Implemented OnQuestStatusChange hook
Also fixed some comments and added overrides
The OnQuestComplete hook was unused and didnt work properly
2014-08-24 14:31:38 +03:00
Vincent-Michael
79b954a349 Core: meh, remove again whitespace :( 2014-08-24 02:46:14 +02:00
joschiwald
2a36d2bf5b Core/Conditions: allow CONDITION_OBJECT_ENTRY to check for object guid
Ref #12910
2014-08-24 00:10:09 +02:00
jackpoz
7d4801750b Core/Misc: Fix Mac OS X no-pch build 2014-08-23 19:56:42 +02:00
jackpoz
7fe7f30521 Core/Misc: Fix some -Wconversion warnings 2014-08-23 19:56:41 +02:00
DDuarte
f5f9df0483 Core/Auctionhouse: Better fix for 809fb9894e 2014-08-23 16:30:45 +01:00
Duarte Duarte
1255434882 Merge pull request #12885 from mik1893/channel_pushback
Core/Spells: Channeled spell pushback is now affected by haste

Closes #12879
2014-08-23 14:16:22 +01:00
Aokromes
809fb9894e Core/Auctionhouse: Hide known recipes when the Usable box is checked in the AH
By y1x2 @ cmangos

Closes #12247
2014-08-23 14:05:43 +01:00
Duarte Duarte
6dec73f930 Merge pull request #12877 from ShinDarth/tc_fix_escort_quest_group_complete
Core/SmartScripts: fix escort quest group-complete
2014-08-23 14:01:19 +01:00
Duarte Duarte
6d09fed309 Merge pull request #12893 from Ascathor/master
Core/Quest: Allow money reward to be modified.
2014-08-23 13:56:01 +01:00
MitchesD
d109fc0d7c Scripts/SteamVault: Hydromancer Thespia rewritten to BossAI 2014-08-22 16:34:18 +02:00
Ascathor
c644f2f801 Core/Quest: Allow money reward for quests to be modified.
Added a rate for both regular quest reward and for quest reward given on max level. Defaulted to 1.
2014-08-22 02:37:50 +02:00
Dr-J
0c1587cc91 Remove Injured rainspeaker oracle cpp script
Unneeded script
2014-08-21 21:19:36 +01:00
Shauren
abfd29ab61 Core/WorldSession: Added research notes about CMSG_AUTH_SESSION values and reordered checks during login to always initialize encryption first to make sure the client can read failure packet 2014-08-21 18:18:13 +02:00
Duarte Duarte
33da371812 Merge pull request #12813 from MitchesD/misc_2
Scripts/ScarletMonastery: rewritten InstanceScript and some bosses conve...
2014-08-21 14:45:32 +01:00
Shauren
36e32cc242 Core/NetworkIO: Restored opcode and size checks lost during ace->boost changes, fixes crashes caused by players sending invalid opcodes/too big packets 2014-08-19 19:32:06 +02:00
mik1893
f2b5ac87f0 Core/Spells: Channeled spell pushback is now affected by haste 2014-08-19 18:48:58 +02:00
cemak
ecf399e237 Core/Arena: Fix exploit on delete member with team during fights. 2014-08-19 19:26:26 +04:00
ShinDarth
d8b345a5ea Core/SmartScripts: fix escort quest group-complete 2014-08-19 15:57:51 +02:00
Brian Swango
8d92ccd54a Fixed tabs 2014-08-18 20:06:49 -04:00
Brian Swango
87cbe5a2fc Core/Loot: Fixes lootable items being able to be moved in inventory, and
also loot generated that uses conditions from being saved to the DB.
2014-08-18 20:03:13 -04:00
jackpoz
4a3416627d Core/Creatures: Fixed an arithmetic error in respawn code
Creatures should now respawn correctly in their correct time.
Issue was caused by single-precision floating-point format losing precision on lower digits with high numbers, for reference http://docs.oracle.com/cd/E19957-01/806-3568/ncg_goldberg.html
Closes #12428
2014-08-19 00:00:54 +02:00
Zharvek
58c2b66e95 Core/RBAC: Fix RBAC permissions
This commit adds three missing commands to the world.commands table. The RBAC.h file is updated to the correct IDs from the auth.rbac_permissions table and the world.commands table. The RBAC.h file also had to be reordered to keep it clean.

Closes #12854

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-08-18 22:06:06 +01:00
Unholychick
377f385c81 Scripts/Ulduar: Spellscripts for Mimiron
Closes #12579

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-08-18 22:01:47 +01:00
jackpoz
cb53d64191 Merge pull request #12847 from ShinDarth/tc_fix_mount_abuse_after_bg
Core/Battleground: fixed possible mount abuse after leaving BG
2014-08-16 18:17:46 +02:00
ShinDarth
ae97b50af2 Core/Battleground: fixed possible mount abuse after leaving BG 2014-08-16 16:09:05 +02:00
Shauren
7cb72c2aac Core/DBLayer: Fixed an incredibly rare memory leak happening when player started loading from database and never finished 2014-08-16 01:43:42 +02:00
Shauren
5c60976046 Core/Transports: Delayed adding transport model to next tick after teleporting to fix race conditions happening when teleporting transport happens at the same time as destination map balances its dynamic LoS tree 2014-08-16 01:06:30 +02:00
Shauren
acfaf2d182 Core/Misc: Fixed loading trinity_string 2014-08-15 20:01:58 +02:00
Shauren
aab4ab166d Core/Socket: Added helpers to retrieve the size of currently ready data 2014-08-15 18:43:17 +02:00
Shauren
2fdc4723c2 Core/Misc: Optimized locale loading 2014-08-15 11:36:11 +02:00
Vincent-Michael
5b355c57ba Core/Creature: Fix warning 2014-08-14 16:36:04 +02:00
joschiwald
ccfa82e7d5 Core/Creature: update creature_template and some other small things
http://www.trinitycore.org/f/topic/9572-creature-damage/
2014-08-14 16:09:14 +02:00
Jared P. Jones
1b65cda948 Scripts/Icecrown Citadel: The Teleporters in ICC are now Blizzlike *Upon entering the raid, the Lights Hammer teleporter is no longer immediately active. Both the Light's Hammer and the Oratory Portal will pop up after the completion of Lord Marrowgar as it does on official during 3.3.5a. *A teleporter in ICC can no longer teleport you to itself. *There is no longer a reason to allow GMs to use portals without available GOSSIP text and teleport locations. Therefore the teleports now use GO_FLAG_NOT_SELECTABLE when they are unavailable. In the future we can enable GMs to use portals without bosses defeated, however for now all it does is break the instance if some bosses are done out of order. *Currently the Upper Spire teleporter cannot be visited unless the event ColdFlameTraps is completed. This isn't blizz-like. During WotLK retail, the teleporter in the upper spire can be visited once any member has walked over an AreaTrigger which is located the moment you enter the UpperSpire Facade. The cold flame event has nothing to do with the teleporter, the cold flame event instead should be triggered to "DONE" when a rogue instead disarms it. *A bug has been addressed that causes the ColdFlameTraps event to not start back up after a server restart. The event will now restart as long as the player goes through the Saurfang->Upper Spire doorway; I'm not sure who required the doorway to be an area trigger, but it's hacky and not blizzlike. I have not yet addressed the area trigger problem with the doorway in this commit, mainly because the point of this commit is to make the ICC teleporters extremely Blizz-Like. *The "Conspicuous Lever" will now spawn inside of ICC. (From Sniff on Retail) While the lever currently doesn't do anything, in the future it will turn off the ColdFlame Traps. *The teleporter near Saurfang is not supposed to disable during the Intro. It disables whenever Saurfang enters combat with the players. The teleporter then enablers again when combat stops.
Closes #12834
2014-08-14 14:35:47 +02:00
Shocker
07158af425 Core/Spells: Implement SPELL_ATTR7_IGNORE_DURATION_MODS attribute 2014-08-13 03:53:56 +03:00
Shauren
bd4edf6e22 Core/Threading: Fixed possible race condition with m_timeOutTime and fixed Thread #1: pthread_cond_{signal,broadcast}: dubious: associated lock is not held by any thread in PCQ 2014-08-12 18:18:52 +02:00
Dr-J
9f7075215d Remove Manaforges CPP Script
Remove script
2014-08-12 13:36:21 +01:00
Shauren
c741d2682a Core/NetworkIO: Prevent queueing more async operations when socket is already closed 2014-08-11 20:43:07 +02:00
leak
1a27ce1267 Core/NetworkIO: Restore networking related scripting hooks
Closes #12607
2014-08-11 17:40:43 +02:00
leak
528baae5f7 Kill potentially uninitialized variable warning 2014-08-11 14:03:16 +02:00
Shauren
730ca4d9e0 Merge pull request #12818 from MrSmite/pet_spell_cooldown
Fix pet spell cooldown
2014-08-11 09:02:58 +02:00
MitchesD
e80a19a0f1 Scripts/ScarletMonastery: rewritten InstanceScript and some bosses converted to BossAI and eventmap 2014-08-10 23:14:39 +02:00