Commit Graph

14033 Commits

Author SHA1 Message Date
Shocker
e3acb2ecc7 Core/Mail: Fix integer size for Player::_SaveMail() fields 2016-04-04 11:56:52 +03:00
Shauren
2babb00143 Core/Bnet: Add return LoginREST.ExternalAddress when LoginREST.LocalAddress is configured to localhost but client connects from a different machine in the network 2016-04-04 10:01:07 +02:00
Rushor
1bf8e32b40 Merge pull request #16486 from Rushor/spiderman
[3.3.5][6.x]Scripts/Karazhan: Implement Optional Boss Spawn
(cherry picked from commit c8f34656ef)
2016-04-03 20:18:33 +01:00
Vincent-Michael
2a0582c3f2 Core/PacketIO: Updated SMSG_ACCOUNT_HEIRLOOM_UPDATE opcode 2016-04-03 17:12:57 +02:00
Rushor
41385ce633 DB/Quest: King of the Foulweald - Improve Questevent
* closes #2381

(cherry picked from commit 644b9dcd59)
2016-04-02 20:44:51 +02:00
Shauren
3e59899f56 Build fix 2016-04-02 20:06:54 +02:00
Vincent-Michael
e518655b0f Scripts: Fixed warning
(cherry picked from commit 96cb26de28)
2016-04-02 19:40:41 +02:00
Kittnz
b6b151fb1e Build fix
(cherry picked from commit add2179b75)
2016-04-02 19:40:30 +02:00
Kittnz
b535d1e9f3 Pet/Misc: Implement Pandaran Monk followup
(cherry picked from commit 5650b9deb2)
2016-04-02 19:40:15 +02:00
Kittnz
c4b6e08829 Pet/Misc: Implement Pandaran Monk's pet abilitys
(cherry picked from commit 64d1addbbf)
2016-04-02 19:39:23 +02:00
Rushor
c3a2cbc844 Scripts/Northrend: Knockbackimmunity Cleanup
(cherry picked from commit c560cb0a0c)
2016-04-02 19:33:43 +02:00
Incorrect
f8d5031fca Core/Creature: Do not load equipment with id = 1 when creature.equipment_id is 0
Closes #16416

(cherry picked from commit cc3ae640a4)
2016-04-02 19:32:03 +02:00
sirikfoll
7031090dc3 Fix Achievement Defense of the Ancients
The spell that trigger the achievement check, needs to be cast before setting up the variables used for the second round, otherwise the achievement will be granted to the wrong team.
Also, SPELL_END_OF_ROUND needs to be casted on the end of the second round too, this was confirmed in retail.

(cherry picked from commit 5cf794b379)
2016-04-02 19:30:57 +02:00
treeston
ca1239af9f Code style, urand -> urandms.
(cherry picked from commit e064000a35)
2016-04-02 19:26:59 +02:00
Kittnz
422c8a97f6 Fix build & tabs
(cherry picked from commit 57a5879070)
2016-04-02 19:26:46 +02:00
Kittnz
a8504c6730 Pet/Misc: Implement Egbert's running around
Closes #16479

(cherry picked from commit 859b617613)
2016-04-02 19:26:35 +02:00
Vincent-Michael
33593ce0d5 Scripts: Added missing override
(cherry picked from commit d1a185e3d5)
2016-04-02 19:25:43 +02:00
Rushor
92a80979dd Game/Creature: Implement CREATURE_FLAG_EXTRA_IMMUNITY_KNOCKBACK
* updates #16423

(cherry picked from commit 110e0fd092)
2016-04-02 19:24:13 +02:00
Shauren
e6e3e799d0 Build fixes 2016-04-02 19:22:30 +02:00
treeston
9873800207 Item/Misc: Implement Toy Train Set and Wind-Up Train Wrecker.
(cherry picked from commit 8c7cd03d08)
2016-04-02 19:20:17 +02:00
sirikfoll
a962db8b3c Core/Scripts Script npc needed for Quest Torch Tossing part2
Script for Npc Torch Tossing Target_Bunny_Controller, responsable for handle the targets rotation for Midsummer Fire Festival quest, Torch Tossing.

(cherry picked from commit 8b74038531)
2016-04-02 18:32:38 +02:00
pete318
2fe84d7471 Prevent duplicate spawns for same spawn ID
If there is an alive instance of the creature upon creature spawn, skip
spawn entirely. If there are only dead instances, despawn them. A new dead
corpse in the creatures home position will be respawned.

Closes: #16462
(cherry picked from commit fe2a0fda44)
2016-04-02 17:51:03 +02:00
Keader
0a8bab885a Fix cooldown check talent Rapture (Priest)
(cherry picked from commit 7093c0c769)
2016-04-02 17:50:17 +02:00
treeston
02c9a66b88 fix crash
(cherry picked from commit bf31f26e8c)
2016-04-02 17:49:38 +02:00
Trisjdc
a51ec98044 Core/Creatures: Reset unit flags/dynamic flags on Creature::SetDeathState(JUST_RESPAWNED)
(cherry picked from commit 132be2d25a)
2016-04-02 17:49:20 +02:00
tkrokli
0466de43cc Core/Scripts/DB: remove hardcoded text from 'npc_disciple_of_naralex'
- moved 2 #define text lines to enum, already in npc_text
- new gossip_menu_option for NPC 3678 Disciple of Naralex
- using `ADD_GOSSIP_ITEM_DB` instead of `ADD_GOSSIP_ITEM`

Tested on both alliance and horde characters, works just like before.

(cherry picked from commit bc03fedf6d)
2016-04-02 17:36:48 +02:00
treeston
870a76ad10 DB/Creature: Add a new extra_flag CREATURE_FLAG_EXTRA_NO_PLAYER_DAMAGE_REQ (0x00200000) that awards players credit for killing the creature even if less than 50% of damage was dealt by players.
This can be used to fix quests such as "Heated Battle" or "If Valgarde Falls..." that are currently very hard to complete at the appropriate level due to "friendly" NPCs killing off the required targets too quickly for players to get 50% of damage in.

(cherry picked from commit d240ccb38c)
2016-04-02 17:33:31 +02:00
tkrokli
97b70abe54 Core/Scripts/Uldaman: change hardcoded text to enum
Change #define to enum {with brackets}

Possibly the smallest change so far in this series of core script changes.

(cherry picked from commit 627ec0e35e)
2016-04-02 16:47:35 +02:00
treeston
677309743a Scripts/UtgardeKeep: Bonus Ingvar the Plunderer fixes to reset behavior. There should no longer be weirdness if a reset happens during the RP phase.
(cherry picked from commit 815f43be7a)
2016-04-02 16:46:13 +02:00
treeston
61d216593c Scripts/UtgardeKeep: Ingvar updates:
- Roar at start of phase two
- Ingvar no longer does a weird move-jump towards his target when resurrecting
- Fixed a duplicate yell on phase one end

(cherry picked from commit c829fc7de4)
2016-04-02 16:46:01 +02:00
Killyana
31dbb6150d Spell/Script: Safirdrang's Chill
Updates #4841

(cherry picked from commit 789470ccf1)
2016-04-02 16:25:23 +02:00
treeston
9f237e745a Fix warning.
(cherry picked from commit f0b9ee157b)
2016-04-02 15:37:10 +02:00
Shauren
ddb0bc7b6a Scripts/Undercity: Removed obsolete script
Partial cherry pick of 7a101bcf00
2016-04-02 15:35:49 +02:00
jackpoz
9e0491db48 Scripts/Deadmines: Fix issues reported by static analysis
Fix Coverity issue id 1022474

(cherry picked from commit d75469e31f)
2016-04-02 15:32:10 +02:00
Keader
6005b3a5c5 Fix Kinetic Bomb stuck after knockback effect.
(cherry picked from commit 36648d1079)
2016-04-02 15:31:27 +02:00
treeston
76d15c906e Player/Quest: Credit group for gameobject activation if they are in proximity.
(cherry picked from commit cd625a12e2)
2016-04-02 15:31:00 +02:00
P-Kito
cd435b1385 Unit/CalcAbsorbResist: Sanctified Wrath should pierce absorb effects
by P-Kito; retrieved from #15027

The paladin talent Sanctified Wrath should pierce absorb effects.

(cherry picked from commit b8762d8a9f)
2016-04-02 15:30:09 +02:00
tkrokli
50ad1cca00 Core/Scripts/DB: remove hardcoded text from 'npcs_dithers_and_arbington'
- created DB gossip_menu_option entries for both NPCs
- added enum section instead of "magic numbers" in script
- replaced core text with pointers to DB text
- zone_western_plaguelands.cpp is now cleaned up

(cherry picked from commit 29c2a42324)
2016-04-02 15:18:47 +02:00
treeston
3211f639e8 Looting/Group: Do not display looter in tooltip when FFA loot is enabled.
(cherry picked from commit 10482419b7)
2016-04-02 15:00:59 +02:00
Gabriele Gelardi
0d8a73e53c Scripts/Duel: prevent possible abuse in Duel Reset system
(cherry picked from commit c0ed819e0c)
2016-04-02 15:00:32 +02:00
DDuarte
75ff256cc4 Core/SAI: Typo fix of 77087db793
There's no %b, silly

(cherry picked from commit 7a252fc648)
2016-04-02 14:52:27 +02:00
DDuarte
252220ed6e Core/SAI: Code improvements to SMART_ACTION_RANDOM_SOUND
Warning fixes and extra sanity checks

Ref #16376

(cherry picked from commit 77087db793)
2016-04-02 14:52:15 +02:00
Lopfest
c457de1e80 Core/SAI: added SMART_ACTION_RANDOM_SOUND
Closes #16376

(cherry picked from commit e4af2baa7e)
2016-04-02 14:51:13 +02:00
Nick
6e5a129d91 Core/Scripts: Change door ID in Blackwing Lair
as per 7d454c66f7

Change the name as well.

(cherry picked from commit a35a6279fe)
2016-04-02 14:38:48 +02:00
jackpoz
f0bb02d8ee Scripts/Misc: Fix issues reported by static analysis
(cherry picked from commit 0e76d67e49)
2016-04-02 14:38:29 +02:00
joschiwald
9a202dfd4a Scripts/ICC/Teleporter: moved gossips to db
(cherry picked from commit ea38a7d95b)
2016-04-02 14:10:19 +02:00
Saben65
12b7f330c6 Scripts/Zangarmarsh: Removes empty gossip_text that resulted in NPCs saying blank text to players after buffing them
Closes #12697
Closes #16300

(cherry picked from commit ccf3ed40e2)
2016-04-02 13:53:11 +02:00
Shauren
974703671e Core/Items: Fixed enchant visuals
Closes #16776
2016-04-01 22:43:18 +02:00
r00ty-tc
6cd7b58065 Adjustments to spell facing - Adjusted HaveAtClient to accept Object* (still accepts all subordinates) - Use grid searcher to find players in visibility range for unit - Use client cache instead of "See or Detect" to decide who to send updates to - Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
(cherry picked from commit c0693a6ee52d31840ab2ee878c4881884b857638)
2016-04-01 12:43:10 +01:00
Aokromes
8ea8de42ea Core/Misc: Fix log 2016-04-01 04:37:20 +02:00