Commit Graph

20024 Commits

Author SHA1 Message Date
Gacko
e90757f763 Fix non-PCH build.
Even on 3.3.5. What's PCH for?
2017-04-15 12:43:19 +02:00
ariel-
2a04599ed8 Core/Unit: implement miss chance reduction for low level mobs
Source: http://wow.gamepedia.com/index.php?title=Miss&oldid=1980141

> Level is not a factor except when attacking a mob level 9 or lower.
Miss chance against a low-level mob is a percentage of normal equal to the mob’s level divided by 10.
2017-04-14 23:38:54 -03:00
ariel-
9414f50f5c Core/Auras: don't skip stack rule check whenever spells have same ID
- The auras might not have the same amounts due to spellmods

Closes #1626
2017-04-14 19:07:11 -03:00
Shauren
4a40b8ed43 Core/Spells: Name a spell attribute
(cherry picked from commit e88a5e4d6d)
2017-04-14 16:53:59 -03:00
ariel-
d44a44abac Core/Spell: fix broken Unit::GetHighestExclusiveSameEffectSpellGroupValue
- Affects 3 aura effects currently, should be rewritten with GetTotalAuraModifier maybe?
2017-04-14 16:52:28 -03:00
ariel-
841bbd47d7 Core/Entities: fix integer undeflow when calculating skill value difference
Closes #19455
2017-04-14 16:46:24 -03:00
ariel-
abaa9d635a Core/Spell: fix nopch build x2 2017-04-14 04:45:12 -03:00
ariel-
f0a93140e8 Core/Spell: fix nopch build 2017-04-14 04:36:12 -03:00
ariel-
9a05157003 Core/Spell: build fix 2017-04-14 04:26:27 -03:00
ariel-
9900899dd9 Core/Spell: fixed SPELL_GROUP_STACK_RULE_EXCLUSIVE_SAME_EFFECT to actually check effects
- This commit enables stack rule 3 to be properly used to fix auras that should be active but only one providing effects, even if the spell has multiple auras

Closes #19454
2017-04-14 03:47:23 -03:00
ariel-
232e631390 Core/Spell: check aura positivity per effect on spell hit
- Fixes applying DR to positive effects, and changing duration of whole aura

Closes #19447
2017-04-13 03:18:20 -03:00
ariel-
d914c55c05 Core/Player: fix use after free crash 2017-04-12 13:31:11 -03:00
ariel-
83177e771a Core/Spell: fix SPELL_ATTR3_IGNORE_HIT_RESULT bypassing reflects
Closes #19440
2017-04-12 02:53:25 -03:00
ariel-
4c593f12ca Core/Instance: stop updating the instance resettimes based on creature respawns
- Rather update normal instance reset time to 2 hours after last creature kill
- This fixes yet another integer overflow due to the possibility of having time_t max showing up
- Also change respawntime and resettime fields to bigint on respawn/instance related tables
- Start using prepared statements on the InstanceSaveMgr
2017-04-12 02:19:55 -03:00
ariel-
e32a4f26aa Core/Misc: pch fixes pt 2 2017-04-11 23:30:47 -03:00
ariel-
66755eecf1 Core/Creature: fix integer overflow in Creature::Update leading to endless thrashing of characters database
Closes #19182
2017-04-11 23:23:52 -03:00
ariel-
5e0485178d Core/Misc: fix non-pch build 2017-04-11 23:23:02 -03:00
xinef1
9dc3de10f0 Core/Loot: implement Loot Item Storage (#19018)
* Created Item Loot Storage, no more synchronous DB selects
* Fixed buyback case, where stored loot was not removed from db
* Added Primary key, and changed field types to be unsigned for table item_loot_money
2017-04-11 22:22:50 -03:00
Shauren
1787718e25 Core/Random: Remove no longer needed hack for VS 2013
(cherry picked from commit 59fe908744)
2017-04-11 14:31:03 -03:00
ccrs
4d7e7a97b3 Core/Movement: correct no point recalculation on speed change in TargetedMovementGenerator 2017-04-11 15:03:34 +02:00
ariel-
0b50ea072e Core/Unit: fix crash on magic school autoattacks
Closes #19436
2017-04-10 12:17:08 -03:00
ariel-
e565b34f6d Core/Unit: cleanup and minor fixes of miss and resist calculations
- Removed Unit::GetUnitMeleeSkill as it was basically a copy of GetMaxSkillValueForLevel
- Removed static from GetEffectiveResistChance, as this was passed anyways, changed name to CalculateAverageResistReduction, which better reflects what it does
- Fix melee miss chances calculated from attacker maxskill instead of victim maxskill
- Do actual checks if spell can be resisted/missed in MagicSpellHitResult (ie chances > 0)
- Fixed SPELLMOD_RESIST_MISS_CHANCE calculation in MeleeSpellMissChance
- Minor codestyle and cleanup of diminishing returns calcs
2017-04-10 04:50:09 -03:00
ariel-
e478434146 Core/Misc: fix static analysis issues
CID 1373466
CID 1373481
CID 1373482
2017-04-09 19:18:22 -03:00
ariel-
214b8e53c5 Core/Quest: fix RewardNextQuest being used to condition previous quests in chain 2017-04-09 18:43:35 -03:00
Keader
2921449a33 Core/Scripts: Baltharus the Warborn preincrement _cloneCount 2017-04-09 09:25:58 -03:00
ccrs
46221b6dc1 Core/Movement: FormationMovementGenerator
Use own movement generator for creatures following on a formation.
First step of implementation, huge room for improvement.

Closes #19422
2017-04-09 14:13:29 +02:00
ariel-
70c4a37544 Core/Achievement: fix bad lookup of ACHIEVEMENT_CRITERIA_DATA_TYPE_S_EQUIPPED_ITEM item
Closes #19064
2017-04-08 16:21:16 -03:00
jackpoz
3c4c67160a Core/Misc: Fix static analysis issues 2017-04-08 20:59:48 +02:00
Keader
164af391c9 Core/Spells: Fixed Chilled to the Bone
Closes #19417
thanks ariel-
2017-04-07 17:41:43 -03:00
ccrs
21b8c4997a [3.3.5] Core/Movement: MotionMaster & MovementGenerators cleaning (#19361) 2017-04-07 21:35:23 +02:00
ariel-
5cb1555de6 Core/Player: fix weapon dependent aura talents not applied on talent learn
Closes #19408
2017-04-06 20:38:27 -03:00
ariel-
ab5920fc1c Core/GameObject: fix unitialized member on GameObjectData 2017-04-04 17:24:34 -03:00
ariel-
8cc140d17b Core/Creature: fix uninitialized member on CreatureData
Closes #19405
2017-04-04 16:43:18 -03:00
ariel-
ae9995f463 Core/Auction: wrap item deletions from AHBot auction on a transaction
This speeds up the query execution time tremendously
Refs #19182
2017-04-03 22:44:14 -03:00
Keader
58f2e62098 Core/Scripts: Baltharus the Warborn make clone count more readable
*Also fixed issue that make Baltharus summons alot of clones when he is casting
2017-04-03 10:02:13 -03:00
ariel-
4a654be2fb Core/AHBot: fix price calc
- priceRatio is already a factor
2017-04-03 05:42:12 -03:00
ariel-
c36854677c Core/AHBot: fixed assert check 2017-04-03 04:46:39 -03:00
ariel-
1ca8434b36 Core/Spell: don't set scaleAura for some special spells
Closes #14541
2017-04-03 04:04:02 -03:00
ariel-
e594c2d096 Core/AHBot: fix a typo 2017-04-03 03:53:50 -03:00
ariel-
7f8bfe68d0 Core/AHBot: Refactor of AuctionHouseBotSeller:
- Use AuctionHouseBot.Class.* for what they really are, priorities, factor them when calculating item amount per class, changed enums to CONFIG_AHBOT_CLASS_*_PRIORITY to reflect this change
- Don't factor in the priority calc empty item lists:
  * Let's say you had AuctionHouseBot.Class.Glyph set to 10, sum of AuctionHouseBot.Class.* is 20, and AuctionHouseBot.Items.Amount.White is 5000
  * If there were no glyphs on the item list, you automatically lost 50% of the total item amount, meaning only 2500 of original 5000 were alloted to fill
- Fixed AuctionHouseBot.AH.Price.Ratio to be an actual percentage factor

- Separated containers in SellerConfiguration, each one better reflects what kind of data is stored there, now we won't use magic index 0 from _ItemInfo :P
- General cleanup, removal of bad voodoo and magical numbers
- Use unordered_sets for loading item lists, as they were only used to check for item presence
2017-04-03 03:29:29 -03:00
ariel-
008ddbf197 Core/Scripts: fix Judgement of Wisdom mana return
Closes #19400
2017-04-03 00:51:56 -03:00
Keader
270a639678 Core/Scripts: Fixing Carbonion/Travis 2017-04-02 11:14:24 -03:00
Keader
6b8c4fb74f Core/Scripts: Fixed Baltharus the Warborn clones
*Clones not working after wipe
*Changed Clone Action for a event (to check casting)
2017-04-02 11:08:29 -03:00
Keader
a2a8ffe723 Core/Scripts: Typo in last commit 2017-04-01 21:18:15 -03:00
Keader
8d198cb360 Core/Scripts: Fixed Volatile Ooze/Gas Cloud issues in Professor Putricide
Closes #18925
2017-04-01 21:16:55 -03:00
S.V
f3d795d8dd Core/ScriptReloadMgr: Fixed scripts hot swapping on OS X (#19365) 2017-03-31 23:10:18 +02:00
ariel-
006e90339e Revert "Core/Battlegrounds: disable health regen for battleground vehicles (#19183)"
This reverts commit 85af0a0630.
2017-03-31 02:18:46 -03:00
ariel-
dafa726773 Core/Scripts: Fix a logic fail that overriden the script of an entity that changed entry
Closes #19389
2017-03-31 01:58:15 -03:00
Gustavo
85af0a0630 Core/Battlegrounds: disable health regen for battleground vehicles (#19183)
Updates issue #950
2017-03-29 11:28:06 +02:00
tkrokli
f6f36be004 Scripts: minimize duplicated enum names in header files (#19377)
* Scripts: Minimize duplicated enum names in header files

This reduces the number of cache resets with the Zapcc compiler

- Standard followed is instance/raid TLA + DataTypes/CreaturesIds/etc
- Partial cherry-pick of master commit 7eb4512eee
- Removed unused defines in sunken_temple.h (the core scripts using these have been moved to SAI)
2017-03-29 10:06:06 +02:00