Commit Graph

82 Commits

Author SHA1 Message Date
megamage
e954904e6d [8378] Use exceptions instead of explicit size checking for each packet Author: arrai
CHECK_PACKET_SIZE was pretty error prone; once it was forgotten mangosd
    could crash due to the asserts in ByteBuffer.h. That was exploitable by
    malicious players.
    Furthermore, there were duplicate checks: Additionally to
    CHECK_PACKET_SIZE, the ByteBuffer assertions keept an eye
    on not exceeding the packet boundaries - just to crash the server for
    sure in such a case.
    To prevent memory leaks or other undesirable states, please read in
    every handler all variables _before_ doing any concrete handling.

--HG--
branch : trunk
2009-08-19 16:26:22 -05:00
megamage
7ca0f5b721 *Fix the crash caused by client customize log.
--HG--
branch : trunk
2009-08-16 16:32:11 -05:00
maximius
2fd68eab44 *Add Dual Spec support, original by EnderGT, thanks to Thyros and XTElite1 for helping me test :)
--HG--
branch : trunk
2009-08-14 17:24:52 -07:00
megamage
6890d8aedb *Log old name for customize request
--HG--
branch : trunk
2009-08-14 18:55:35 -05:00
megamage
4f4775a31b [8339] Improved storing/restoring BG entry point
* Introduced new table character_battleground_data
    * Entry point is now stored on BG enter event not join event
    * Entry point for dungeons is now correctly set to nearest graveyard
      (this prevent well known assert in GetInstance because of porting to already destroyed instance)
    * Teleporting from BG correctly restore mount state
    * Teleporting from BG correctly restore taxi flight
      (in multipath flight you will end up in nearest transition point on the route)

    Signed-off-by: ApoC <apoc@nymfe.net>

--HG--
branch : trunk
2009-08-12 20:27:00 -05:00
QAston
bee1dff87f *Use #defines instead of spellids for often used spells.
*Make recently broken talent Improved Healthstone work again - by iadus3.

--HG--
branch : trunk
2009-08-12 18:51:19 +02:00
megamage
47e36000cb [8304] Move standup code to login, remove other not needed data change at save. Author: VladimirMangos
Now players saved as-is without any modifications.

--HG--
branch : trunk
2009-08-05 16:03:33 -05:00
megamage
793ec8c97d [8286] Correctly show talent points after talents reset at login by "at login" flag. Author: redcore
--HG--
branch : trunk
2009-08-02 10:11:48 +08:00
QAston
1d96091d2a *Improvements in map managing.
--HG--
branch : trunk
2009-08-01 00:20:32 +02:00
megamage
0fcadd9d25 *Replace "LoginDatabase" with "loginDatabase"
--HG--
branch : trunk
2009-07-31 11:29:28 +08:00
megamage
6976043e22 [8126] Improvemets in player/pet/charter name checks. Author: VladimirMangos
* Implement new config options for minimal player/pet/charter name length (2 by default)
    * Better error reporting at problems in names.
    * Add check from max pet/charter name length (same as for player names at client side)

--HG--
branch : trunk
2009-07-10 08:25:33 +08:00
megamage
e1d93bd00f *Backup your DB!
[8098] Support uint32 spell ids in code. Author: VladimirMangos

    * Propertly work with uint32 spell ids in player action bar
    * Fix in same time bug with not save equipment set button with id==0
    * Merge misc field in character_action and playercreateinfo_action to action field as 3 byte
    * Propertly load uint32 spell ids from character_spell
    * Fixed types for some pet/creature related structure for spell id storing.

--HG--
branch : trunk
2009-07-01 18:07:20 -05:00
megamage
d9ec2d2196 [8072] First step to get rid of data blob.
Adds new fields gender, level, xp, money, playerBytes, playerBytes2 and playerFlags to characters table.

    The update will not work if your database contains characters with an old data field (not fitting to the actual client version).

    It's recommended to backup your character database before applying this patch.

--HG--
branch : trunk
2009-06-27 17:39:51 -05:00
QAston
ad91c6b1e2 [8052] Fixed typo in error log output. Author: The_Game_Master
[8049] Added energize effect after last heal tick for 33763 and ranks. Author: bobaz
[8053] At character talents reset using chat command also reset talents
for all character pets. Author: VladimirMangos

--HG--
branch : trunk
2009-06-23 13:05:15 +02:00
megamage
572a9191d9 *Some creature display id update. By VladimirMangos and GriffonHeart
--HG--
branch : trunk
2009-06-15 18:02:12 -05:00
megamage
9d670fe6f5 *Switch to support client version 3.1.3
*I strongly recommend you not to use this until you get the 313 db. Now all destructible buildings cause client crash.

Source: Mangos
Thanks to TOM_RUS for most work to make this switch possible ;)

--HG--
branch : trunk
2009-06-11 00:45:59 -05:00
megamage
ebfb4c0558 [7971] Implement support exotic pets limtations related to hunter telent 53270. Author: VladimirMangos
Note: before this commit hunters can tame exotic pets like any other.
          After patch like not propertly contriolled pets will auto-dismiss at loading
          if talent not learned.

--HG--
branch : trunk
2009-06-06 20:31:23 -05:00
panaut0lordv
f6447e8f34 *Including style fixing - part 1
--HG--
branch : trunk
2009-06-04 21:41:07 +02:00
megamage
f92e8315cf [7918] Improve portability in work with uint64 string format specifiers and in code literals. Author: VladimirMangos
* Replace platform seelction MaNGOS code for select format descriptor for uint64 by using ACE define.
      I64FMTD renamed to UI64FMTD for more clear name.
    * Add new define UI64LIT (base at ACE seelction) for build portables uint64 literals.
      Please always use UI64LIT(0x00001) instead less portable 0x00001LL

--HG--
branch : trunk
2009-05-31 16:15:12 -05:00
megamage
5ed5513ca8 Mangos [7911]. Author: tomrus88
Very big patch. May cause bugs.

--HG--
branch : trunk
2009-05-31 15:56:51 -05:00
megamage
ce0feb36ea [7841] Fixed: Prevent loading maps/vmaps when building enum. Author: SilverIce
--HG--
branch : trunk
2009-05-17 18:41:16 -05:00
megamage
e4456ae9f8 *Fix an exploit that instance can be reset when there are logged-out players in it.
--HG--
branch : trunk
2009-05-16 14:52:41 -05:00
megamage
9831dab114 [7822] Avoid declined names form show in case disabled config option with russian client at non-russian realm. Author: Foks
--HG--
branch : trunk
2009-05-14 11:59:15 -05:00
megamage
f5bae4d5ae *Init player motionmaster after field value are initialized.
--HG--
branch : trunk
2009-05-09 10:48:55 -05:00
megamage
7277ddd114 [7797] Use DBC data for mount model selection in more cases. Author: VladimirMangos
* Use alt.team mount data for take player team model id if DB not provide own team creature id in spell taxi call case.
    * Remove unddeded hacks for model ids from Spell::EffectSendTaxi
    * Provide spell target for SPELL_EFFECT_SEND_TAXI for spell with target mode 0 for this effect.

--HG--
branch : trunk
2009-05-08 18:49:07 -05:00
megamage
de11b9e901 [7730] Some optimizantion and code style. Author: zhenya
--HG--
branch : trunk
2009-04-29 00:26:07 -05:00
megamage
3120221deb *Note: this patch may do not have any use for TC.
[7645] Fixed problems wit temporary unsummoned pets and cleanup code. Author: VladimirMangos

    * Save temporary unsummoned pet to current slot (instead non_in_slot mode) and
      prevent save as current pet summoned while temporay unsummon (arena)
    * Prevent overwrite temporary summoned pet data
    * At player loading set temporary unsummoned pet data instead pet loading
      if pet expected to be temporary unsummoned in current player state (loading in taxi flight/etc)
    * Restore proper pet at arena leave and unsummon in arena summoned.

--HG--
branch : trunk
2009-04-11 14:47:38 -05:00
megamage
4d277430c5 [7644] Fixed pet slot values using in pet save. Author: VladimirMangos
Problem exist from client version switch when stable slot amount changed.
    In result this has been source problems with stable use (3-4 slots) and possible pet lost in some cases
    or "not save state" for summoned pets.
    Use enums to avoid repeating problem, use more safe value for not-in-slot save (for summoned pets)
    Fixed data preparing for MSG_LIST_STABLED_PETS.

--HG--
branch : trunk
2009-04-10 18:18:44 -05:00
megamage
5acc0c057b [7612] Move SMSG_TRIGGER_CINEMATIC and SMSG_TRIGGER_MOVIE to functions and use its instead explicit packet creating. Author: NoFantasy
--HG--
branch : trunk
2009-04-05 16:25:00 -05:00
QAston
20c02ef760 *Update of aura system.
--HG--
branch : trunk
2009-04-06 13:31:14 +02:00
megamage
68c3039715 *Move most reputation/force faction reaction code to new ReputationMgr. Author: VladimirMangos
--HG--
branch : trunk
2009-03-26 13:53:32 -06:00
megamage
2106e9f257 [7539] Fixed log output Author: AlexDereka
--HG--
branch : trunk
2009-03-25 16:07:19 -06:00
megamage
02440eaa10 [7538] Hide some implementation details for reputation/forced faction reaction. Author: VladimirMangos
--HG--
branch : trunk
2009-03-25 16:04:08 -06:00
megamage
42d5b79eea [7508] Revert to "check first, proccess later" code style in WorldSession::HandleRemoveGlyph. Author: VladimirMangos
--HG--
branch : trunk
2009-03-21 14:54:21 -06:00
megamage
de849cc508 Small code cleanup and partial merge with dev branch Author: tomrus88
--HG--
branch : trunk
2009-03-21 14:53:38 -06:00
megamage
4776c384aa *Fixed :customize characters. By GriffonHeart.
--HG--
branch : trunk
2009-03-20 14:28:45 -06:00
megamage
328345ac1a [7403] much more unneeded includes removed Author: balrok
--HG--
branch : trunk
2009-03-08 13:05:56 -06:00
megamage
ae55745f2a [7378]~[7381] achievement code update. Author: VladimirMangos
--HG--
branch : trunk
2009-03-05 09:22:43 -06:00
megamage
699bc588b8 [7330] Code warnings and style cleanups. Some bugs fixes. Author: VladimirMangos
1) comparison singed and unsigned values
    2) redundent includes
    3) wrong constructor :-part field initilization
    4) unused not-/*name*/-guarded args in template/virtual functions that not required like args.
    5) explicitly list not implemented achievement types.

    Also bugs fixed:
    1) Drop wrong phase mask 0 check in WorldObject::InSamePhase.
    2) ArenaTeamMember::ModifyPersonalRating incorrect work with move points in negative with infinity values in result.
    3) ArenaTeam::SaveToDB code send uint64 value to string with arg format %u.

--HG--
branch : trunk
2009-02-24 11:14:28 -06:00
megamage
ed5b3780ed [7323] Character Customize should not force rename. Author: aerione_alt
--HG--
branch : trunk
2009-02-22 17:26:03 -06:00
megamage
53d0bf87ad *Fix build.
--HG--
branch : trunk
2009-02-19 22:30:30 -06:00
panaut0lordv
966b6a4a8d Fix build
--HG--
branch : trunk
2009-02-18 22:39:00 +01:00
megamage
31637d4aac *Merge.
--HG--
branch : trunk
2009-02-18 11:36:19 -06:00
KingPin
14234c86fa Newline added to bottom of all files.
--HG--
branch : trunk
2009-02-17 20:07:49 -06:00
megamage
6aee5fcbe7 *Merge.
--HG--
branch : trunk
2009-02-12 17:09:15 -06:00
megamage
029554d4e3 [7255] Allows saving characters in Battle Grounds.
* Now player can join to BG after logout during 5 minutes, if BG in progress.
    * All players after server crash or restart should appear at the battlemaster

Author: GriffonHeart

--HG--
branch : trunk
2009-02-10 01:16:16 -06:00
Paradox
d230302b16 Replace tabs with spaces in more files.
--HG--
branch : trunk
2009-02-09 08:16:34 -05:00
Drahy
5dab980495 * Updated copyright notice for new year (2009) part 2
* Changed mangos website

--HG--
branch : trunk
2009-02-04 12:42:26 +01:00
Drahy
7c19c420c6 * Updated copyright notice for new year (2009) part 1 - Mercurial cant convert all files at once
--HG--
branch : trunk
2009-02-04 12:04:12 +01:00
megamage
ab4b9160f2 *Update to Mangos 7151.
--HG--
branch : trunk
2009-01-22 22:44:27 -06:00