Xanadu
eb1b037611
Core/Spell: * Removed proc overrides for some AoE spells that really shouldn't be there on WotLK. Fixes all Improved Blizzard procs and breaking stealth by Blizzard, Volley, Hurricane, RoF.
...
* Closes issue #3100 . Closes issue #3711 . Makes dr.tenma smile.
--HG--
branch : trunk
2010-09-29 01:50:07 +02:00
Shauren
fe84720720
Core/Spells: Fixed compile warnings added in previous revision
...
--HG--
branch : trunk
2010-09-28 18:57:19 +02:00
Shauren
956f9115dc
Core/Spells: Moved checking if item has USE: effect to Spell::CheckItems (from effect handler), also generates blizzlike error message now
...
--HG--
branch : trunk
2010-09-28 18:50:38 +02:00
Shocker
f106db551b
Forgotten file from previous commit regarding magic numbers cleanup
...
--HG--
branch : trunk
2010-09-28 08:41:24 +03:00
linencloth
a582ab9d9d
Core/Spells: Allow AoE spells to target dead units.
...
Also removes some unneeded checks from ally targeting.
--HG--
branch : trunk
2010-09-15 06:33:38 +02:00
Shocker
cdd8f446fa
Core/Spells: combo points requirement should be changed before CheckCast
...
--HG--
branch : trunk
2010-09-14 13:28:25 +03:00
Shocker
5e7bec0268
Core/Spells: Triggered spells should ignore combo points check, fixes issue 4006
...
--HG--
branch : trunk
2010-09-14 12:56:32 +03:00
Shocker
cbe95da41a
Core/Spells: Correct meaning & usage of SPELL_ATTR_EX2_NOT_RESET_AUTOSHOOT (now SPELL_ATTR_EX2_NOT_RESET_AUTO_ACTIONS) to ignore timer reset for both melee swings and ranged autoshoots, fixes issue 2639
...
--HG--
branch : trunk
2010-09-12 23:52:37 +03:00
click
bf664b7a44
Cleanup/Core: Remove whitespace and tabs
...
--HG--
branch : trunk
2010-09-12 01:40:27 +02:00
Shocker
61075d5101
Core/Spells: Correct check for starting cast while moving, thanks havenard for pointing out, fixes issue 3913
...
--HG--
branch : trunk
2010-09-10 15:51:31 +03:00
Shocker
a0ffc6ab86
Core/Spells: Triggered spells should be ignored when checking death state at spell cast, fixes issue 3914
...
--HG--
branch : trunk
2010-09-09 15:44:24 +03:00
Shauren
5c13a08d87
Core/Spells: Fixed The Art of War procing only on melee attacks, by tassader1000
...
Core/Spells: Added missing change in previous revision
Closes issue #2386 .
--HG--
branch : trunk
2010-09-08 11:22:51 +02:00
Shauren
e5d612d339
Core/Spells: Fixed Taste for Blood and Glyph of Overpower after recent combo point changes
...
--HG--
branch : trunk
2010-09-08 10:59:10 +02:00
Shocker
01c2a6d87c
Core/Spells: Don't allow most spells to be casted while dead
...
--HG--
branch : trunk
2010-09-08 07:01:55 +03:00
Shocker
96812cfa27
Core/Spells: Fix ammo depletion handling
...
--HG--
branch : trunk
2010-09-08 05:39:24 +03:00
Shocker
948c1f0fd6
Core/Spells: Add server-side check for not allowing non-instant spells with movement interrupt flag to be casted while moving
...
--HG--
branch : trunk
2010-09-08 04:15:41 +03:00
Shocker
5f3ec4366d
Core/Spells: Add server-side check for spells that require combo points to prevent exploits
...
--HG--
branch : trunk
2010-09-08 01:35:36 +03:00
Shauren
14c8fa4925
Core/Spells: Fixed Nevermelting Ice Crystal trinket
...
--HG--
branch : trunk
2010-09-05 13:39:10 +02:00
silinoron
1e1c596dda
Core/WorldPacket: Fix the core spamming complaints about CMSG_QUEST_QUERY being sent post-logout
...
Core/Spells: A little bit of "cleanup"
--HG--
branch : trunk
2010-09-03 20:30:29 -07:00
silinoron
d2c259fe76
Core/ScriptSystem: Add a PlayerScript::OnSpellCast(Player *player, Spell *spell, bool skipCheck) function.
...
Requested by Zor.
--HG--
branch : trunk
2010-09-03 19:58:16 -07:00
QAston
a8de57559b
*Allow channeled spells to be casted on dead target
...
*Define relted spell attributes
--HG--
branch : trunk
2010-08-30 17:32:51 +02:00
Spp
405f312918
Core: Fix more warnings
...
--HG--
branch : trunk
2010-08-30 15:25:15 +02:00
QAston
2d877bbbfd
*Allow damage shield hits to miss.
...
*Send overkill on damage shield hit.
*Correct data order for execute log of power take effects.
--HG--
branch : trunk
2010-08-29 03:38:21 +02:00
Shocker
f89a27dc98
Make sure crafting spells with non-random loot are not allowed to be casted if inventory is full. Fixes issue #2791
...
--HG--
branch : trunk
2010-08-28 02:20:26 +03:00
QAston
5eb7e80fd5
*Send VICTIMSTATE_INTACT on melee attack miss.
...
*Rename VICTIMSTATE_NORMAL to VICTIMSTATE_HIT.
*Set default memory allocated in Spell::InitExecuteLogData to 32 bytes.
--HG--
branch : trunk
2010-08-27 23:12:52 +02:00
QAston
36640c263a
*Consistent parameter names of spell effect handlers - use effIndex instead of i or eff_idx or variations of it.
...
--HG--
branch : trunk
2010-08-27 19:36:27 +02:00
Shauren
5fbc8f1de4
Scripts/Icecrown Citadel: Added hacky workaround for teleporting spells because their default target is not supported by current grid system
...
Scripts/Icecrown Citadel: Mark Gunship event as complete on Lady Deathwhisper's death (temporary, until transport system will fully allow scripting the event)
--HG--
branch : trunk
2010-08-27 18:11:21 +02:00
QAston
f1d4933dcb
*Fix combat logging of many spell effects - thanks to kiper, Ssp, Cyrax, and manuel for providing data and to Zor for inspecting opcodes.
...
--HG--
branch : trunk
2010-08-27 17:49:32 +02:00
QAston
c1ac063ba1
*Remove m_currentBasePoints from spell class, use m_spellValue instead.
...
--HG--
branch : trunk
2010-08-27 06:40:23 +02:00
QAston
1d3deae555
*Send to client periodic heal absorbtion.
...
*Heal over time spells are updating healing achievement progress now.
--HG--
branch : trunk
2010-08-27 01:13:27 +02:00
QAston
30d31ca40a
*Fix usage of EffectValueMultiplier in spell code.
...
*Remove some obsolete code from spell class.
*Rename some spellmod and dbc column names to be more accurate.
--HG--
branch : trunk
2010-08-26 19:07:55 +02:00
Shauren
73d3f210a9
Scripts/Icecrown Citadel: Add script for Deathbringer Saurfang (only missing alliance outro due to need of spawning and moving a transport)
...
Scripts/Icecrown Citadel: Corrected Lord Marrowgar, should no longer target tanks with Bone Spike Graveyard, his Coldflame should now spread properly
Core/Scripts: Moved Lady Deathwhisper Mana Barrier handler to scripts
Core/Scripts: Allow AuraScript to prevent default effects by effect index
Core/Scripts: Added Is25ManRaid() method to ScriptedAI, obviously used to check if raid is 25man
Core/Achievements: Pass m_caster to UpdateAchievementCriteria for ACHIEVEMENT_CRITERIA_TYPE_BE_SPELL_TARGET
--HG--
branch : trunk
2010-08-21 20:50:38 +02:00
azazel
5fa14f58dc
Core/Cleanup:
...
* move repeating code into separate method for storing locale strings in ObjectMgr (copy/paste sucks, you know)
* fix 'signed/unsigned' warnings (at least in VS)
* fix some other warnings and cleanup relative code
--HG--
branch : trunk
2010-08-26 15:54:56 +06:00
azazel
341e6303ef
Core:
...
* add helping methods for manipulating unit's health and use it where applicable
* fix some conversion warnings and cleanup code (formatting, CRLF, tabs to spaces)
--HG--
branch : trunk
2010-08-26 01:20:57 +06:00
QAston
07a3a1254b
*Add AuraScript class for scripting aura objects - scripts are registered same way as SpellScripts, bound to SpellScriptNames table. For more details see example_spell.cpp and SpellScript.h
...
*Rename SpellHandlerScript to SpellScriptLoader, EffectHandlerFn to SpellEffectFn, HitHandlerFn to SpellHitFn, SpellScript::EffectHandlers to SpellScript::OnEffect, these changes were neccesary to prevent namespace collisions, happily you can solve these by simple find and replace
*Make spells 66244 and 5581 example scripts.
--HG--
branch : trunk
2010-08-24 00:10:49 +02:00
silinoron
5cbae843d5
Core/Game: fix all warnings related to converting doubles and floats.
...
--HG--
branch : trunk
2010-08-22 12:39:39 -07:00
click
670964803f
Core: Fix more warnings, add new function sLog.outStaticDebug() that replaces DEBUG_LOG
...
--HG--
branch : trunk
2010-08-22 01:57:04 +02:00
Spp
a136403dee
Core: Remove "suggest parentheses around ‘&&’ within ‘||’" and "suggest parentheses around assignment used as truth value" warnings
...
--HG--
branch : trunk
2010-08-21 21:54:41 +02:00
Spp
c15c605a11
Core: Remove "unused variable 'xxx'" warnings
...
--HG--
branch : trunk
2010-08-21 21:14:35 +02:00
Spp
e7856a831c
Core: Remove "enumeration value 'xxx' not handled in switch" warnings
...
--HG--
branch : trunk
2010-08-21 20:55:31 +02:00
QAston
77bd968c63
*Remove some unused containers from Spell class.
...
--HG--
branch : trunk
2010-08-21 21:00:06 +02:00
Spp
c3343638cb
Core: Remove lots warnings:
...
- All "'xxx' will be initialized after 'yyy' when initialized here"
- Some "unused variable"
- Some "enumeration value 'xxx' not handled in switch"
--HG--
branch : trunk
2010-08-21 20:08:47 +02:00
QAston
6714feb3ee
*Add script hooks for SpellScript class - now you can use BeforeHit, OnHit, AfterHit hook lists.
...
--HG--
branch : trunk
2010-08-21 20:18:54 +02:00
QAston
30bcf8c659
Scripts/Spell: extend SpellScript class: add target aura accessors and functions which prevent various effects of the spell from being executed. Check out SpellScript.h for details
...
--HG--
branch : trunk
2010-08-19 14:31:31 +02:00
azazel
d4605c5f7f
Fix (in theory) bug (already tapped error) for spells with banish mechanics (Banish, Cyclone).
...
Closes issue #1945 .
Closes issue #2402 .
--HG--
branch : trunk
2010-08-19 16:20:06 +06:00
QAston
5e78e222c1
Core/Spells: Implement TARGET_DEST_CHANNEL_CASTER(106) and TARGET_GAMEOBJECT_AREA_PATH(108). Rename TARGET_UNIT_CHANNEL to TARGET_UNIT_CHANNEL_TARGET, TARGET_DEST_CHANNEL to TARGET_DEST_CHANNEL_TARGET
...
--HG--
branch : trunk
2010-08-18 15:04:00 +02:00
QAston
0284ed4cfe
*Core/Spells: Implement TARGET_UNIT_SUMMONER
...
*Rename TARGET_UNIT_MINIPET to TARGET_UNIT_TARGET_PUPPET.
--HG--
branch : trunk
2010-08-17 20:19:06 +02:00
click
3d48c480ce
Fix: append a .c_str() on a variable in Spell.cpp (no more grumpy compilers) - Thanks to StormByte for the heads up
...
Fixes issue 3343
--HG--
branch : trunk
2010-08-09 20:20:55 +02:00
QAston
fa8a826656
*(More) correct implementation of SPELL_EFFECT_PULL_TOWARDS_DEST(145)
...
--HG--
branch : trunk
2010-08-09 02:31:42 +02:00
QAston
617a56ba29
*Implement spell casting on transports (no more out of range error, etc)
...
*Add MO transports to ObjectAccessor storage
*Add functions Position::RelocateOffset and Position::GetPositionOffsetTo to help offset manipulations - BIG thanks to azazelkon for creating formulas!
*Add function to output debug info for MovementInfo and SpellCastTargets
*Throw ByteBufferException on incorrect packGUID read
*Add rfinish function to finish bytebuffer read.
--HG--
branch : trunk
2010-08-08 20:32:14 +02:00