mirror of
https://github.com/TrinityCore/TrinityCore.git
synced 2026-01-20 01:15:35 +01:00
3c6dc32030
- Rewrite Field class to be able to store both binary prepared statement data and data from adhoc query resultsets
- Buffer the data of prepared statements using ResultSet and Field classes and let go of mysql c api structures after PreparedResultSet constructor. Fixes a race condition and thus a possible crash/data corruption (issue pointed out to Derex, basic suggestion by raczman)
- Conform PreparedResultSet and ResultSet to the same design standards, and using Field class as data buffer class for both
* NOTE: This means the fetching methods are uniform again, using ¨Field* fields = result->Fetch();¨ and access to elements trough fields[x].
* NOTE: for access to the correct row in prepared statements, ¨Field* fields = result->Fetch();¨ must ALWAYS be called inside the do { }while(result->NextRow()) loop.
* NOTE: This means that Field::GetString() returns std::string object and Field::GetCString() returns const char* pointer.
Still experimental and all that jazz, not recommended for production servers until feedback is given.
--HG--
branch : trunk
60 lines
1.7 KiB
C++
60 lines
1.7 KiB
C++
/*
|
|
* Copyright (C) 2008-2010 Trinity <http://www.trinitycore.org/>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include "Field.h"
|
|
|
|
Field::Field()
|
|
{
|
|
data.value = NULL;
|
|
data.type = MYSQL_TYPE_NULL;
|
|
data.length = 0;
|
|
}
|
|
|
|
Field::~Field()
|
|
{
|
|
CleanUp();
|
|
}
|
|
|
|
void Field::SetByteValue(void* newValue, const size_t newSize, enum_field_types newType, uint32 length)
|
|
{
|
|
// This value stores raw bytes that have to be explicitly casted later
|
|
if (newValue)
|
|
{
|
|
data.value = new char [newSize];
|
|
memcpy(data.value, newValue, newSize);
|
|
data.length = length;
|
|
}
|
|
data.type = newType;
|
|
data.raw = true;
|
|
}
|
|
|
|
void Field::SetStructuredValue(char* newValue, enum_field_types newType, const size_t newSize)
|
|
{
|
|
// This value stores somewhat structured data that needs function style casting
|
|
if (newValue)
|
|
{
|
|
size_t size = strlen(newValue);
|
|
data.value = new char [size+1];
|
|
strcpy(data.value, newValue);
|
|
data.length = size;
|
|
}
|
|
|
|
data.type = newType;
|
|
data.raw = false;
|
|
}
|