mirror of
https://github.com/TrinityCore/TrinityCore.git
synced 2026-01-16 07:30:42 +01:00
89af6097f3
In case of dynamic file names don't store the FILE* handle in a shared class variable but keep it only at function scope. Valgrind log: at _IO_un_link (genops.c:69) by fclose@@GLIBC_2.2.5 (iofclose.c:55) by AppenderFile::CloseFile() (AppenderFile.cpp:94) by AppenderFile::_write(LogMessage const&) (AppenderFile.cpp:66) by Appender::write(LogMessage&) (Appender.cpp:102) by Logger::write(LogMessage&) const (Logger.cpp:63) by Log::write(LogMessage*) (Log.cpp:279) by Log::vlog(std::string const&, LogLevel, char const*, __va_list_tag*) (Log.cpp:267) by Log::outMessage(std::string const&, LogLevel, char const*, ...) (Log.h:129) Address 0x2a1bd2d0 is 0 bytes inside a block of size 568 free'd at free (vg_replace_malloc.c:468) by fclose@@GLIBC_2.2.5 (iofclose.c:85) by AppenderFile::CloseFile() (AppenderFile.cpp:94) by AppenderFile::_write(LogMessage const&) (AppenderFile.cpp:66) by Appender::write(LogMessage&) (Appender.cpp:102) by Logger::write(LogMessage&) const (Logger.cpp:63) by Log::write(LogMessage*) (Log.cpp:279) by Log::vlog(std::string const&, LogLevel, char const*, __va_list_tag*) (Log.cpp:267) by Log::outMessage(std::string const&, LogLevel, char const*, ...) (Log.h:129)
103 lines
3.1 KiB
C++
103 lines
3.1 KiB
C++
/*
|
|
* Copyright (C) 2008-2014 TrinityCore <http://www.trinitycore.org/>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "AppenderFile.h"
|
|
|
|
#if PLATFORM == PLATFORM_WINDOWS
|
|
# include <Windows.h>
|
|
#endif
|
|
|
|
AppenderFile::AppenderFile(uint8 id, std::string const& name, LogLevel level, const char* _filename, const char* _logDir, const char* _mode, AppenderFlags _flags, uint64 fileSize):
|
|
Appender(id, name, APPENDER_FILE, level, _flags),
|
|
logfile(NULL),
|
|
filename(_filename),
|
|
logDir(_logDir),
|
|
mode(_mode),
|
|
maxFileSize(fileSize),
|
|
fileSize(0)
|
|
{
|
|
dynamicName = std::string::npos != filename.find("%s");
|
|
backup = (_flags & APPENDER_FLAGS_MAKE_FILE_BACKUP) != 0;
|
|
|
|
if (!dynamicName)
|
|
logfile = !dynamicName ? OpenFile(_filename, _mode, mode == "w" && backup) : NULL;
|
|
}
|
|
|
|
AppenderFile::~AppenderFile()
|
|
{
|
|
CloseFile();
|
|
}
|
|
|
|
void AppenderFile::_write(LogMessage const& message)
|
|
{
|
|
bool exceedMaxSize = maxFileSize > 0 && (fileSize.value() + message.Size()) > maxFileSize;
|
|
|
|
if (dynamicName)
|
|
{
|
|
char namebuf[TRINITY_PATH_MAX];
|
|
snprintf(namebuf, TRINITY_PATH_MAX, filename.c_str(), message.param1.c_str());
|
|
// always use "a" with dynamic name otherwise it could delete the log we wrote in last _write() call
|
|
FILE* file = OpenFile(namebuf, "a", backup || exceedMaxSize);
|
|
if (!file)
|
|
return;
|
|
fprintf(file, "%s%s", message.prefix.c_str(), message.text.c_str());
|
|
fflush(file);
|
|
fileSize += uint64(message.Size());
|
|
fclose(file);
|
|
return;
|
|
}
|
|
else if (exceedMaxSize)
|
|
logfile = OpenFile(filename, "w", true);
|
|
|
|
if (!logfile)
|
|
return;
|
|
|
|
fprintf(logfile, "%s%s", message.prefix.c_str(), message.text.c_str());
|
|
fflush(logfile);
|
|
fileSize += uint64(message.Size());
|
|
}
|
|
|
|
FILE* AppenderFile::OpenFile(std::string const &filename, std::string const &mode, bool backup)
|
|
{
|
|
std::string fullName(logDir + filename);
|
|
if (backup)
|
|
{
|
|
CloseFile();
|
|
std::string newName(fullName);
|
|
newName.push_back('.');
|
|
newName.append(LogMessage::getTimeStr(time(NULL)));
|
|
rename(fullName.c_str(), newName.c_str()); // no error handling... if we couldn't make a backup, just ignore
|
|
}
|
|
|
|
if (FILE* ret = fopen(fullName.c_str(), mode.c_str()))
|
|
{
|
|
fileSize = ftell(ret);
|
|
return ret;
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
void AppenderFile::CloseFile()
|
|
{
|
|
if (logfile)
|
|
{
|
|
fclose(logfile);
|
|
logfile = NULL;
|
|
}
|
|
}
|