mirror of
https://github.com/TrinityCore/TrinityCore.git
synced 2026-01-19 17:05:44 +01:00
1ee7196ec0
Example: ==8753== Possible data race during read of size 8 at 0x2e803e60 by thread #8 ==8753== at 0xDD0FFC: PreparedResultSet::operator[](unsigned int) const (QueryResult.h:83) ==8753== by 0x131D82D: WorldSession::HandleCharEnum(Trinity::AutoPtr<PreparedResultSet, ACE_Null_Mutex>) (CharacterHandler.cpp:217) ==8753== by 0x118F8C3: WorldSession::ProcessQueryCallbacks() (WorldSession.cpp:1087) {..} ==8753== Address 0x2e803e60 is 0 bytes inside a block of size 16 alloc'd ==8753== at 0x4C28B75: operator new(unsigned long) (vg_replace_malloc.c:261) ==8753== by 0x137D515: __gnu_cxx::new_allocator<Field*>::allocate(unsigned long, void const*) (new_allocator.h:92) ==8753== by 0x137D378: std::_Vector_base<Field*, std::allocator<Field*> >::_M_allocate(unsigned long) (in /home/aokromes/bin/bin/worldserver) ==8753== by 0x137CEC6: std::vector<Field*, std::allocator<Field*> >::_M_fill_insert(__gnu_cxx::__normal_iterator<Field**, std::vector<Field*, std::allocator<Field*> > >, unsigned long, Field* const&) (vector.tcc:416) ==8753== by 0x137CB27: std::vector<Field*, std::allocator<Field*> >::insert(__gnu_cxx::__normal_iterator<Field**, std::vector<Field*, std::allocator<Field*> > >, unsigned long, Field* const&) (stl_vector.h:944) ==8753== by 0x137C964: std::vector<Field*, std::allocator<Field*> >::resize(unsigned long, Field*) (stl_vector.h:632) ==8753== by 0x137BFCA: PreparedResultSet::PreparedResultSet(st_mysql_stmt*, st_mysql_res*, unsigned long, unsigned int) (QueryResult.cpp:98) ==8753== by 0x137A12B: MySQLConnection::Query(PreparedStatement*) (MySQLConnection.cpp:493) ==8753== by 0x137F663: PreparedStatementTask::Execute() (PreparedStatement.cpp:412) Have a feeling this is a false positive, though. Nevertheless good to get rid of.
110 lines
2.8 KiB
C++
Executable File
110 lines
2.8 KiB
C++
Executable File
/*
|
|
* Copyright (C) 2008-2012 TrinityCore <http://www.trinitycore.org/>
|
|
* Copyright (C) 2005-2009 MaNGOS <http://getmangos.com/>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef QUERYRESULT_H
|
|
#define QUERYRESULT_H
|
|
|
|
#include "AutoPtr.h"
|
|
#include <ace/Thread_Mutex.h>
|
|
|
|
#include "Field.h"
|
|
#include "Log.h"
|
|
|
|
#ifdef _WIN32
|
|
#include <winsock2.h>
|
|
#endif
|
|
#include <mysql.h>
|
|
|
|
class ResultSet
|
|
{
|
|
public:
|
|
ResultSet(MYSQL_RES* result, MYSQL_FIELD* fields, uint64 rowCount, uint32 fieldCount);
|
|
~ResultSet();
|
|
|
|
bool NextRow();
|
|
uint64 GetRowCount() const { return _rowCount; }
|
|
uint32 GetFieldCount() const { return _fieldCount; }
|
|
|
|
Field* Fetch() const { return _currentRow; }
|
|
const Field & operator [] (uint32 index) const
|
|
{
|
|
ASSERT(index < _fieldCount);
|
|
return _currentRow[index];
|
|
}
|
|
|
|
protected:
|
|
uint64 _rowCount;
|
|
Field* _currentRow;
|
|
uint32 _fieldCount;
|
|
|
|
private:
|
|
void CleanUp();
|
|
MYSQL_RES* _result;
|
|
MYSQL_FIELD* _fields;
|
|
};
|
|
|
|
typedef Trinity::AutoPtr<ResultSet, ACE_Thread_Mutex> QueryResult;
|
|
|
|
class PreparedResultSet
|
|
{
|
|
public:
|
|
PreparedResultSet(MYSQL_STMT* stmt, MYSQL_RES* result, uint64 rowCount, uint32 fieldCount);
|
|
~PreparedResultSet();
|
|
|
|
bool NextRow();
|
|
uint64 GetRowCount() const { return m_rowCount; }
|
|
uint32 GetFieldCount() const { return m_fieldCount; }
|
|
|
|
Field* Fetch() const
|
|
{
|
|
ASSERT(m_rowPosition < m_rowCount);
|
|
return m_rows[uint32(m_rowPosition)];
|
|
}
|
|
|
|
const Field & operator [] (uint32 index) const
|
|
{
|
|
ASSERT(m_rowPosition < m_rowCount);
|
|
ASSERT(index < m_fieldCount);
|
|
return m_rows[uint32(m_rowPosition)][index];
|
|
}
|
|
|
|
protected:
|
|
std::vector<Field*> m_rows;
|
|
uint64 m_rowCount;
|
|
uint64 m_rowPosition;
|
|
uint32 m_fieldCount;
|
|
|
|
private:
|
|
MYSQL_BIND* m_rBind;
|
|
MYSQL_STMT* m_stmt;
|
|
MYSQL_RES* m_res;
|
|
|
|
my_bool* m_isNull;
|
|
unsigned long* m_length;
|
|
|
|
void FreeBindBuffer();
|
|
void CleanUp();
|
|
bool _NextRow();
|
|
|
|
};
|
|
|
|
typedef Trinity::AutoPtr<PreparedResultSet, ACE_Thread_Mutex> PreparedQueryResult;
|
|
|
|
#endif
|
|
|