aboutsummaryrefslogtreecommitdiff
path: root/src/SFileReadFile.cpp
AgeCommit message (Collapse)Author
2018-05-01Add brackets in SFileSetFilePointer when pointer < 0nvs
This addresses a bug introduced in: - fe652fe4a6e02041194a0f1b29a0086bd99fb14d Brackets were not properly included, causing `SFILE_INVALID_POS` to be returned whenever `DeltaPos` was less than zero, instead of only when the resulting position was negative.
2018-04-26Set SFileSetFilePointer error when new pointer < 0nvs
This addresses an apparent oversight in the following commit: - 951f416398b3aa0b32969b4a391a3103443ad99e An error is not actually set, even though the return value now correctly indicates failure. Per the documentation for [`SetFilerPointer ()`][1], this should be set to `ERROR_NEGATIVE_SEEK` on Windows. On Mac/Linux, this would be `EINVAL` as per the documentation for [`fseek ()`][2]. [1]: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365541(v=vs.85).aspx [2]: http://pubs.opengroup.org/onlinepubs/9699919799/functions/fseek.html
2017-08-28SFileSetFilePointer error when new pointer is <0Lectem
The standard behaviour for fseek / SetFilePointer when the new pointed value would be negative is to not move the pointer and return an error. See : https://msdn.microsoft.com/en-us/library/windows/desktop/aa365541(v=vs.85).aspx `If a new file pointer is a negative value, the function fails, the file pointer is not moved, and the code returned by GetLastError is ERROR_NEGATIVE_SEEK.`
2016-11-06+ Reverted include directoriesLadislav Zezula
2016-11-05fix cmake dependency and move headers to includeLectem
2016-05-03+ Fixed bounds checking in SFileSetFilePointerLadislav Zezula
2015-05-28+ Fixed bug in SFileReadFileunknown
2015-05-28+ Fixed coverity bugsLadislav Zezula
2015-05-28+ Fixed defects found by Coverity (well, most of them)Ladislav Zezula
2015-05-06+ Fixed possible stack overflow in HashStringJenkinsunknown
+ StormLib now creates a listfile even for empty archives to make sure it will be maintained at later point when files are added to it + Bug fixes in listfile loading
2015-05-01+ Removed back reference of FileTable -> HashTable, as it is logically incorrectunknown
+ Optimized patching process so it consimes less memory + Added hash table and block table defragmenting for malformed War3 maps
2015-04-01+ Better handling of MPQs corrupted by yet another silly MPQ protectorunknown
2015-03-13+ Support for MPQ.KangTooJee map protectorunknown
+ Compacting optimized
2015-01-18+ More paratemer checking to make nitpickers happyunknown
2014-12-02+ Files with zero size are now processed properly during archive compactingLadislav Zezula
+ Fixed few memory leaks
2014-05-06+ Fixed bug in SFileSetFilePointerLadislav Zezula
2014-03-14+ Improved key detection for archives with large sector sizesLadislav Zezula
2013-12-15+ static analysis issues fixedLadislav
2013-12-12+ Fixed warningsLadislav Zezula
+ Added SBaseDumpData to the makefiles
2013-12-05+ StormLib 9.0 BETALadislav Zezula
2013-11-15+ Support for compile-time messages for deprecated symbolsLadislav
+ Replaced MPQ_FILE_COMPRESSED with more descriptive MPQ_FILE_COMPRESS_MASK
2013-11-13+ Support for SQP and MPK archivesLadislav Zezula
+ Makefiles fixed
2013-01-11Initial creationLadislav Zezula