From 89a364c8bb10f00c8583cbeb04234e9cbdc1a815 Mon Sep 17 00:00:00 2001 From: divinity76 Date: Mon, 24 Nov 2025 04:10:01 +0100 Subject: silence -Wswitch-enum compiling with clang, https://clang.llvm.org/docs/DiagnosticsReference.html#wswitch-enum ``` /home/hans/projects/StormLib/src/SFileOpenArchive.cpp:539:16: warning: 4 enumeration values not handled in switch: 'MapTypeNotChecked', 'MapTypeNotRecognized', 'MapTypeAviFile'... [-Wswitch] switch(MapType) ^~~~~~~ 1 warning generated. ``` --- src/SFileOpenArchive.cpp | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/SFileOpenArchive.cpp') diff --git a/src/SFileOpenArchive.cpp b/src/SFileOpenArchive.cpp index 58f4d01..0a5d38e 100644 --- a/src/SFileOpenArchive.cpp +++ b/src/SFileOpenArchive.cpp @@ -547,6 +547,9 @@ bool WINAPI SFileOpenArchive( ha->dwValidFileFlags = MPQ_FILE_VALID_FLAGS_W3X; ha->dwFlags |= MPQ_FLAG_WAR3_MAP; break; + default: + // silence -Wswitch-enum + break; } // Set the size of file sector. Be sure to check for integer overflow -- cgit v1.2.3 From 897366f4c657db60d5708daf4697e0a9373595fb Mon Sep 17 00:00:00 2001 From: divinity76 Date: Mon, 24 Nov 2025 04:15:53 +0100 Subject: stricter silence if we do default:, it may silence a real error in the future --- src/SFileOpenArchive.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/SFileOpenArchive.cpp') diff --git a/src/SFileOpenArchive.cpp b/src/SFileOpenArchive.cpp index 0a5d38e..d07d325 100644 --- a/src/SFileOpenArchive.cpp +++ b/src/SFileOpenArchive.cpp @@ -547,7 +547,10 @@ bool WINAPI SFileOpenArchive( ha->dwValidFileFlags = MPQ_FILE_VALID_FLAGS_W3X; ha->dwFlags |= MPQ_FLAG_WAR3_MAP; break; - default: + case MapTypeNotChecked: + case MapTypeNotRecognized: + case MapTypeAviFile: + case MapTypeStarcraft2: // silence -Wswitch-enum break; } -- cgit v1.2.3