diff options
author | Shauren <shauren.trinity@gmail.com> | 2017-04-03 00:27:16 +0200 |
---|---|---|
committer | Shauren <shauren.trinity@gmail.com> | 2017-04-03 00:27:16 +0200 |
commit | 8f49a32d1313ca1a40b77c77058249b4fa510565 (patch) | |
tree | b3273676c26faa425f36286f049361fad057234a | |
parent | 2a8294031b9ec73f1f082bd0137d9431545808ff (diff) |
Core/Spells: Removed even more uses of SpellIcon to identify spells
-rw-r--r-- | sql/updates/world/master/2017_04_03_00_world.sql | 1 | ||||
-rw-r--r-- | src/server/game/Entities/Unit/Unit.cpp | 12 | ||||
-rw-r--r-- | src/server/game/Entities/Unit/Unit.h | 1 | ||||
-rw-r--r-- | src/server/game/Spells/Auras/SpellAuras.cpp | 31 | ||||
-rw-r--r-- | src/server/game/Spells/SpellEffects.cpp | 6 | ||||
-rw-r--r-- | src/server/game/Spells/SpellMgr.cpp | 2 | ||||
-rw-r--r-- | src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_twin_valkyr.cpp | 59 | ||||
-rw-r--r-- | src/server/scripts/Spells/spell_hunter.cpp | 39 | ||||
-rw-r--r-- | src/server/scripts/Spells/spell_priest.cpp | 93 | ||||
-rw-r--r-- | src/server/scripts/Spells/spell_rogue.cpp | 55 | ||||
-rw-r--r-- | src/server/scripts/Spells/spell_warlock.cpp | 86 |
11 files changed, 18 insertions, 367 deletions
diff --git a/sql/updates/world/master/2017_04_03_00_world.sql b/sql/updates/world/master/2017_04_03_00_world.sql new file mode 100644 index 00000000000..ad2bc15e251 --- /dev/null +++ b/sql/updates/world/master/2017_04_03_00_world.sql @@ -0,0 +1 @@ +DELETE FROM `spell_script_names` WHERE `ScriptName` IN ('spell_hun_invigoration','spell_pri_renew','spell_pri_shadow_word_death','spell_rog_recuperate','spell_warl_life_tap'); diff --git a/src/server/game/Entities/Unit/Unit.cpp b/src/server/game/Entities/Unit/Unit.cpp index 98b66c1a7b1..e477fdd03d0 100644 --- a/src/server/game/Entities/Unit/Unit.cpp +++ b/src/server/game/Entities/Unit/Unit.cpp @@ -4234,11 +4234,6 @@ AuraEffect* Unit::GetAuraEffect(AuraType type, SpellFamilyNames family, flag128 return NULL; } -AuraEffect* Unit::GetDummyAuraEffect(SpellFamilyNames name, uint32 iconId, uint8 effIndex) const -{ - return GetAuraEffect(SPELL_AURA_DUMMY, name, iconId, effIndex); -} - AuraApplication * Unit::GetAuraApplication(uint32 spellId, ObjectGuid casterGUID, ObjectGuid itemCasterGUID, uint32 reqEffMask, AuraApplication * except) const { AuraApplicationMapBounds range = m_appliedAuras.equal_range(spellId); @@ -8109,13 +8104,6 @@ float Unit::GetUnitSpellCriticalChance(Unit* victim, SpellInfo const* spellProto // Custom crit by class switch (spellProto->SpellFamilyName) { - case SPELLFAMILY_DRUID: - // Improved Faerie Fire - if (victim->HasAuraState(AURA_STATE_FAERIE_FIRE)) - if (AuraEffect const* aurEff = GetDummyAuraEffect(SPELLFAMILY_DRUID, 109, 0)) - crit_chance += aurEff->GetAmount(); - - break; case SPELLFAMILY_ROGUE: // Shiv-applied poisons can't crit if (FindCurrentSpellBySpellId(5938)) diff --git a/src/server/game/Entities/Unit/Unit.h b/src/server/game/Entities/Unit/Unit.h index 686c367e918..37d7c7290bd 100644 --- a/src/server/game/Entities/Unit/Unit.h +++ b/src/server/game/Entities/Unit/Unit.h @@ -1884,7 +1884,6 @@ class TC_GAME_API Unit : public WorldObject AuraEffect* GetAuraEffect(uint32 spellId, uint8 effIndex, ObjectGuid casterGUID = ObjectGuid::Empty) const; AuraEffect* GetAuraEffectOfRankedSpell(uint32 spellId, uint8 effIndex, ObjectGuid casterGUID = ObjectGuid::Empty) const; AuraEffect* GetAuraEffect(AuraType type, SpellFamilyNames family, flag128 const& familyFlag, ObjectGuid casterGUID = ObjectGuid::Empty) const; - AuraEffect* GetDummyAuraEffect(SpellFamilyNames name, uint32 iconId, uint8 effIndex) const; AuraApplication * GetAuraApplication(uint32 spellId, ObjectGuid casterGUID = ObjectGuid::Empty, ObjectGuid itemCasterGUID = ObjectGuid::Empty, uint32 reqEffMask = 0, AuraApplication * except = NULL) const; Aura* GetAura(uint32 spellId, ObjectGuid casterGUID = ObjectGuid::Empty, ObjectGuid itemCasterGUID = ObjectGuid::Empty, uint32 reqEffMask = 0) const; diff --git a/src/server/game/Spells/Auras/SpellAuras.cpp b/src/server/game/Spells/Auras/SpellAuras.cpp index d3291cb9006..7eeb4188975 100644 --- a/src/server/game/Spells/Auras/SpellAuras.cpp +++ b/src/server/game/Spells/Auras/SpellAuras.cpp @@ -1316,37 +1316,6 @@ void Aura::HandleAuraSpecificMods(AuraApplication const* aurApp, Unit* caster, b } } break; - case SPELLFAMILY_PRIEST: - if (!caster) - break; - // Devouring Plague - if (GetSpellInfo()->SpellFamilyFlags[0] & 0x02000000 && GetEffect(0)) - { - // Improved Devouring Plague - if (AuraEffect const* aurEff = caster->GetDummyAuraEffect(SPELLFAMILY_PRIEST, 3790, 0)) - { - uint32 damage = caster->SpellDamageBonusDone(target, GetSpellInfo(), GetEffect(0)->GetAmount(), DOT, GetEffect(0)->GetSpellEffectInfo()); - damage *= caster->SpellDamagePctDone(target, GetSpellInfo(), SPELL_DIRECT_DAMAGE); - damage = target->SpellDamageBonusTaken(caster, GetSpellInfo(), damage, DOT, GetEffect(0)->GetSpellEffectInfo()); - int32 basepoints0 = aurEff->GetAmount() * GetEffect(0)->GetTotalTicks() * int32(damage) / 100; - int32 heal = int32(CalculatePct(basepoints0, 15)); - - caster->CastCustomSpell(target, 63675, &basepoints0, NULL, NULL, true, NULL, GetEffect(0)); - caster->CastCustomSpell(caster, 75999, &heal, NULL, NULL, true, NULL, GetEffect(0)); - } - } - // Power Word: Shield - else if (m_spellInfo->SpellFamilyFlags[0] & 0x1 && m_spellInfo->SpellFamilyFlags[2] & 0x400 && GetEffect(0)) - { - // Glyph of Power Word: Shield - if (AuraEffect* glyph = caster->GetAuraEffect(55672, 0)) - { - // instantly heal m_amount% of the absorb-value - int32 heal = glyph->GetAmount() * GetEffect(0)->GetAmount()/100; - caster->CastCustomSpell(GetUnitOwner(), 56160, &heal, nullptr, nullptr, true, nullptr, GetEffect(0)); - } - } - break; case SPELLFAMILY_ROGUE: // Sprint (skip non player cast spells by category) if (GetSpellInfo()->SpellFamilyFlags[0] & 0x40 && GetSpellInfo()->GetCategory() == 44) diff --git a/src/server/game/Spells/SpellEffects.cpp b/src/server/game/Spells/SpellEffects.cpp index e45218d0840..d596cbffbc2 100644 --- a/src/server/game/Spells/SpellEffects.cpp +++ b/src/server/game/Spells/SpellEffects.cpp @@ -2957,12 +2957,6 @@ void Spell::EffectWeaponDmg(SpellEffIndex effIndex) if (m_caster->GetTypeId() == TYPEID_PLAYER) m_caster->ToPlayer()->AddComboPoints(1, this); } - // Shred, Maul - Rend and Tear - else if (m_spellInfo->SpellFamilyFlags[0] & 0x00008800 && unitTarget->HasAuraState(AURA_STATE_BLEEDING)) - { - if (AuraEffect const* rendAndTear = m_caster->GetDummyAuraEffect(SPELLFAMILY_DRUID, 2859, 0)) - AddPct(totalDamagePercentMod, rendAndTear->GetAmount()); - } break; } case SPELLFAMILY_HUNTER: diff --git a/src/server/game/Spells/SpellMgr.cpp b/src/server/game/Spells/SpellMgr.cpp index f7d015cb248..2f9171f2caa 100644 --- a/src/server/game/Spells/SpellMgr.cpp +++ b/src/server/game/Spells/SpellMgr.cpp @@ -187,7 +187,7 @@ DiminishingGroup GetDiminishingReturnsGroupForSpell(SpellInfo const* spellproto) return DIMINISHING_STUN; // Incapacitating Roar -- 99, no flags on the stun, 14 - if (spellproto->SpellFamilyFlags[1] 0x1) + if (spellproto->SpellFamilyFlags[1] & 0x1) return DIMINISHING_INCAPACITATE; // Cyclone -- 33786 diff --git a/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_twin_valkyr.cpp b/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_twin_valkyr.cpp index 08c6da9c06e..6fb10af896e 100644 --- a/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_twin_valkyr.cpp +++ b/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_twin_valkyr.cpp @@ -108,14 +108,6 @@ enum Stages MAX_STAGES }; -#define SPELL_DARK_ESSENCE_HELPER RAID_MODE<uint32>(65684, 67176, 67177, 67178) -#define SPELL_LIGHT_ESSENCE_HELPER RAID_MODE<uint32>(65686, 67222, 67223, 67224) - -#define SPELL_POWERING_UP_HELPER RAID_MODE<uint32>(67590, 67602, 67603, 67604) - -#define SPELL_UNLEASHED_DARK_HELPER RAID_MODE<uint32>(65808, 67172, 67173, 67174) -#define SPELL_UNLEASHED_LIGHT_HELPER RAID_MODE<uint32>(65795, 67238, 67239, 67240) - enum Actions { ACTION_VORTEX, @@ -220,12 +212,12 @@ struct boss_twin_baseAI : public BossAI switch (summoned->GetEntry()) { case NPC_LIGHT_ESSENCE: - instance->DoRemoveAurasDueToSpellOnPlayers(SPELL_LIGHT_ESSENCE_HELPER); - instance->DoRemoveAurasDueToSpellOnPlayers(SPELL_POWERING_UP_HELPER); + instance->DoRemoveAurasDueToSpellOnPlayers(SPELL_LIGHT_ESSENCE); + instance->DoRemoveAurasDueToSpellOnPlayers(SPELL_POWERING_UP); break; case NPC_DARK_ESSENCE: - instance->DoRemoveAurasDueToSpellOnPlayers(SPELL_DARK_ESSENCE_HELPER); - instance->DoRemoveAurasDueToSpellOnPlayers(SPELL_POWERING_UP_HELPER); + instance->DoRemoveAurasDueToSpellOnPlayers(SPELL_DARK_ESSENCE); + instance->DoRemoveAurasDueToSpellOnPlayers(SPELL_POWERING_UP); break; case NPC_BULLET_CONTROLLER: me->m_Events.AddEvent(new OrbsDespawner(me), me->m_Events.CalculateTime(100)); @@ -363,7 +355,7 @@ class boss_fjola : public CreatureScript AuraState = AURA_STATE_UNKNOWN22; SisterNpcId = NPC_DARKBANE; MyEmphatySpellId = SPELL_TWIN_EMPATHY_DARK; - OtherEssenceSpellId = SPELL_DARK_ESSENCE_HELPER; + OtherEssenceSpellId = SPELL_DARK_ESSENCE; SurgeSpellId = SPELL_LIGHT_SURGE; VortexSpellId = SPELL_LIGHT_VORTEX; ShieldSpellId = SPELL_LIGHT_SHIELD; @@ -471,7 +463,7 @@ class boss_eydis : public CreatureScript AuraState = AURA_STATE_UNKNOWN19; SisterNpcId = NPC_LIGHTBANE; MyEmphatySpellId = SPELL_TWIN_EMPATHY_LIGHT; - OtherEssenceSpellId = SPELL_LIGHT_ESSENCE_HELPER; + OtherEssenceSpellId = SPELL_LIGHT_ESSENCE; SurgeSpellId = SPELL_DARK_SURGE; VortexSpellId = SPELL_DARK_VORTEX; ShieldSpellId = SPELL_DARK_SHIELD; @@ -503,10 +495,10 @@ class npc_essence_of_twin : public CreatureScript switch (me->GetEntry()) { case NPC_LIGHT_ESSENCE: - spellReturned = (data == ESSENCE_REMOVE) ? SPELL_DARK_ESSENCE_HELPER : SPELL_LIGHT_ESSENCE_HELPER; + spellReturned = (data == ESSENCE_REMOVE) ? SPELL_DARK_ESSENCE : SPELL_LIGHT_ESSENCE; break; case NPC_DARK_ESSENCE: - spellReturned = (data == ESSENCE_REMOVE) ? SPELL_LIGHT_ESSENCE_HELPER : SPELL_DARK_ESSENCE_HELPER; + spellReturned = (data == ESSENCE_REMOVE) ? SPELL_LIGHT_ESSENCE : SPELL_DARK_ESSENCE; break; default: break; @@ -604,7 +596,7 @@ class npc_unleashed_dark : public CreatureScript { if (me->SelectNearestPlayer(3.0f)) { - DoCastAOE(SPELL_UNLEASHED_DARK_HELPER); + DoCastAOE(SPELL_UNLEASHED_DARK); me->GetMotionMaster()->MoveIdle(); me->DespawnOrUnsummon(1*IN_MILLISECONDS); } @@ -636,7 +628,7 @@ class npc_unleashed_light : public CreatureScript { if (me->SelectNearestPlayer(3.0f)) { - DoCastAOE(SPELL_UNLEASHED_LIGHT_HELPER); + DoCastAOE(SPELL_UNLEASHED_LIGHT); me->GetMotionMaster()->MoveIdle(); me->DespawnOrUnsummon(1*IN_MILLISECONDS); } @@ -691,45 +683,26 @@ class spell_powering_up : public SpellScriptLoader { PrepareSpellScript(spell_powering_up_SpellScript); - public: - spell_powering_up_SpellScript() + bool Validate(SpellInfo const* spellInfo) override { - spellId = 0; - poweringUp = 0; - } - - private: - uint32 spellId; - uint32 poweringUp; - - bool Load() override - { - spellId = SPELL_SURGE_OF_SPEED; - if (!sSpellMgr->GetSpellInfo(spellId)) - return false; - - poweringUp = SPELL_POWERING_UP; - if (!sSpellMgr->GetSpellInfo(poweringUp)) - return false; - - return true; + return ValidateSpellInfo({ SPELL_SURGE_OF_SPEED, SPELL_POWERING_UP }); } void HandleScriptEffect(SpellEffIndex /*effIndex*/) { if (Unit* target = GetHitUnit()) { - if (Aura* pAura = target->GetAura(poweringUp)) + if (Aura* pAura = target->GetAura(SPELL_POWERING_UP)) { if (pAura->GetStackAmount() >= 100) { - if (target->GetDummyAuraEffect(SPELLFAMILY_GENERIC, 2206, EFFECT_1)) + if (target->HasAura(SPELL_DARK_ESSENCE)) target->CastSpell(target, SPELL_EMPOWERED_DARK, true); - if (target->GetDummyAuraEffect(SPELLFAMILY_GENERIC, 2845, EFFECT_1)) + if (target->HasAura(SPELL_LIGHT_ESSENCE)) target->CastSpell(target, SPELL_EMPOWERED_LIGHT, true); - target->RemoveAurasDueToSpell(poweringUp); + target->RemoveAurasDueToSpell(SPELL_POWERING_UP); } } } diff --git a/src/server/scripts/Spells/spell_hunter.cpp b/src/server/scripts/Spells/spell_hunter.cpp index 9e8bc2ce197..54761ee98f9 100644 --- a/src/server/scripts/Spells/spell_hunter.cpp +++ b/src/server/scripts/Spells/spell_hunter.cpp @@ -39,7 +39,6 @@ enum HunterSpells SPELL_HUNTER_GENERIC_ENERGIZE_FOCUS = 91954, SPELL_HUNTER_IMPROVED_MEND_PET = 24406, SPELL_HUNTER_INSANITY = 95809, - SPELL_HUNTER_INVIGORATION_TRIGGERED = 53398, SPELL_HUNTER_LOCK_AND_LOAD = 56453, SPELL_HUNTER_MASTERS_CALL_TRIGGERED = 62305, SPELL_HUNTER_MISDIRECTION_PROC = 35079, @@ -275,43 +274,6 @@ class spell_hun_improved_mend_pet : public SpellScriptLoader } }; -// 53412 - Invigoration -class spell_hun_invigoration : public SpellScriptLoader -{ - public: - spell_hun_invigoration() : SpellScriptLoader("spell_hun_invigoration") { } - - class spell_hun_invigoration_SpellScript : public SpellScript - { - PrepareSpellScript(spell_hun_invigoration_SpellScript); - - bool Validate(SpellInfo const* /*spellInfo*/) override - { - if (!sSpellMgr->GetSpellInfo(SPELL_HUNTER_INVIGORATION_TRIGGERED)) - return false; - return true; - } - - void HandleScriptEffect(SpellEffIndex /*effIndex*/) - { - if (Unit* unitTarget = GetHitUnit()) - if (AuraEffect* aurEff = unitTarget->GetDummyAuraEffect(SPELLFAMILY_HUNTER, 3487, 0)) - if (roll_chance_i(aurEff->GetAmount())) - unitTarget->CastSpell(unitTarget, SPELL_HUNTER_INVIGORATION_TRIGGERED, true); - } - - void Register() override - { - OnEffectHitTarget += SpellEffectFn(spell_hun_invigoration_SpellScript::HandleScriptEffect, EFFECT_0, SPELL_EFFECT_SCRIPT_EFFECT); - } - }; - - SpellScript* GetSpellScript() const override - { - return new spell_hun_invigoration_SpellScript(); - } -}; - // 53478 - Last Stand Pet class spell_hun_last_stand_pet : public SpellScriptLoader { @@ -1107,7 +1069,6 @@ void AddSC_hunter_spell_scripts() new spell_hun_cobra_shot(); new spell_hun_disengage(); new spell_hun_improved_mend_pet(); - new spell_hun_invigoration(); new spell_hun_last_stand_pet(); new spell_hun_masters_call(); new spell_hun_misdirection(); diff --git a/src/server/scripts/Spells/spell_priest.cpp b/src/server/scripts/Spells/spell_priest.cpp index b5fffcc9259..e6c1eb43b2f 100644 --- a/src/server/scripts/Spells/spell_priest.cpp +++ b/src/server/scripts/Spells/spell_priest.cpp @@ -42,7 +42,6 @@ enum PriestSpells SPELL_PRIEST_DISPEL_MAGIC_FRIENDLY = 97690, SPELL_PRIEST_DISPEL_MAGIC_HOSTILE = 97691, SPELL_PRIEST_DIVINE_AEGIS = 47753, - SPELL_PRIEST_DIVINE_TOUCH = 63544, SPELL_PRIEST_GLYPH_OF_CIRCLE_OF_HEALING = 55675, SPELL_PRIEST_GLYPH_OF_DISPEL_MAGIC = 55677, SPELL_PRIEST_GLYPH_OF_DISPEL_MAGIC_HEAL = 56131, @@ -66,7 +65,6 @@ enum PriestSpells SPELL_PRIEST_RENEWED_HOPE_EFFECT = 197470, SPELL_PRIEST_SHADOWFORM_VISUAL_WITHOUT_GLYPH = 107903, SPELL_PRIEST_SHADOWFORM_VISUAL_WITH_GLYPH = 107904, - SPELL_PRIEST_SHADOW_WORD_DEATH = 32409, SPELL_PRIEST_SHIELD_DISCIPLINE_PASSIVE = 197045, SPELL_PRIEST_SHIELD_DISCIPLINE_ENERGIZE = 47755, SPELL_PRIEST_STRENGTH_OF_SOUL = 197535, @@ -80,13 +78,6 @@ enum PriestSpells SPELL_PRIEST_VOID_SHIELD_EFFECT = 199145 }; -enum PriestSpellIcons -{ - PRIEST_ICON_ID_BORROWED_TIME = 2899, - PRIEST_ICON_ID_DIVINE_TOUCH_TALENT = 3021, - PRIEST_ICON_ID_PAIN_AND_SUFFERING = 2874 -}; - enum MiscSpells { SPELL_GEN_REPLENISHMENT = 57669 @@ -1045,88 +1036,6 @@ class spell_pri_prayer_of_mending_heal : public SpellScriptLoader } }; -// 139 - Renew -class spell_pri_renew : public SpellScriptLoader -{ - public: - spell_pri_renew() : SpellScriptLoader("spell_pri_renew") { } - - class spell_pri_renew_AuraScript : public AuraScript - { - PrepareAuraScript(spell_pri_renew_AuraScript); - - bool Validate(SpellInfo const* /*spellInfo*/) override - { - if (!sSpellMgr->GetSpellInfo(SPELL_PRIEST_DIVINE_TOUCH)) - return false; - return true; - } - - bool Load() override - { - return GetCaster() && GetCaster()->GetTypeId() == TYPEID_PLAYER; - } - - void HandleApplyEffect(AuraEffect const* aurEff, AuraEffectHandleModes /*mode*/) - { - if (Unit* caster = GetCaster()) - { - // Divine Touch - if (AuraEffect const* empoweredRenewAurEff = caster->GetDummyAuraEffect(SPELLFAMILY_PRIEST, PRIEST_ICON_ID_DIVINE_TOUCH_TALENT, EFFECT_0)) - { - uint32 heal = caster->SpellHealingBonusDone(GetTarget(), GetSpellInfo(), aurEff->GetAmount(), DOT, aurEff->GetSpellEffectInfo()); - heal = GetTarget()->SpellHealingBonusTaken(caster, GetSpellInfo(), heal, DOT, aurEff->GetSpellEffectInfo()); - int32 basepoints0 = CalculatePct(int32(heal) * aurEff->GetTotalTicks(), empoweredRenewAurEff->GetAmount()); - caster->CastCustomSpell(GetTarget(), SPELL_PRIEST_DIVINE_TOUCH, &basepoints0, NULL, NULL, true, NULL, aurEff); - } - } - } - - void Register() override - { - OnEffectApply += AuraEffectApplyFn(spell_pri_renew_AuraScript::HandleApplyEffect, EFFECT_0, SPELL_AURA_PERIODIC_HEAL, AURA_EFFECT_HANDLE_REAL_OR_REAPPLY_MASK); - } - }; - - AuraScript* GetAuraScript() const override - { - return new spell_pri_renew_AuraScript(); - } -}; - -// 32379 - Shadow Word Death -class spell_pri_shadow_word_death : public SpellScriptLoader -{ - public: - spell_pri_shadow_word_death() : SpellScriptLoader("spell_pri_shadow_word_death") { } - - class spell_pri_shadow_word_death_SpellScript : public SpellScript - { - PrepareSpellScript(spell_pri_shadow_word_death_SpellScript); - - void HandleDamage() - { - int32 damage = GetHitDamage(); - - // Pain and Suffering reduces damage - if (AuraEffect* aurEff = GetCaster()->GetDummyAuraEffect(SPELLFAMILY_PRIEST, PRIEST_ICON_ID_PAIN_AND_SUFFERING, EFFECT_1)) - AddPct(damage, aurEff->GetAmount()); - - GetCaster()->CastCustomSpell(GetCaster(), SPELL_PRIEST_SHADOW_WORD_DEATH, &damage, nullptr, nullptr, true); - } - - void Register() override - { - OnHit += SpellHitFn(spell_pri_shadow_word_death_SpellScript::HandleDamage); - } - }; - - SpellScript* GetSpellScript() const override - { - return new spell_pri_shadow_word_death_SpellScript(); - } -}; - // 15473 - Shadowform class spell_pri_shadowform : public SpellScriptLoader { @@ -1406,8 +1315,6 @@ void AddSC_priest_spell_scripts() new spell_pri_phantasm(); new spell_pri_power_word_shield(); new spell_pri_prayer_of_mending_heal(); - new spell_pri_renew(); - new spell_pri_shadow_word_death(); new spell_pri_shadowform(); new spell_pri_vampiric_embrace(); new spell_pri_vampiric_embrace_target(); diff --git a/src/server/scripts/Spells/spell_rogue.cpp b/src/server/scripts/Spells/spell_rogue.cpp index a585d772153..4ddf06e7b5e 100644 --- a/src/server/scripts/Spells/spell_rogue.cpp +++ b/src/server/scripts/Spells/spell_rogue.cpp @@ -59,11 +59,6 @@ enum RogueSpells SPELL_ROGUE_T5_2P_SET_BONUS = 37169 }; -enum RogueSpellIcons -{ - ICON_ROGUE_IMPROVED_RECUPERATE = 4819 -}; - // 13877, 33735, (check 51211, 65956) - Blade Flurry class spell_rog_blade_flurry : public SpellScriptLoader { @@ -551,55 +546,6 @@ class spell_rog_preparation : public SpellScriptLoader } }; -// 73651 - Recuperate -class spell_rog_recuperate : public SpellScriptLoader -{ - public: - spell_rog_recuperate() : SpellScriptLoader("spell_rog_recuperate") { } - - class spell_rog_recuperate_AuraScript : public AuraScript - { - PrepareAuraScript(spell_rog_recuperate_AuraScript); - - bool Load() override - { - return GetCaster()->GetTypeId() == TYPEID_PLAYER; - } - - void OnPeriodic(AuraEffect const* /*aurEff*/) - { - if (Unit* caster = GetCaster()) - if (AuraEffect* effect = GetAura()->GetEffect(EFFECT_0)) - effect->RecalculateAmount(caster); - } - - void CalculateBonus(AuraEffect const* /*aurEff*/, int32& amount, bool& canBeRecalculated) - { - canBeRecalculated = false; - if (Unit* caster = GetCaster()) - { - int32 baseAmount = GetSpellInfo()->GetEffect(EFFECT_0)->CalcValue(caster) * 1000; - // Improved Recuperate - if (AuraEffect const* auraEffect = caster->GetDummyAuraEffect(SPELLFAMILY_ROGUE, ICON_ROGUE_IMPROVED_RECUPERATE, EFFECT_0)) - baseAmount += auraEffect->GetAmount(); - - amount = CalculatePct(caster->GetMaxHealth(), float(baseAmount) / 1000.0f); - } - } - - void Register() override - { - OnEffectPeriodic += AuraEffectPeriodicFn(spell_rog_recuperate_AuraScript::OnPeriodic, EFFECT_0, SPELL_AURA_PERIODIC_HEAL); - DoEffectCalcAmount += AuraEffectCalcAmountFn(spell_rog_recuperate_AuraScript::CalculateBonus, EFFECT_0, SPELL_AURA_PERIODIC_HEAL); - } - }; - - AuraScript* GetAuraScript() const override - { - return new spell_rog_recuperate_AuraScript(); - } -}; - // 1943 - Rupture class spell_rog_rupture : public SpellScriptLoader { @@ -1090,7 +1036,6 @@ void AddSC_rogue_spell_scripts() new spell_rog_killing_spree(); new spell_rog_master_of_subtlety(); new spell_rog_preparation(); - new spell_rog_recuperate(); new spell_rog_rupture(); new spell_rog_shiv(); new spell_rog_stealth(); diff --git a/src/server/scripts/Spells/spell_warlock.cpp b/src/server/scripts/Spells/spell_warlock.cpp index 3e2d9fca5df..1ee3e9aa4bc 100644 --- a/src/server/scripts/Spells/spell_warlock.cpp +++ b/src/server/scripts/Spells/spell_warlock.cpp @@ -33,7 +33,6 @@ enum WarlockSpells { SPELL_WARLOCK_BANE_OF_DOOM_EFFECT = 18662, SPELL_WARLOCK_CREATE_HEALTHSTONE = 23517, - SPELL_WARLOCK_CURSE_OF_DOOM_EFFECT = 18662, SPELL_WARLOCK_DEMONIC_CIRCLE_ALLOW_CAST = 62388, SPELL_WARLOCK_DEMONIC_CIRCLE_SUMMON = 48018, SPELL_WARLOCK_DEMONIC_CIRCLE_TELEPORT = 48020, @@ -51,10 +50,8 @@ enum WarlockSpells SPELL_WARLOCK_FEL_SYNERGY_HEAL = 54181, SPELL_WARLOCK_GLYPH_OF_DEMON_TRAINING = 56249, SPELL_WARLOCK_GLYPH_OF_SHADOWFLAME = 63311, - SPELL_WARLOCK_GLYPH_OF_SIPHON_LIFE = 63106, SPELL_WARLOCK_GLYPH_OF_SOUL_SWAP = 56226, SPELL_WARLOCK_GLYPH_OF_SUCCUBUS = 56250, - SPELL_WARLOCK_HAUNT = 48181, SPELL_WARLOCK_HAUNT_HEAL = 48210, SPELL_WARLOCK_IMMOLATE = 348, SPELL_WARLOCK_IMPROVED_HEALTH_FUNNEL_BUFF_R1 = 60955, @@ -63,14 +60,11 @@ enum WarlockSpells SPELL_WARLOCK_IMPROVED_HEALTH_FUNNEL_R2 = 18704, SPELL_WARLOCK_IMPROVED_SOUL_FIRE_PCT = 85383, SPELL_WARLOCK_IMPROVED_SOUL_FIRE_STATE = 85385, - SPELL_WARLOCK_LIFE_TAP_ENERGIZE = 31818, - SPELL_WARLOCK_LIFE_TAP_ENERGIZE_2 = 32553, SPELL_WARLOCK_NETHER_WARD = 91711, SPELL_WARLOCK_NETHER_TALENT = 91713, SPELL_WARLOCK_RAIN_OF_FIRE = 5740, SPELL_WARLOCK_RAIN_OF_FIRE_DAMAGE = 42223, SPELL_WARLOCK_SHADOW_TRANCE = 17941, - SPELL_WARLOCK_SIPHON_LIFE_HEAL = 63106, SPELL_WARLOCK_SHADOW_WARD = 6229, SPELL_WARLOCK_SOULSHATTER = 32835, SPELL_WARLOCK_SOUL_SWAP_CD_MARKER = 94229, @@ -81,12 +75,6 @@ enum WarlockSpells SPELL_WARLOCK_UNSTABLE_AFFLICTION_DISPEL = 31117 }; -enum WarlockSpellIcons -{ - WARLOCK_ICON_ID_IMPROVED_LIFE_TAP = 208, - WARLOCK_ICON_ID_MANA_FEED = 1982 -}; - enum MiscSpells { SPELL_GEN_REPLENISHMENT = 57669, @@ -829,78 +817,6 @@ class spell_warl_improved_soul_fire : public SpellScriptLoader } }; -// 1454 - Life Tap -/// Updated 4.3.4 -// 6.x fully changed this -/*class spell_warl_life_tap : public SpellScriptLoader -{ - public: - spell_warl_life_tap() : SpellScriptLoader("spell_warl_life_tap") { } - - class spell_warl_life_tap_SpellScript : public SpellScript - { - PrepareSpellScript(spell_warl_life_tap_SpellScript); - - bool Load() override - { - return GetCaster()->GetTypeId() == TYPEID_PLAYER; - } - - bool Validate(SpellInfo const* spellInfo) override - { - if (!sSpellMgr->GetSpellInfo(SPELL_WARLOCK_LIFE_TAP_ENERGIZE) || - !sSpellMgr->GetSpellInfo(SPELL_WARLOCK_LIFE_TAP_ENERGIZE_2)) - return false; - return true; - } - - void HandleDummy(SpellEffIndex effIndex) - { - Player* caster = GetCaster()->ToPlayer(); - if (Unit* target = GetHitUnit()) - { - int32 damage = caster->CountPctFromMaxHealth(GetSpellInfo()->Effects[EFFECT_2].CalcValue()); - int32 mana = CalculatePct(damage, GetSpellInfo()->Effects[EFFECT_1].CalcValue()); - - // Shouldn't Appear in Combat Log - target->ModifyHealth(-damage); - - // Improved Life Tap mod - if (AuraEffect const* aurEff = caster->GetDummyAuraEffect(SPELLFAMILY_WARLOCK, WARLOCK_ICON_ID_IMPROVED_LIFE_TAP, 0)) - AddPct(mana, aurEff->GetAmount()); - - caster->CastCustomSpell(target, SPELL_WARLOCK_LIFE_TAP_ENERGIZE, &mana, NULL, NULL, false); - - // Mana Feed - if (AuraEffect const* aurEff = caster->GetAuraEffect(SPELL_AURA_ADD_FLAT_MODIFIER, SPELLFAMILY_WARLOCK, WARLOCK_ICON_ID_MANA_FEED, 0)) - { - int32 manaFeedVal = aurEff->GetAmount(); - ApplyPct(manaFeedVal, mana); - caster->CastCustomSpell(caster, SPELL_WARLOCK_LIFE_TAP_ENERGIZE_2, &manaFeedVal, NULL, NULL, true, NULL); - } - } - } - - SpellCastResult CheckCast() - { - if (int32(GetCaster()->GetHealth()) > int32(GetCaster()->CountPctFromMaxHealth(GetSpellInfo()->Effects[EFFECT_2].CalcValue()))) - return SPELL_CAST_OK; - return SPELL_FAILED_FIZZLE; - } - - void Register() override - { - OnEffectHitTarget += SpellEffectFn(spell_warl_life_tap_SpellScript::HandleDummy, EFFECT_0, SPELL_EFFECT_DUMMY); - OnCheckCast += SpellCheckCastFn(spell_warl_life_tap_SpellScript::CheckCast); - } - }; - - SpellScript* GetSpellScript() const override - { - return new spell_warl_life_tap_SpellScript(); - } -};*/ - // 687 - Demon Armor // 28176 - Fel Armor class spell_warl_nether_ward_overrride : public SpellScriptLoader @@ -1452,14 +1368,12 @@ void AddSC_warlock_spell_scripts() new spell_warl_demon_soul(); new spell_warl_devour_magic(); new spell_warl_everlasting_affliction(); - //new spell_warl_fel_flame(); new spell_warl_fel_synergy(); new spell_warl_glyph_of_shadowflame(); new spell_warl_haunt(); new spell_warl_health_funnel(); new spell_warl_healthstone_heal(); new spell_warl_improved_soul_fire(); - //new spell_warl_life_tap(); new spell_warl_nether_ward_overrride(); new spell_warl_seduction(); new spell_warl_seed_of_corruption(); |