aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorShauren <shauren.trinity@gmail.com>2025-05-15 16:38:31 +0200
committerOvahlord <dreadkiller@gmx.de>2025-05-26 20:49:46 +0200
commitbb195e274fb63b97cc8e2915f57b65228bf621f0 (patch)
tree83361f8911b5c577098398a9ab2ee2ec5fd33af7 /src
parent4696aecf170acc6b98301132766ac5e17d574cdf (diff)
Core/PacketIO: Fixed WorldPackets::SizedCString read function (it should not attempt to read null terminator if empty)
(cherry picked from commit 150c9cce5d62030c1adb4640469f6bd5831b2103)
Diffstat (limited to 'src')
-rw-r--r--src/server/game/Server/Packets/PacketUtilities.h7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/server/game/Server/Packets/PacketUtilities.h b/src/server/game/Server/Packets/PacketUtilities.h
index 678d6aba977..e865ec40061 100644
--- a/src/server/game/Server/Packets/PacketUtilities.h
+++ b/src/server/game/Server/Packets/PacketUtilities.h
@@ -561,8 +561,11 @@ namespace WorldPackets
{
friend inline ByteBuffer& operator>>(ByteBuffer& data, DataReaderWriter const& string)
{
- const_cast<Container&>(string.Value) = data.ReadString(string.Value.length());
- data.read_skip<char>(); // null terminator
+ if (!string.Value.empty())
+ {
+ const_cast<Container&>(string.Value) = data.ReadString(string.Value.length());
+ (void)data.read<char>(); // null terminator
+ }
return data;
}
};